model_specs: correct voxcpm1 defaults to the engine's own - #404
Closed
CryptVenture wants to merge 1 commit into
Closed
model_specs: correct voxcpm1 defaults to the engine's own#404CryptVenture wants to merge 1 commit into
CryptVenture wants to merge 1 commit into
Conversation
The four defaults the spec published for VoxCPM1 were not the values the engine uses, so a client that populated its form from the spec sent a slower, shorter configuration than the model's own defaults: spec engine (include/engine/community_models/voxcpm1/types.h:13-19) num_inference_steps 50 num_inference_steps 10 max_tokens 1024 max_tokens 4096 min_tokens 0 min_tokens 2 retry_badcase_max_times 2 retry_badcase_max_times 3 VoxCPM1GenerationOptions is the single source of these defaults; the session applies them whenever the request omits the option. Bounds, types and required flags are unchanged, so every request accepted before is still accepted.
CryptVenture
force-pushed
the
pr/spec-voxcpm1-defaults
branch
from
September 3, 2026 00:26
6dd09b2 to
3b0d264
Compare
Contributor
Author
|
Closing for now to stay inside the 3-concurrent-PR policy (see the discussion on #422). Nothing is wrong with the change and CI is green on it; I will reopen it as review slots free. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #372 as requested. This PR is the VoxCPM1 defaults only; the description-only fixes, the strict contract fixes, the ASR/aligner/codec declarations and the MiniMax declarations are separate PRs.
The problem
The four defaults the spec published for VoxCPM1 were not the values the engine uses. A client that populated its form from the spec — the WebUI does — sent a slower and shorter configuration than the model's own defaults, and every one of those requests was legal, so nothing surfaced the mismatch.
num_inference_stepsmax_tokensmin_tokensretry_badcase_max_timesThe engine values are the initialisers of
VoxCPM1GenerationOptionsininclude/engine/community_models/voxcpm1/types.h:13-19, which the session applies whenever the request omits the option.The change
The spec now publishes those four numbers. Types, bounds and required flags are untouched, so every request accepted before is still accepted; only the value a spec-driven client sends by default changes, and it changes to the one the engine would have used anyway.
Validation
Read against
types.h, not run against a package: no VoxCPM1 weights are installed on this machine.Scope
One spec file, four values. The generated WebUI bundle is deliberately not included —
catalog.tsinlinesmodel_specs/*.jsonat frontend build time and the bundle is not byte-reproducible, so regenerating it in every PR of this split would make the PRs conflict with each other. Happy to send one bundle-regeneration PR once the series lands.