chore: add actor-level retry for infra errors#2062
Open
SantiagoPittella wants to merge 2 commits intomainfrom
Open
chore: add actor-level retry for infra errors#2062SantiagoPittella wants to merge 2 commits intomainfrom
SantiagoPittella wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2052.
The NTX builder was permanently dropping notes after a run of unrelated infrastructure failures because every error type counted against the per-note
max_note_attemptscap.This PR classifies
NtxErrorinto infrastructure vs. intrinsic. Infra failures now retry the same candidate after a exponential backoff (usingbackon) without touching per-note state. Intrinsic failures keep the existing behaviour.This PR also introduces a dependency for backoff,
backon, and note that I didn't used theretryfeature (probably the most important part) because we use atokio::select!that needs to interleave several other things around each retry. Making use of retry will require further "plumbing" changes.