feat(network-monitor): replace .masm asset files with inline Rust constants#2058
Closed
Ollie202 wants to merge 2 commits into0xMiden:mainfrom
Closed
feat(network-monitor): replace .masm asset files with inline Rust constants#2058Ollie202 wants to merge 2 commits into0xMiden:mainfrom
Ollie202 wants to merge 2 commits into0xMiden:mainfrom
Conversation
Move counter_program.masm and increment_counter.masm out of the assets directory and into Rust source as const strings. Introduce CounterComponent following the IncrNonceAuthComponent pattern from miden-standards, with a LazyLock-compiled Library and a From impl. The note script is similarly inlined as INCREMENT_NOTE_SCRIPT in counter.rs. Closes 0xMiden#1831
Author
|
Closing to reopen under the assigned contributor account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1831
counter_program.masmasCOUNTER_PROGRAM_CODE: &strconstant indeploy/counter.rsCounterComponentstruct following theIncrNonceAuthComponentpattern frommiden-standards, with aLazyLock-compiledLibraryand aFromimplincrement_counter.masmasINCREMENT_NOTE_SCRIPT: &strconstant incounter.rs.masmasset filesThe MASM logic is unchanged — only the delivery mechanism changes from external files to Rust constants, making the code easier to maintain and reducing the risk of protocol changes slipping through unnoticed.
Test plan