Conversation
`npm audit fix` only — package.json is untouched, so every update resolved inside the ranges already declared. 20 advisories down to 4. Key bumps: astro 5.16.3 -> 5.18.2, vite 6.4.1 -> 6.4.3, postcss 8.5.6 -> 8.5.28, yaml 2.8.2 -> 2.9.1, js-yaml 4.1.1 -> 4.3.2, devalue 5.6.4 -> 5.9.2, fast-xml-parser 5.4.1 -> 5.11.1, nanoid 3.3.11 -> 3.3.19. The 4 remaining advisories all need astro@7 (a breaking major) and none are reachable here: - CRITICAL astro - XSS via `define:vars` and server-island encrypted params. `define:vars` appears nowhere in src/, and server islands need SSR; this project has no `output` or `adapter` set, so it builds as pure static. - HIGH sharp - libvips CVEs. Build-time only, over images we author. - LOW esbuild - dev server arbitrary file read. - LOW @astrojs/tailwind - inherited from astro. Going to astro 7 would also mean migrating off @astrojs/tailwind, which is deprecated there. Not worth it for advisories that have no path into a static build; revisit when the site needs astro 7 for its own sake. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SCGof6E8MrS772HhsYZT5a
The deploy workflow only fires on push to main, so nothing built a change before it merged — a broken build was only visible once it was already on main, and by then the site simply stops updating. This adds a build-only check on pull_request. No deploy step, and it does not overlap with main.yml (push vs pull_request). Two deliberate choices: - node-version is pinned to "20" because that is withastro/action@v2's default, which is what deploy actually runs on. Matching it is the point: a green check here means the deploy will build on the same Node. - npm ci rather than npm install, so a lockfile that drifted from package.json fails loudly instead of quietly resolving something else. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SCGof6E8MrS772HhsYZT5a
Contributor
Author
|
Verification done: the astro 5.18.2 bump builds clean on the real CI runtime (Ubuntu, Node 20.20.2) — 31 pages + sitemap. That was the only thing #69 had not been checked against, since it was verified locally on Node 24. Throwaway branch, closing and deleting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway branch: the #69 dependency bump plus the CI workflow from #70, purely to get a real Node 20 build of the bump before #69 lands. Not for merge — closing as soon as the check reports.