Repository navigation
feat: add TypeScript 7 editor features and LSP proxy - #442
Open
JoviDeCroock wants to merge 2 commits into
Open
JoviDeCroock wants to merge 2 commits into
JoviDeCroock wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: aa25882 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The relay compiled a C# launcher with csc.exe into a temp directory at runtime. Restore the explicit Windows error until TypeScript's sync client can connect to API pipes, and drop Windows from CI and the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript 7 does not load language service plugins. Building on the API sessions from #439, this adds GraphQL editor features through those sessions and an npm-packaged LSP proxy for clients that can launch a custom TypeScript server.
The native editor paths now provide diagnostics for unsaved documents, hover, resolved completions, schema definitions, cross-file fragment references and rename, quick fixes, and fragment extraction. VS Code connects to its existing native TypeScript server; other LSP clients can launch
graphqlsp --stdiowithout a VSIX. Both paths require TypeScript 7.1+ and keep configuration incompilerOptions.plugins. An npm install and tsconfig entry alone do not activate GraphQLSP in stock VS Code with TS 7.Validation
The runs below were on Windows, through a launcher-based relay that has since been removed (aa25882). They don't cover the supported macOS/Linux paths, which still need a run before merge.
Local validation on Windows with Node.js 22, VS Code 1.136.2, TypeScript Native Preview 1.0.1, and TypeScript 7.1.0-beta:
Limits
Native TS 7.1 can still hang in API-session cleanup. The proxy drains its worker, requests clean native shutdown, and uses a documented two-second fallback to terminate the native child and acknowledge shutdown before waiting for the client's
exit.macOS/Linux CI jobs are configured but have not been run locally. The newer middleware adapter has unit coverage; the actual editor run used the released extension's older API. Standalone
.graphqllanguage features and navigation from generated gql.tada turbo-cache result types back into queries remain outside this integration.