Repository navigation
fix(docs): resolve Nitro build failure for site config import - #5
Merged
Merged
Conversation
Nitro prerender failed to resolve docs/shared/site.ts because Vite externalized it outside the app source root. Inline constants in app/utils/site.ts so OG meta composables bundle correctly. Co-authored-by: froQ <sayhola@froq.me>
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After PR #4 (og-layer adoption), Cloudflare Workers Build fails during
pnpm generate:Production still serves the old static
og.pngbecause deploy never completes.Root cause
docs/shared/site.tslived outside Nuxt'sapp/source root. Composables re-exported it viaapp/utils/site.ts, but Vite/Nitro left a broken external import (../../../../../../../docs/shared/site.ts) in the server bundle during prerender.Fix
docs/app/utils/site.ts(single source of truth).nuxt.config.tsat./app/utils/site.docs/shared/site.ts.Verification
Locally with Workers Build parity (
NODE_VERSION=22,pnpm install --frozen-lockfile && pnpm generate):/_og/s/*.png.dist/index.html:og:image→https://ui.sayhola.workers.dev/_og/...png,og:url→https://ui.froq.me.pnpm check(lint, typecheck, check:tokens) passes.