Add PreFlightGoNoGo unit tests for Kp, sun, scoring, stations.

Author: ztel42

PreFlightGoNoGo/tests/test_kp.py

@@ -0,0 +1,32 @@
+from __future__ import annotations
+
+import json
+from pathlib import Path
+
+from preflight_go_no_go.kp import parse_kp_json
+
+
+def test_kp_quiet_latest(fixtures_dir: Path):
+    data = json.loads((fixtures_dir / "kp_quiet.json").read_text())
+    kp = parse_kp_json(data)
+    assert kp is not None
+    assert kp.kp_index == 1
+    assert kp.estimated_kp == 1.33
+
+
+def test_kp_storm(fixtures_dir: Path):
+    data = json.loads((fixtures_dir / "kp_storm.json").read_text())
+    kp = parse_kp_json(data)
+    assert kp is not None
+    assert kp.kp_index == 7
+
+
+def test_kp_header_rows_style():
+    payload = [
+        ["time_tag", "Kp", "a_running_average"],
+        ["2026-10-07 12:00:00", "3", "12"],
+        ["2026-10-07 15:00:00", "5", "22"],
+    ]
+    kp = parse_kp_json(payload)
+    assert kp is not None
+    assert kp.kp_index == 5

PreFlightGoNoGo/tests/test_scoring.py

@@ -0,0 +1,94 @@
+from __future__ import annotations
+
+import json
+from datetime import datetime
+from pathlib import Path
+from zoneinfo import ZoneInfo
+
+from preflight_go_no_go.kp import parse_kp_json
+from preflight_go_no_go.metar import parse_metar_list
+from preflight_go_no_go.models import Thresholds, Verdict
+from preflight_go_no_go.scoring import evaluate
+from preflight_go_no_go.sun import compute_sun_times
+
+
+def _day_now():
+    return datetime(2026, 10, 7, 13, 0, tzinfo=ZoneInfo("America/New_York"))
+
+
+def test_vfr_quiet_is_fly(fixtures_dir: Path):
+    metars = parse_metar_list(json.loads((fixtures_dir / "metar_vfr.json").read_text()))
+    kp = parse_kp_json(json.loads((fixtures_dir / "kp_quiet.json").read_text()))
+    primary = next(m for m in metars if m.icao == "KXMR")
+    sun = compute_sun_times(28.39, -80.60, when=_day_now())
+    report = evaluate(
+        primary, [m for m in metars if m.icao != "KXMR"], kp, sun, Thresholds(),
+        location_label="KXMR", lat=28.39, lon=-80.60, generated_at=_day_now(),
+    )
+    assert report.verdict == Verdict.FLY
+
+
+def test_mvfr_rain_is_marginal(fixtures_dir: Path):
+    metars = parse_metar_list(json.loads((fixtures_dir / "metar_mvfr.json").read_text()))
+    kp = parse_kp_json(json.loads((fixtures_dir / "kp_quiet.json").read_text()))
+    primary = next(m for m in metars if m.icao == "KXMR")
+    sun = compute_sun_times(28.39, -80.60, when=_day_now())
+    report = evaluate(
+        primary, [], kp, sun, Thresholds(),
+        location_label="KXMR", lat=28.39, lon=-80.60, generated_at=_day_now(),
+    )
+    assert report.verdict == Verdict.MARGINAL
+    weather = next(f for f in report.factors if f.name == "weather")
+    assert weather.verdict == Verdict.MARGINAL
+
+
+def test_thunderstorm_is_dont_fly(fixtures_dir: Path):
+    metars = parse_metar_list(json.loads((fixtures_dir / "metar_thunderstorm.json").read_text()))
+    kp = parse_kp_json(json.loads((fixtures_dir / "kp_quiet.json").read_text()))
+    sun = compute_sun_times(28.39, -80.60, when=_day_now())
+    report = evaluate(
+        metars[0], [], kp, sun, Thresholds(),
+        location_label="KXMR", lat=28.39, lon=-80.60, generated_at=_day_now(),
+    )
+    assert report.verdict == Verdict.DONT_FLY
+
+
+def test_kp_storm_dont_fly_even_in_vfr(fixtures_dir: Path):
+    metars = parse_metar_list(json.loads((fixtures_dir / "metar_vfr.json").read_text()))
+    kp = parse_kp_json(json.loads((fixtures_dir / "kp_storm.json").read_text()))
+    primary = next(m for m in metars if m.icao == "KXMR")
+    sun = compute_sun_times(28.39, -80.60, when=_day_now())
+    report = evaluate(
+        primary, [], kp, sun, Thresholds(),
+        location_label="KXMR", lat=28.39, lon=-80.60, generated_at=_day_now(),
+    )
+    assert report.verdict == Verdict.DONT_FLY
+    kp_f = next(f for f in report.factors if f.name == "kp")
+    assert kp_f.verdict == Verdict.DONT_FLY
+
+
+def test_kp_marginal(fixtures_dir: Path):
+    metars = parse_metar_list(json.loads((fixtures_dir / "metar_vfr.json").read_text()))
+    kp = parse_kp_json(json.loads((fixtures_dir / "kp_marginal.json").read_text()))
+    primary = next(m for m in metars if m.icao == "KXMR")
+    sun = compute_sun_times(28.39, -80.60, when=_day_now())
+    report = evaluate(
+        primary, [], kp, sun, Thresholds(),
+        location_label="KXMR", lat=28.39, lon=-80.60, generated_at=_day_now(),
+    )
+    assert report.verdict == Verdict.MARGINAL
+
+
+def test_night_is_marginal_by_default(fixtures_dir: Path):
+    metars = parse_metar_list(json.loads((fixtures_dir / "metar_vfr.json").read_text()))
+    kp = parse_kp_json(json.loads((fixtures_dir / "kp_quiet.json").read_text()))
+    primary = next(m for m in metars if m.icao == "KXMR")
+    night = datetime(2026, 10, 7, 23, 0, tzinfo=ZoneInfo("America/New_York"))
+    sun = compute_sun_times(28.39, -80.60, when=night)
+    report = evaluate(
+        primary, [], kp, sun, Thresholds(),
+        location_label="KXMR", lat=28.39, lon=-80.60, generated_at=night,
+    )
+    assert report.verdict == Verdict.MARGINAL
+    day_f = next(f for f in report.factors if f.name == "daylight")
+    assert day_f.verdict == Verdict.MARGINAL

PreFlightGoNoGo/tests/test_stations.py

@@ -0,0 +1,26 @@
+from __future__ import annotations
+
+from preflight_go_no_go.stations import icao_list_from_latlon, nearest_stations, pick_primary
+from preflight_go_no_go.metar import parse_metar_json
+
+
+def test_nearest_space_coast():
+    near = nearest_stations(28.39, -80.60, n=3)
+    codes = [s.icao for s in near]
+    assert "KXMR" in codes
+    assert near[0].distance_nm is not None
+    assert near[0].distance_nm < near[-1].distance_nm
+
+
+def test_icao_list():
+    codes = icao_list_from_latlon(28.39, -80.60, n=3)
+    assert len(codes) == 3
+    assert codes[0] == "KXMR"
+
+
+def test_pick_primary_preferred():
+    a = parse_metar_json({"icaoId": "KCOF", "lat": 28.24, "lon": -80.61, "wspd": 5})
+    b = parse_metar_json({"icaoId": "KXMR", "lat": 28.47, "lon": -80.56, "wspd": 5})
+    primary, nearby = pick_primary([a, b], preferred_icao="KXMR")
+    assert primary is not None and primary.icao == "KXMR"
+    assert len(nearby) == 1

PreFlightGoNoGo/tests/test_sun.py

@@ -0,0 +1,27 @@
+from __future__ import annotations
+
+from datetime import datetime
+from zoneinfo import ZoneInfo
+
+from preflight_go_no_go.sun import compute_sun_times
+
+
+def test_space_coast_daylight_october():
+    tz = ZoneInfo("America/New_York")
+    # Midday EDT on 2026-10-07 near Cape Canaveral
+    when = datetime(2026, 10, 7, 13, 0, tzinfo=tz)
+    sun = compute_sun_times(28.39, -80.60, when=when, tz_name="America/New_York")
+    assert sun.is_daylight
+    assert sun.phase in {"day", "golden_morning", "golden_evening"}
+    assert sun.sunrise.hour < 8  # ~7:xx EDT in early October FL
+    assert sun.sunset.hour >= 18
+    assert sun.civil_dawn < sun.sunrise < sun.golden_morning_end
+    assert sun.golden_evening_start < sun.sunset < sun.civil_dusk
+
+
+def test_night_phase():
+    tz = ZoneInfo("America/New_York")
+    when = datetime(2026, 10, 7, 23, 30, tzinfo=tz)
+    sun = compute_sun_times(28.39, -80.60, when=when)
+    assert not sun.is_daylight
+    assert sun.phase == "night"