Fix astro check lint errors in CallToAction/Newsletter component

Author: webstackdev

src/components/CallToAction/Newsletter/client/index.ts

@@ -105,7 +105,7 @@ export class NewsletterFormElement extends LitElement {
       // Save original button text
       this.originalButtonText = this.buttonText.textContent || 'Subscribe'
       this.submitButton.setAttribute('data-original-text', this.originalButtonText)
-      this.submitButton.dataset.e2eState = 'idle'
+      this.submitButton.dataset['e2eState'] = 'idle'
     } catch (error) {
       if (error instanceof ClientScriptError) {
         throw error
@@ -171,7 +171,7 @@ export class NewsletterFormElement extends LitElement {
     if (!this.submitButton || !this.buttonText || !this.buttonArrow || !this.buttonSpinner) return
 
     this.submitButton.disabled = loading
-    this.submitButton.dataset.e2eState = loading ? 'loading' : 'idle'
+    this.submitButton.dataset['e2eState'] = loading ? 'loading' : 'idle'
 
       if (loading) {
         this.buttonText.textContent = 'Subscribing...'

test/e2e/specs/03-forms/newsletter-subscription.spec.ts

@@ -226,13 +226,14 @@ test.describe('Newsletter Subscription Form', () => {
     const delayOverride = await delayFetchForEndpoint(newsletterPage.page, { endpoint: '/api/newsletter', delayMs })
     const submitButton = newsletterPage.locator('#newsletter-submit')
     const stateTimeout = { timeout: 2000 }
-
+    const apiResponsePromise = newsletterPage.page.waitForResponse('/api/newsletter')
     const submitPromise = submitButton.click()
 
     try {
       await expect(submitButton).toHaveAttribute('data-e2e-state', 'loading', stateTimeout)
       await expect(submitButton).toBeDisabled({ timeout: 2000 })
       await submitPromise
+      await apiResponsePromise
       await expect(submitButton).toHaveAttribute('data-e2e-state', 'idle', stateTimeout)
       await expect(submitButton).toBeEnabled({ timeout: 2000 })
     } finally {