Skip to content

Commit eb0830b

Browse files
webstackdevwebstackdev
committed
Add missed accessibility and focusable props and handling to Marker icons
1 parent c9e6071 commit eb0830b

29 files changed

Lines changed: 75 additions & 51 deletions

src/components/Marker/markers/avatar.astro renamed to src/components/Marker/icons/avatar.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const { color, classes, size, accessible, focusable, isListMarker } = Astro.prop
2020
aria-hidden={accessible ? "false" : "true"}
2121
focusable={focusable ? "true" : "false"}
2222
>
23-
<title>User Avatar Icon</title>
23+
{accessible && <title>User Avatar Icon</title>}
2424
<path
2525
stroke-linecap="round"
2626
stroke-linejoin="round"

src/components/Marker/markers/chart.astro renamed to src/components/Marker/icons/chart.astro

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@ export type Props = {
66
accessible: boolean
77
focusable: boolean
88
isListMarker?: boolean
9+
title?: string
910
}
1011
11-
const { color, classes, size, accessible, focusable, isListMarker } = Astro.props
12+
const { color, classes, size, accessible, focusable, isListMarker, title } = Astro.props
1213
---
1314

1415
<svg
@@ -20,7 +21,7 @@ const { color, classes, size, accessible, focusable, isListMarker } = Astro.prop
2021
aria-hidden={accessible ? "false" : "true"}
2122
focusable={focusable ? "true" : "false"}
2223
>
23-
<title>Bar Chart Icon</title>
24+
{title && <title>{title}</title>}
2425
<path
2526
stroke-linecap="round"
2627
stroke-linejoin="round"

src/components/Marker/markers/check.astro renamed to src/components/Marker/icons/check.astro

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@ export type Props = {
66
accessible: boolean
77
focusable: boolean
88
isListMarker?: boolean
9+
title?: string
910
}
1011
11-
const { color, classes, size, accessible, focusable, isListMarker } = Astro.props
12+
const { color, classes, size, accessible, focusable, isListMarker, title } = Astro.props
1213
---
1314

1415
<svg
@@ -20,7 +21,7 @@ const { color, classes, size, accessible, focusable, isListMarker } = Astro.prop
2021
aria-hidden={accessible ? "false" : "true"}
2122
focusable={focusable ? "true" : "false"}
2223
>
23-
<title>Checkmark Icon</title>
24+
{title && <title>{title}</title>}
2425
<path
2526
stroke-linecap="round"
2627
stroke-linejoin="round"

src/components/Marker/markers/chevron.astro renamed to src/components/Marker/icons/chevron.astro

File renamed without changes.

src/components/Marker/markers/clipboard.astro renamed to src/components/Marker/icons/clipboard.astro

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@ export type Props = {
66
accessible: boolean
77
focusable: boolean
88
isListMarker?: boolean
9+
title?: string
910
}
1011
11-
const { color, classes, size, accessible, focusable, isListMarker } = Astro.props
12+
const { color, classes, size, accessible, focusable, isListMarker, title } = Astro.props
1213
---
1314

1415
<svg
@@ -20,7 +21,7 @@ const { color, classes, size, accessible, focusable, isListMarker } = Astro.prop
2021
aria-hidden={accessible ? "false" : "true"}
2122
focusable={focusable ? "true" : "false"}
2223
>
23-
<title>Clipboard Icon</title>
24+
{title && <title>{title}</title>}
2425
<path
2526
stroke-linecap="round"
2627
stroke-linejoin="round"

src/components/Marker/markers/company.astro renamed to src/components/Marker/icons/company.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const { color, classes, size, accessible, focusable, isListMarker } = Astro.prop
2020
aria-hidden={accessible ? "false" : "true"}
2121
focusable={focusable ? "true" : "false"}
2222
>
23-
<title>Company Building Icon</title>
23+
{accessible && <title>Company Building Icon</title>}
2424
<path
2525
stroke-linecap="round"
2626
stroke-linejoin="round"

src/components/Marker/markers/conversation.astro renamed to src/components/Marker/icons/conversation.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const { color, classes, size, accessible, focusable, isListMarker } = Astro.prop
2020
aria-hidden={accessible ? "false" : "true"}
2121
focusable={focusable ? "true" : "false"}
2222
>
23-
<title>Conversation Bubbles Icon</title>
23+
{accessible && <title>Conversation Bubbles Icon</title>}
2424
<path
2525
stroke-linecap="round"
2626
stroke-linejoin="round"

src/components/Marker/markers/document.astro renamed to src/components/Marker/icons/document.astro

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@ export type Props = {
66
accessible: boolean
77
focusable: boolean
88
isListMarker?: boolean
9+
title?: string
910
}
1011
11-
const { color, classes, size, accessible, focusable, isListMarker } = Astro.props
12+
const { color, classes, size, accessible, focusable, isListMarker, title } = Astro.props
1213
---
1314

1415
<svg
@@ -20,7 +21,7 @@ const { color, classes, size, accessible, focusable, isListMarker } = Astro.prop
2021
aria-hidden={accessible ? "false" : "true"}
2122
focusable={focusable ? "true" : "false"}
2223
>
23-
<title>Document Icon</title>
24+
{title && <title>{title}</title>}
2425
<path
2526
stroke-linecap="round"
2627
stroke-linejoin="round"

src/components/Marker/markers/download-document.astro renamed to src/components/Marker/icons/download-document.astro

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,10 @@ export type Props = {
55
size: number
66
accessible: boolean
77
focusable: boolean
8+
title?: string
89
}
910
10-
const { color, classes, size, accessible, focusable } = Astro.props
11+
const { color, classes, size, accessible, focusable, title } = Astro.props
1112
---
1213

1314
<svg
@@ -19,7 +20,7 @@ const { color, classes, size, accessible, focusable } = Astro.props
1920
aria-hidden={accessible ? "false" : "true"}
2021
focusable={focusable ? "true" : "false"}
2122
>
22-
<title>Download Document Icon</title>
23+
{title && <title>{title}</title>}
2324
<path
2425
stroke-linecap="round"
2526
stroke-linejoin="round"

src/components/Marker/markers/download.astro renamed to src/components/Marker/icons/download.astro

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,10 @@ export type Props = {
55
size: number
66
accessible: boolean
77
focusable: boolean
8+
title?: string
89
}
910
10-
const { color, classes, size, accessible, focusable } = Astro.props
11+
const { color, classes, size, accessible, focusable, title } = Astro.props
1112
---
1213

1314
<svg
@@ -19,7 +20,7 @@ const { color, classes, size, accessible, focusable } = Astro.props
1920
aria-hidden={accessible ? "false" : "true"}
2021
focusable={focusable ? "true" : "false"}
2122
>
22-
<title>Download Arrow Icon</title>
23+
{title && <title>{title}</title>}
2324
<path
2425
stroke-linecap="round"
2526
stroke-linejoin="round"

0 commit comments

Comments
 (0)