Skip to content

Commit e1ac7e6

Browse files
committed
Move Service list view page cards to H2 from H3
1 parent 96b9b58 commit e1ac7e6

2 files changed

Lines changed: 12 additions & 22 deletions

File tree

axe-results-violations.json

Lines changed: 11 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,43 +1,33 @@
11
[
22
{
3-
"id": "landmark-unique",
3+
"id": "heading-order",
44
"impact": "moderate",
55
"tags": [
66
"cat.semantics",
77
"best-practice"
88
],
9-
"description": "Ensure landmarks are unique",
10-
"help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination",
11-
"helpUrl": "https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright",
9+
"description": "Ensure the order of headings is semantically correct",
10+
"help": "Heading levels should only increase by one",
11+
"helpUrl": "https://dequeuniversity.com/rules/axe/4.11/heading-order?application=playwright",
1212
"nodes": [
1313
{
1414
"any": [
1515
{
16-
"id": "landmark-is-unique",
17-
"data": {
18-
"role": "search",
19-
"accessibleText": "site search"
20-
},
21-
"relatedNodes": [
22-
{
23-
"html": "<form data-search-form=\"\" class=\"relative\" role=\"search\" aria-label=\"Site search\" data-astro-cid-yeu7u2zk=\"\" data-search-listener=\"true\">",
24-
"target": [
25-
".max-w-lg > form[data-search-form=\"\"][role=\"search\"][aria-label=\"Site search\"]"
26-
]
27-
}
28-
],
16+
"id": "heading-order",
17+
"data": null,
18+
"relatedNodes": [],
2919
"impact": "moderate",
30-
"message": "The landmark must have a unique aria-label, aria-labelledby, or title to make landmarks distinguishable"
20+
"message": "Heading order invalid"
3121
}
3222
],
3323
"all": [],
3424
"none": [],
3525
"impact": "moderate",
36-
"html": "<form data-search-form=\"\" data-state=\"closed\" class=\"flex items-center w-full h-(--header-icon-size) overflow-visible rounded-full data-[state=open]:bg-page-base data-[state=open]:shadow-elevated\" role=\"search\" aria-label=\"Site search\" data-search-listener=\"true\">",
26+
"html": "<h3 class=\"text-xl font-bold\">Full Workstream</h3>",
3727
"target": [
38-
".overflow-visible"
28+
".service-card-header--default > h3"
3929
],
40-
"failureSummary": "Fix any of the following:\n The landmark must have a unique aria-label, aria-labelledby, or title to make landmarks distinguishable"
30+
"failureSummary": "Fix any of the following:\n Heading order invalid"
4131
}
4232
]
4333
}

src/components/Pages/Services/index.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ const splitH2Sections = (html: string): string[] => {
120120
Most Popular
121121
</span>
122122
)}
123-
<h3 class="text-xl font-bold">{service.data.title}</h3>
123+
<h2 class="text-xl font-bold">{service.data.title}</h2>
124124
<p
125125
class:list={[
126126
'service-card-description sm:mt-2 text-sm leading-relaxed text-content-offset',

0 commit comments

Comments
 (0)