Skip to content

Commit dbbd9c5

Browse files
committed
Fix icon sizing and focus-visible handling in footer
1 parent 9438356 commit dbbd9c5

4 files changed

Lines changed: 111 additions & 232 deletions

File tree

_TODO.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -255,3 +255,5 @@ This article has different approaches to [print pagination](https://www.customjs
255255
- We need to check for short form and deep article articles where the deep-dive index.pdf has a non-featured tag lik "argo-cd" only in the pdf.mdx. In those cases, we should make sure the callout for the deep dive includes the name of that non-featured (technology) tag and add the name to the tags: frontmatter key in the index.mdx
256256

257257
- Need an article on OpenStack
258+
259+
- Add links to the privacy policy page to go to preferences and my-data

src/components/Footer/footer.module.css

Lines changed: 0 additions & 155 deletions
Original file line numberDiff line numberDiff line change
@@ -4,113 +4,22 @@
44
}
55
}
66

7-
.footerSocialList {
8-
display: grid;
9-
gap: 0.75rem 1rem;
10-
}
11-
12-
@media (width >= 64em) {
13-
.footerSocialList {
14-
grid-template-columns: repeat(2, minmax(0, 1fr));
15-
}
16-
}
17-
18-
.footerSocialIcon :global([data-icon]) {
19-
height: 2rem;
20-
width: 2rem;
21-
}
22-
23-
.footerSocialLink :global([data-icon]) {
24-
fill: var(--color-content);
25-
stroke: var(--color-content);
26-
}
27-
28-
.footerSocialLink {
29-
text-decoration: none;
30-
}
31-
32-
.footerSocialPlatform {
33-
text-decoration-color: var(--color-primary);
34-
text-decoration-line: underline;
35-
text-decoration-style: dotted;
36-
text-underline-offset: 4px;
37-
}
38-
39-
.footerSocialLink:hover .footerSocialPlatform,
40-
.footerSocialLink:focus-visible .footerSocialPlatform {
41-
text-decoration-color: var(--color-secondary);
42-
}
43-
44-
.footerSocialLink:hover :global([data-icon]),
45-
.footerSocialLink:focus-visible :global([data-icon]) {
46-
fill: var(--color-secondary);
47-
stroke: var(--color-secondary);
48-
}
49-
50-
.footerSocialBlurbText {
51-
color: var(--color-content);
52-
text-decoration: none;
53-
}
54-
55-
.footerSocialLink:hover .footerSocialBlurbText,
56-
.footerSocialLink:focus-visible .footerSocialBlurbText {
57-
color: var(--color-content);
58-
}
59-
60-
.footerSocialLink :global([data-icon='x'] path) {
61-
stroke: none;
62-
}
63-
64-
.footerSocialLink :global([data-icon='x'] .xTile) {
65-
fill: var(--color-content);
66-
}
67-
68-
.footerSocialLink :global([data-icon='x'] .xGlyph) {
69-
fill: var(--color-content-inverse);
70-
}
71-
72-
.footerSocialLink:hover :global([data-icon='x'] .xTile),
73-
.footerSocialLink:focus-visible :global([data-icon='x'] .xTile) {
74-
fill: var(--color-secondary);
75-
}
76-
77-
.footerSocialBlurb {
78-
margin-top: 0.25rem;
79-
}
80-
81-
.footerBottomGrid {
82-
display: grid;
83-
gap: 0.75rem 1rem;
84-
grid-template-columns: 1fr 1fr;
85-
}
86-
877
.footerBottomPrimary {
888
grid-column: 1;
899
grid-row: 1;
9010
}
9111

9212
.footerBottomSecondary {
93-
display: flex;
94-
flex-direction: column;
95-
gap: 0.75rem;
9613
grid-column: 2;
9714
grid-row: 1;
9815
}
9916

10017
.footerBottomActions {
101-
align-items: center;
102-
display: flex;
103-
gap: 1rem;
10418
grid-column: 1 / -1;
10519
grid-row: 2;
106-
justify-content: center;
10720
}
10821

10922
@media (width >= 64em) {
110-
.footerBottomGrid {
111-
grid-template-columns: 1fr;
112-
}
113-
11423
.footerBottomPrimary,
11524
.footerBottomSecondary,
11625
.footerBottomActions {
@@ -123,68 +32,11 @@
12332

12433
.footerBottomActions {
12534
grid-row: 4;
126-
justify-content: center;
12735
}
12836
}
12937

130-
.footerBottomLink {
131-
text-decoration: none;
132-
}
133-
134-
.footerBottomLinkTitle {
135-
text-decoration: underline;
136-
text-decoration-style: dotted;
137-
}
138-
139-
.footerBottomLink:hover .footerBottomLinkTitle,
140-
.footerBottomLink:focus .footerBottomLinkTitle {
141-
text-decoration-color: var(--color-secondary);
142-
}
143-
144-
.footerBottomLinkDescription {
145-
text-decoration: none;
146-
}
147-
148-
.footerBottomLinkDescriptionText {
149-
color: var(--color-content);
150-
}
151-
152-
.footerBottomLink:hover .footerBottomLinkDescriptionText,
153-
.footerBottomLink:focus-visible .footerBottomLinkDescriptionText {
154-
color: var(--color-content);
155-
}
156-
157-
.footerIconButton :global([data-icon]) {
158-
color: var(--color-content);
159-
fill: currentcolor;
160-
height: 2rem;
161-
stroke: currentcolor;
162-
width: 2rem;
163-
}
164-
165-
.footerIconButton {
166-
cursor: pointer;
167-
display: inline-flex;
168-
justify-content: center;
169-
line-height: 1;
170-
padding: 0.25rem;
171-
}
172-
173-
.footerIconButton:hover :global([data-icon]),
174-
.footerIconButton:focus-visible :global([data-icon]) {
175-
color: var(--color-secondary);
176-
}
177-
178-
.footerGrid :global(a:focus-visible),
179-
.footerGrid :global(button:focus-visible) {
180-
outline: 2px solid var(--color-spotlight);
181-
outline-offset: 2px;
182-
}
183-
18438
@media (width >= 40em) {
18539
.footerGrid {
186-
display: grid;
187-
gap: 0.5rem 1rem;
18840
grid-template-areas:
18941
"contact social"
19042
"contact channels"
@@ -220,14 +72,7 @@
22072
}
22173

22274
.footerHireMe {
223-
align-self: end;
22475
grid-area: hire-me;
225-
margin-top: 2rem;
226-
}
227-
228-
.footerHireMeAnchor {
229-
margin-top: 0.5rem;
230-
text-decoration: none;
23176
}
23277
}
23378

src/components/Footer/footer.module.css.d.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,28 +2,13 @@ declare const styles: {
22
readonly footerGrid: string
33
readonly footerContact: string
44
readonly footerSocial: string
5-
readonly footerSocialList: string
6-
readonly footerSocialItem: string
7-
readonly footerSocialLink: string
8-
readonly footerSocialHeaderRow: string
9-
readonly footerSocialIcon: string
10-
readonly footerSocialPlatform: string
11-
readonly footerSocialBlurb: string
12-
readonly footerSocialBlurbText: string
135
readonly footerBottomRow: string
14-
readonly footerBottomGrid: string
156
readonly footerBottomPrimary: string
167
readonly footerBottomSecondary: string
178
readonly footerBottomActions: string
18-
readonly footerBottomLink: string
19-
readonly footerBottomLinkTitle: string
20-
readonly footerBottomLinkDescription: string
21-
readonly footerBottomLinkDescriptionText: string
229
readonly footerCopyright: string
2310
readonly footerHireMe: string
2411
readonly footerHireMeAnchor: string
25-
readonly footerFeedIcon: string
26-
readonly footerIconButton: string
2712
}
2813

2914
export default styles

0 commit comments

Comments
 (0)