Fix lint errors

Author: webstackdev

Contact_Form_ Kevin.eml

@@ -27,14 +27,6 @@ https://aws.plainenglish.io/how-to-build-a-chatbot-using-aws-lex-and-lambda-in-2
 
 - Finish styling
 
-## Env Vars
-
-- Add HubSpot env vars to Vercel
-
-## Content Issues
-
-- Need an article on OpenStack
-
 ## Contact Form
 
 - `0/2000` characters should show number of characters left instead

_TODO.md

@@ -36,6 +36,12 @@ const allowedAttachmentTypes = [
   'text/plain',
 ] as const
 
+type AllowedAttachmentType = (typeof allowedAttachmentTypes)[number]
+
+const isAllowedAttachmentType = (mimeType: string): mimeType is AllowedAttachmentType => {
+  return allowedAttachmentTypes.some(allowedAttachmentType => allowedAttachmentType === mimeType)
+}
+
 const normalizeMimeType = (mimeType: string): string => {
   return mimeType.split(';')[0]?.trim().toLowerCase() || ''
 }
@@ -151,7 +157,7 @@ export async function parseAttachments(form: FormData): Promise<FileAttachment[]
 
       const normalizedType = normalizeMimeType(value.type)
 
-      if (!allowedAttachmentTypes.includes(normalizedType)) {
+      if (!isAllowedAttachmentType(normalizedType)) {
         throw new ActionsFunctionError(`File type ${value.type} not allowed`, { status: 400 })
       }
 
@@ -191,7 +197,7 @@ export async function parseAttachmentsFromInput(
 
     const normalizedType = normalizeMimeType(value.type)
 
-    if (!allowedAttachmentTypes.includes(normalizedType)) {
+    if (!isAllowedAttachmentType(normalizedType)) {
       throw new ActionsFunctionError(`File type ${value.type} not allowed`, { status: 400 })
     }
 

src/actions/contact/responder.ts

@@ -3,6 +3,7 @@
  * Contact Page
  *
  * Use query parameters to view prefilled form states for testing:
+ *
  * - /contact/?projectType=web-development (prefills project type dropdown)
  * - /contact/?formState=success (shows success message)
  * - /contact/?formState=error (shows error message)

src/components/Pages/Contact/index.astro

@@ -7,15 +7,16 @@ const path = '/testing/comps/scratchpad'
 ---
 
 <BaseLayout pageDescription={pageDescription} noindex={true} pageTitle={pageTitle} path={path}>
+  {/** The svg elements on the site are rendering the <path> "fill-rule" attribute as "fillRule" */}
   <div class="uppy-Audio-buttonContainer">
       <button class="uppy-u-reset uppy-c-btn uppy-Audio-button uppy-Audio-button--submit" type="button" title="Submit recorded file" aria-label="Submit recorded file" data-uppy-super-focusable="true">
           <svg width="12" height="9" viewBox="0 0 12 9" xmlns="http://www.w3.org/2000/svg" aria-hidden="true" focusable="false" class="uppy-c-icon">
-              <path fill="#fff" fillRule="nonzero" d="M10.66 0L12 1.31 4.136 9 0 4.956l1.34-1.31L4.136 6.38z"></path>
+              <path fill="#fff" fill-rule="nonzero" d="M10.66 0L12 1.31 4.136 9 0 4.956l1.34-1.31L4.136 6.38z"></path>
           </svg>
       </button>
       <button class="uppy-u-reset uppy-c-btn uppy-Audio-button" type="button" title="Discard recorded file" aria-label="Discard recorded file" data-uppy-super-focusable="true">
           <svg width="13" height="13" viewBox="0 0 13 13" xmlns="http://www.w3.org/2000/svg" aria-hidden="true" class="uppy-c-icon">
-              <g fill="#FFF" fillRule="evenodd">
+              <g fill="#FFF" fill-rule="evenodd">
                   <path d="M.496 11.367L11.103.76l1.414 1.414L1.911 12.781z"></path>
                   <path d="M11.104 12.782L.497 2.175 1.911.76l10.607 10.606z"></path>
               </g>
@@ -25,12 +26,12 @@ const path = '/testing/comps/scratchpad'
   <div class="uppy-Audio-buttonContainer">
       <button class="uppy-u-reset uppy-c-btn uppy-Audio-button uppy-Audio-button--submit" type="button" title="Submit recorded file" aria-label="Submit recorded file" data-uppy-super-focusable="true">
           <svg width="12" height="9" viewBox="0 0 12 9" xmlns="http://www.w3.org/2000/svg" aria-hidden="true" focusable="false" class="uppy-c-icon">
-              <path fill="#fff" fillRule="nonzero" d="M10.66 0L12 1.31 4.136 9 0 4.956l1.34-1.31L4.136 6.38z"></path>
+              <path fill="#fff" fill-rule="nonzero" d="M10.66 0L12 1.31 4.136 9 0 4.956l1.34-1.31L4.136 6.38z"></path>
           </svg>
       </button>
       <button class="uppy-u-reset uppy-c-btn uppy-Audio-button" type="button" title="Discard recorded file" aria-label="Discard recorded file" data-uppy-super-focusable="true">
           <svg width="13" height="13" viewBox="0 0 13 13" xmlns="http://www.w3.org/2000/svg" aria-hidden="true" class="uppy-c-icon">
-              <g fill="#FFF" fillRule="evenodd">
+              <g fill="#FFF" fill-rule="evenodd">
                   <path d="M.496 11.367L11.103.76l1.414 1.414L1.911 12.781z"></path>
                   <path d="M11.104 12.782L.497 2.175 1.911.76l10.607 10.606z"></path>
               </g>