Update src/pages/api/newsletter contact and _email unit tests to reflect changes made while implementing E2E tests

Author: webstackdev

src/pages/api/newsletter/__tests__/_confirm.spec.ts

@@ -119,8 +119,12 @@ describe('Newsletter Confirmation API - GET /api/newsletter/confirm', () => {
 		expect(supabaseFromMock).toHaveBeenCalledWith('consent_records')
 		expect(supabaseQueryBuilder.update).toHaveBeenCalledWith({ verified: true })
 
-		// Verify welcome email was sent
-		expect(mockSendWelcomeEmail).toHaveBeenCalledWith('test@example.com', 'John')
+		// Verify welcome email was sent (force mock disabled by default)
+		expect(mockSendWelcomeEmail).toHaveBeenCalledWith(
+			'test@example.com',
+			'John',
+			expect.objectContaining({ forceMockResend: false }),
+		)
 
 		expect(mockSubscribeToConvertKit).toHaveBeenCalledWith(
 			expect.objectContaining({ email: 'test@example.com' }),
@@ -142,9 +146,10 @@ describe('Newsletter Confirmation API - GET /api/newsletter/confirm', () => {
 		const response = await GET(createRequestContext('http://localhost/api/newsletter/confirm?token=expired-token'))
 		const body = await response.json()
 
-		expect(response.status).toBe(400)
-		expect(body.error).toBeDefined()
-		expect(body.error.message).toContain('expired')
+		expect(response.status).toBe(200)
+		expect(body.success).toBe(false)
+		expect(body.status).toBe('expired')
+		expect(body.message).toContain('expired')
 	})
 
 	it('should handle subscription without firstName', async () => {
@@ -166,7 +171,11 @@ describe('Newsletter Confirmation API - GET /api/newsletter/confirm', () => {
 
 		expect(response.status).toBe(200)
 		expect(data.success).toBe(true)
-		expect(mockSendWelcomeEmail).toHaveBeenCalledWith('test@example.com', undefined)
+		expect(mockSendWelcomeEmail).toHaveBeenCalledWith(
+			'test@example.com',
+			undefined,
+			expect.objectContaining({ forceMockResend: false }),
+		)
 	})
 
 	it('should handle subscription without ipAddress', async () => {

src/pages/api/newsletter/__tests__/_index.spec.ts

@@ -104,7 +104,12 @@ describe('Newsletter API - POST /api/newsletter', () => {
 				firstName: 'John',
 			}),
 		)
-		expect(mockSendConfirmationEmail).toHaveBeenCalledWith('test@example.com', 'test-token-123', 'John')
+		expect(mockSendConfirmationEmail).toHaveBeenCalledWith(
+			'test@example.com',
+			'test-token-123',
+			'John',
+			expect.objectContaining({ forceMockResend: false }),
+		)
 	})
 
 	it('should reject subscription without email', async () => {
@@ -219,7 +224,12 @@ describe('Newsletter API - POST /api/newsletter', () => {
 
 		expect(response.status).toBe(200)
 		expect(data.success).toBe(true)
-		expect(mockSendConfirmationEmail).toHaveBeenCalledWith('test@example.com', 'test-token-123', undefined)
+		expect(mockSendConfirmationEmail).toHaveBeenCalledWith(
+			'test@example.com',
+			'test-token-123',
+			undefined,
+			expect.objectContaining({ forceMockResend: false }),
+		)
 	})
 
 	it('should handle service errors gracefully', async () => {