Skip to content

Commit 60437cd

Browse files
authored
Merge branch 'main' into bugfix/e2e-stress-test-fixes
2 parents 7b3c12c + ada79b8 commit 60437cd

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

_TODO.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
11
<!-- markdownlint-disable-file -->
22
# TODO
33

4+
Inspect the built HTML for /testing/carousel and the home page to confirm the inline `<script type="module">` blocks that call register{Carousel,Testimonials}WebComponent() are still present after bundling. If they're getting tree-shaken or deferred incorrectly, the custom elements would never hydrate, which matches the data-carousel-ready hang.
5+
6+
Capture console output during one stress-run slice (e.g., testimonials.spec.ts in Chromium) to see if the Embla modules or our error handler are throwing—any runtime exception inside initialize() would tear down the element and prevent the ready flag. I'll focus on the [TestimonialsCarouselElement] initialize log path.
7+
8+
For the service-worker suite, verify that PwaPage.enableServiceWorkerForE2E() actually overrides window.__disableServiceWorkerForE2E after each navigation by logging the flag inside registerServiceWorker() before the early-return, and make sure our init scripts run in the right order when multiple addInitScript calls are stacked.
9+
10+
## Pause and Play
11+
412
Next, I'd like to add a "pause" and "play" icon to src/components/Animations/Computers
513
There are icons with those names already configured for the Icon component.
614
There are hooks for pause and play already setup in the component.

0 commit comments

Comments
 (0)