Skip to content

Commit 2fd4d2e

Browse files
committed
Lint fix in BreadCrumbs page object model
1 parent 50ae88c commit 2fd4d2e

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

src/lib/config/pwa.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ export const pwaConfig: PwaOptions = {
2323
},
2424
manifestFilename: 'manifest.json',
2525
registerType: 'autoUpdate',
26+
/**
27+
* Options for manifest.json generation
28+
*/
2629
manifest: {
2730
background_color: '#f3f4f6',
2831
description: contactData.company.description,
@@ -57,6 +60,9 @@ export const pwaConfig: PwaOptions = {
5760
},
5861
],
5962
},
63+
/**
64+
* Options for Workbox service worker generation
65+
*/
6066
workbox: {
6167
// ID to be prepended to cache names
6268
cacheId: 'webstackbuilders',

test/e2e/helpers/pageObjectModels/BreadCrumbPage.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,10 @@ export class BreadCrumbPage extends BasePage {
6969
return
7070
}
7171

72-
const navigationPromise = this.page.waitForNavigation({ waitUntil: 'domcontentloaded', timeout: 15000 })
72+
const navigationPromise = this.page.waitForURL(
73+
(url: URL) => url.pathname === targetHref,
74+
{ waitUntil: 'domcontentloaded', timeout: 15000 },
75+
)
7376
await this.click(`a[href="${targetHref}"]`)
7477
await navigationPromise
7578
await this.waitForLoadState('networkidle')

0 commit comments

Comments
 (0)