Skip to content
This repository was archived by the owner on Aug 8, 2022. It is now read-only.
This repository was archived by the owner on Aug 8, 2022. It is now read-only.

Caching of __CURRENT__ in GeneralUtility::$rootlineCache breaks Sitemap...Tasks #533

Description

@stuartmcfarlane

Multi site installations will only build the sitemap.xml of the first site.

The AbstractSitemapTask iterates over the root pages calling AbstractTask::initRootPage for each root page and subsequently buildSitemap. buildSitemap will then instantiate a Generator whose constructor will call GeneralUtility::getRootPid to get the root pid that was set when AbstractTask::initRootPage was called. This only works in the first iteration because GeneralUtility::getRootLine will be called in each iteration without specifying the uid meaning the cached CURRENT rootline will always be used regardless of the actual current pid.

MetaSEO version: 2.1.0

TYPO3 version: 7.6.29

PHP version: 5.5.38

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions