From edb614850185333c9f938430133a4ef987e19b30 Mon Sep 17 00:00:00 2001
From: "warp-factories[bot]" <warp-factories[bot]@users.noreply.github.com>
Date: Fri, 4 Sep 2026 20:42:13 +0000
Subject: [PATCH] Ignore three timing-dependent tests on Windows CI (APP-5820)

Mark the three tests identified in APP-5820 as ignored on Windows only,
matching the existing #[cfg_attr(windows, ignore = "...")] convention
used elsewhere in this codebase for known Windows CI flakes. Coverage
is preserved on Linux and macOS, where these tests are reliable.

- terminal::shared_session::sharer::network::tests::test_handle_pty_read_event_while_batching
- terminal::shared_session::sharer::network::tests::test_selection_updates_throttled_and_duplicates_ignored
- terminal_session_view::tests::shell_completion_source_warmup_loads_path_executables

This is the immediate mitigation requested in APP-5820 so that unrelated
PRs stop getting blocked by these flakes. The real fix (replacing the
implicit timing assumptions with polling on observable state and then
removing these ignore attributes) is tracked separately in that issue.
---
 app/src/terminal/shared_session/sharer/network_tests.rs | 2 ++
 crates/warp_tui/src/terminal_session_view_tests.rs      | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/app/src/terminal/shared_session/sharer/network_tests.rs b/app/src/terminal/shared_session/sharer/network_tests.rs
index ec4f7a233ef..06bf3992044 100644
--- a/app/src/terminal/shared_session/sharer/network_tests.rs
+++ b/app/src/terminal/shared_session/sharer/network_tests.rs
@@ -329,6 +329,7 @@ fn test_send_pty_read_event_while_not_batching() {
     });
 }
 
+#[cfg_attr(windows, ignore = "APP-5820: flaky on Windows CI")]
 #[test]
 fn test_handle_pty_read_event_while_batching() {
     App::test((), |mut app| async move {
@@ -590,6 +591,7 @@ fn test_ignore_duplicate_prompt_updates() {
     });
 }
 
+#[cfg_attr(windows, ignore = "APP-5820: flaky on Windows CI")]
 #[test]
 fn test_selection_updates_throttled_and_duplicates_ignored() {
     App::test((), |mut app| async move {
diff --git a/crates/warp_tui/src/terminal_session_view_tests.rs b/crates/warp_tui/src/terminal_session_view_tests.rs
index d061c8868db..6f895885e11 100644
--- a/crates/warp_tui/src/terminal_session_view_tests.rs
+++ b/crates/warp_tui/src/terminal_session_view_tests.rs
@@ -1042,6 +1042,8 @@ fn shell_mode_reserves_tab_even_when_attachments_render() {
     assert!(!attachment_focus_available(true, true));
     assert!(!attachment_focus_available(false, false));
 }
+
+#[cfg_attr(windows, ignore = "APP-5820: flaky on Windows CI")]
 #[test]
 fn shell_completion_source_warmup_loads_path_executables() {
     App::test((), |mut app| async move {