From 09dd5eb984333900a1c2aac0dea6d11301509b31 Mon Sep 17 00:00:00 2001 From: Warp Date: Fri, 4 Sep 2026 16:40:09 +0000 Subject: [PATCH] Clean up VerticalTabsSummaryMode feature flag --- app/Cargo.toml | 2 -- app/src/features.rs | 2 -- app/src/workspace/view/vertical_tabs.rs | 35 ++++++++----------------- crates/warp_features/src/lib.rs | 4 --- 4 files changed, 11 insertions(+), 32 deletions(-) diff --git a/app/Cargo.toml b/app/Cargo.toml index 1f90fcf3142..e84359435fe 100644 --- a/app/Cargo.toml +++ b/app/Cargo.toml @@ -669,7 +669,6 @@ default = [ "open_code_notifications", "cli_agent_rich_input", "vertical_tabs", - "vertical_tabs_summary_mode", "tab_configs", "grouped_tabs", "pinned_tabs", @@ -1006,7 +1005,6 @@ inline_menu_headers = [] directory_tab_colors = [] hoa_code_review = [] vertical_tabs = [] -vertical_tabs_summary_mode = [] tab_configs = [] grouped_tabs = [] pinned_tabs = [] diff --git a/app/src/features.rs b/app/src/features.rs index d3f907db7a3..2ce3d423212 100644 --- a/app/src/features.rs +++ b/app/src/features.rs @@ -453,8 +453,6 @@ fn enabled_features() -> HashSet { FeatureFlag::HoaCodeReview, #[cfg(feature = "vertical_tabs")] FeatureFlag::VerticalTabs, - #[cfg(feature = "vertical_tabs_summary_mode")] - FeatureFlag::VerticalTabsSummaryMode, #[cfg(feature = "tab_configs")] FeatureFlag::TabConfigs, #[cfg(feature = "grouped_tabs")] diff --git a/app/src/workspace/view/vertical_tabs.rs b/app/src/workspace/view/vertical_tabs.rs index 2894be9c1d7..23d138b3a3e 100644 --- a/app/src/workspace/view/vertical_tabs.rs +++ b/app/src/workspace/view/vertical_tabs.rs @@ -994,13 +994,7 @@ fn resolve_vertical_tabs_mode(app: &AppContext) -> VerticalTabsResolvedMode { VerticalTabsDisplayGranularity::Tabs => match *settings.vertical_tabs_tab_item_mode.value() { VerticalTabsTabItemMode::FocusedSession => VerticalTabsResolvedMode::FocusedSession, - VerticalTabsTabItemMode::Summary => { - if FeatureFlag::VerticalTabsSummaryMode.is_enabled() { - VerticalTabsResolvedMode::Summary - } else { - VerticalTabsResolvedMode::FocusedSession - } - } + VerticalTabsTabItemMode::Summary => VerticalTabsResolvedMode::Summary, }, } } @@ -5801,8 +5795,7 @@ pub(super) fn render_settings_popup( let show_details_on_hover = *TabSettings::as_ref(app) .vertical_tabs_show_details_on_hover .value(); - let show_tab_item_section = matches!(current_granularity, VerticalTabsDisplayGranularity::Tabs) - && FeatureFlag::VerticalTabsSummaryMode.is_enabled(); + let show_tab_item_section = matches!(current_granularity, VerticalTabsDisplayGranularity::Tabs); let show_focused_session_controls = !matches!( resolve_vertical_tabs_mode(app), VerticalTabsResolvedMode::Summary @@ -5892,18 +5885,14 @@ pub(super) fn render_settings_popup( theme, ); - let summary_option = if FeatureFlag::VerticalTabsSummaryMode.is_enabled() { - Some(render_tab_item_mode_option( - "Summary", - matches!(current_tab_item_mode, VerticalTabsTabItemMode::Summary), - state.summary_option_mouse_state.clone(), - VerticalTabsTabItemMode::Summary, - appearance, - theme, - )) - } else { - None - }; + let summary_option = render_tab_item_mode_option( + "Summary", + matches!(current_tab_item_mode, VerticalTabsTabItemMode::Summary), + state.summary_option_mouse_state.clone(), + VerticalTabsTabItemMode::Summary, + appearance, + theme, + ); let density_header = Container::new( Text::new_inline( @@ -6035,9 +6024,7 @@ pub(super) fn render_settings_popup( popup_col.add_child(make_divider(theme)); popup_col.add_child(tab_item_header); popup_col.add_child(focused_session_option); - if let Some(summary_option) = summary_option { - popup_col.add_child(summary_option); - } + popup_col.add_child(summary_option); } if show_focused_session_controls { diff --git a/crates/warp_features/src/lib.rs b/crates/warp_features/src/lib.rs index 49e10d2ae9a..26c4e63adfc 100644 --- a/crates/warp_features/src/lib.rs +++ b/crates/warp_features/src/lib.rs @@ -845,10 +845,6 @@ pub enum FeatureFlag { /// Redux of the setup/initial user query UI for cloud mode. CloudModeSetupV2, - /// Enables summary mode in vertical tabs, showing condensed tab summaries - /// instead of individual pane rows. - VerticalTabsSummaryMode, - CloudModeInputV2, /// Enables continuing cloud mode conversations in the cloud after an execution ends.