From bd1e49d016e6e1fbbc299f8f18a8f7e2372ceb31 Mon Sep 17 00:00:00 2001 From: sathvik vang Date: Thu, 3 Sep 2026 11:32:16 -0400 Subject: [PATCH 1/3] Restore Command Completions ownership routing Co-Authored-By: Warp --- .github/STAKEHOLDERS | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/.github/STAKEHOLDERS b/.github/STAKEHOLDERS index c149687e..ab813996 100644 --- a/.github/STAKEHOLDERS +++ b/.github/STAKEHOLDERS @@ -3,15 +3,6 @@ # It is read by the Warp for OSS factory to route issues and PRs to the # right maintainer for review. -# Default owner -* @vikvang - -# Completion specs (JSON signatures) -/command-signatures/ @captainsafia - -# Rust crate / parser -/src/ @vkodithala -/Cargo.toml @vkodithala - -# Docs and contributor guidance -/README.md @captainsafia +# Command Signatures belongs to the App team's Command Completions ownership +# area in warpdotdev/warp-ownership/ownership-areas/app.md. +* @acarl005 From 80a515a1ffee886281c1547ccb32567e28a8bfe7 Mon Sep 17 00:00:00 2001 From: sathvik vang Date: Thu, 3 Sep 2026 11:38:40 -0400 Subject: [PATCH 2/3] Add semantic App ownership catalogue Co-Authored-By: Warp --- .agents/ownership-areas/app.md | 215 +++++++++++++++++++++++++++++++++ 1 file changed, 215 insertions(+) create mode 100644 .agents/ownership-areas/app.md diff --git a/.agents/ownership-areas/app.md b/.agents/ownership-areas/app.md new file mode 100644 index 00000000..29df8813 --- /dev/null +++ b/.agents/ownership-areas/app.md @@ -0,0 +1,215 @@ +# App + +Ownership areas for the App team. + +### Conversation and Session Restoration +- **Owners**: @seemeroland +- **Matches**: Restoring previous agent conversations, session persistence across restarts, conversation history loading + +### Cloud-synced conversations +- **Owners**: @seemeroland +- **Matches**: Conversation transcript view, conversation details panel, conversation sharing + +### Planning +- **Owners**: @seemeroland +- **Matches**: Agent plan creation and editing, plan approval workflows, plan syncing and sharing + +### Autosuggestion +- **Owners**: @seemeroland +- **Matches**: Inline ghost text suggestions, autocomplete in the input editor (excluding command completions) + +### Command Completions +- **Owners**: @acarl005 +- **Matches**: Command completions and suggestions triggered by slash or command entry, autocomplete specific to commands + +### MCP (Model Context Protocol) +- **Owners**: @peicodes , @vkodithala +- **Matches**: MCP server connections, MCP tools and resources, third-party integrations via MCP + +### File-based MCPs +- **Owners**: @vkodithala +- **Matches**: MCP servers configured via files (e.g. ~/.warp/.mcp.json), file-based MCP configuration and management + +### Skills +- **Owners**: @peicodes , @vkodithala +- **Matches**: Using, creating, finding agent skills.md files + +### Conversation Management +- **Owners**: @harryalbert +- **Matches**: Managing multiple agent conversations, conversation list, switching between conversations, conversation search in the command palette, forking conversations + +### Conversation Rewind +- **Owners**: @alokedesai +- **Matches**: Rewind conversation to earlier state, including undoing code changes made by agent after rewind point + +### Credit Usage Footer +- **Owners**: @harryalbert +- **Matches**: Footer at end of AI blocks showing credits used + +### Input UI +- **Owners**: @harryalbert +- **Matches**: UI in the input area (not input text editor) including context window usage indicator, AI model selector, inline input menu infrastructure (not including behavior of specific inline input menus owned by someone else) + +### Custom Models +- **Owners**: @danielpeng2 , @dagmfactory +- **Matches**: Custom model configuration and behavior for BYOK/custom inference endpoints, including custom endpoint model selection, custom model persistence in profiles, and custom model preferences. Excludes generic model selector UI unless the issue is specific to custom models or custom endpoints + +### Natural Language Detection +- **Owners**: @evelyn-with-warp +- **Matches**: Classifying typed input as natural-language agent prompts vs. shell commands + +### Image Attachment and Voice Input +- **Owners**: @Advait-M +- **Matches**: Attaching images as context to agent prompts, voice-to-text input + +### Code Editor / LSP / Notebooks Editor +- **Owners**: @kevinyang372 , @bnavetta +- **Matches**: Code diff viewer, language server features, notebook markdown editing and rendering, code block display, apply file diff tool calls in AI blocks + +### @ Context and Slash Commands +- **Owners**: @moirahuang +- **Matches**: Attaching via @ context to agent prompt, slash command general UI and infra, and fallback when specific slash command is not owned by someone else + +### Global Search / File Tree +- **Owners**: @moirahuang +- **Matches**: Global string search across files, the file tree sidebar, file navigation, file search in the command palette + +### Onboarding +- **Owners**: @jefflloyd +- **Matches**: Onboarding flow, onboarding callouts, first-time user experience, onboarding tooltips and walkthroughs + +### Code Review +- **Owners**: @MaggieShan +- **Matches**: Code review panel UI, adding and submitting code review comments + +### Git Statistics +- **Owners**: @kevinyang372 , @MaggieShan +- **Matches**: Git status statistics surfaced in Warp features, including the git diff chip, branch status, upstream tracking counts, ahead/behind counts, and other git-derived repository statistics + +### Git Operations +- **Owners**: @MaggieShan +- **Matches**: Git operations performed from Warp, including the git dialog in the code review view and its actions (e.g. staging, committing, pushing, pulling, branch operations). Excludes git-derived statistics (see "Git Statistics") and code review comment UI (see "Code Review") + +### Modality and Cloud Mode UI +- **Owners**: @zachbai , @MaggieShan +- **Matches**: Switching between terminal, agent view, and cloud mode. Welcome and zero-state blocks in those views + +### Passive Suggestions +- **Owners**: @Advait-M +- **Matches**: Passive code diff suggestions, passive unit tests, prompt suggestion UX + +### Web Search +- **Owners**: @Advait-M +- **Matches**: Agent web search capability, web search and web fetch tool calls in AI blocks + +### Long running command subagent +- **Owners**: @MaggieShan , @vkodithala , @zachbai +- **Matches**: Agent interaction with long running commands and pagers, agent stuck in long running command/pagers, CLI subagent, cancellations of shell commands run by agent + +### Rules and WARP.md +- **Owners**: @MaggieShan +- **Matches**: User-defined rules, WARP.md project rules, persistent agent instructions + +### Warp Drive Objects and Infra +- **Owners**: @seemeroland +- **Matches**: Workflows, notebooks, prompts, environment variable collections, generic string objects, Warp Drive sync, cloud object management, ACLs, sharing dialog and permissions + +### Codebase Context +- **Owners**: @kevinyang372 +- **Matches**: Codebase indexing, semantic code search, repository context for agents, codebase search tool calls in AI blocks + +### Universal Agent Support +- **Owners**: @liliwilson , @bnavetta +- **Matches**: Features related to working with third-party CLI coding agents (Claude Code, Codex, OpenCode, Gemini), including harness availability detection, harness setup flows, auth secrets for harnesses, harness-specific UI (e.g. codex modal, harness selector), and local harness launch infrastructure + +### CLI Agent UI +- **Owners**: @alokedesai +- **Matches**: UI footer shown in other agent CLIs like claude code, codex, gemini CLI + +### /pr-comments +- **Owners**: @kevinyang372 +- **Matches**: /pr-comments slash command + +### Mac/Linux Platform Issues +- **Owners**: @alokedesai +- **Matches**: macOS/Linux-specific bugs or integration issues + +### Windows Platform Issues +- **Owners**: @acarl005 +- **Matches**: Windows-specific bugs or integration issues + +### Command Palette +- **Owners**: @acarl005 +- **Matches**: Command palette search and ordering, data mixer logic, command palette UI (unless for an area specifically owned by someone else) + +### Shell Compatibility +- **Owners**: @zachbai , @vorporeal , @acarl005 +- **Matches**: Bash/zsh/fish/PowerShell support, shell integration, POSIX compliance issues + +### Completions and Bootstrap +- **Owners**: @zachbai , @szgupta , @alokedesai +- **Matches**: Shell tab completions, first-run bootstrap, shell startup and prompt (PS1) rendering + +### Performance Issues +- **Owners**: @alokedesai +- **Matches**: Slow rendering, high CPU/memory usage, lag, responsiveness problems not relating to an existing area of ownership + +### UI Framework +- **Owners**: @vorporeal +- **Matches**: Core UI rendering framework, layout engine, text rendering, shader logic. Infrastructure-level only and not for feedback about any specific UI + +### Settings and Keybindings +- **Owners**: @acarl005 +- **Matches**: Preferences panel, keyboard shortcuts, keybinding customization, settings UI infra + +### Blocklist UX +- **Owners**: @zachbai , @MaggieShan +- **Matches**: Appearance of shell command and AI blocks, buttons/interactions relating to blocks, requested command tool calls in AI blocks + +### Find, Link Detection, Text Selection +- **Owners**: @seemeroland +- **Matches**: Find/search within terminal output or AI blocks, clickable links in output, text selection behavior + +### Asynchronous Find (experimental) +- **Owners**: @vkodithala +- **Matches**: Experimental background-thread implementation of find within terminal output or AI blocks. Will merge with "Find, Link Detection, Text Selection" once it becomes the default implementation. + +### Warpifying +- **Owners**: @zachbai , @MaggieShan , @kevinyang372 , @moirahuang +- **Matches**: Converting raw terminal output from SSH sessions into Warp's block-based UI + +### Warpify Footer +- **Owners**: @MaggieShan +- **Matches**: Warpify footer UI, controls, and interactions + +### Input Editor +- **Owners**: @vkodithala +- **Matches**: The terminal command input area, text input, cursor behavior + +### IME (Input Method Editor) +- **Owners**: @acarl005 , @vkodithala +- **Matches**: Input method editor composition, including inputting CJK characters and other characters that require composition. Covers the notion of "marked text" in the editor and grid implementations (input editor, find bar, notebooks rich text editor, alt-screen apps like vim, and inside a block during a long running command). + +### Vim Keybindings +- **Owners**: @acarl005 +- **Matches**: Warp's implementation of Vim keybindings or any settings pertaining to that. + +### Vertical Tabs +- **Owners**: @johnturcoo +- **Matches**: Vertical tab bar, vertical tabs UI, tab sidebar, vtab + +### Tab Groups +- **Owners**: @johnturcoo +- **Matches**: Grouping and organizing tabs, tab group creation and management, tab group UI + +### Window, Tab, and Pane Management +- **Owners**: @vkodithala +- **Matches**: Split panes, tab management, window resizing, multi-pane layouts + +### Grep tool call +- **Owners**: @vkodithala , @moirahuang , @szgupta +- **Matches**: UI for grep tool used by agent + +### Tab configs +- **Owners**: @moirahuang +- **Matches**: Create and edit existing tab configs to configure how you want a tab to be set up From b9da7a9a659e8e54966fda68681c04f40f756310 Mon Sep 17 00:00:00 2001 From: sathvik vang Date: Thu, 3 Sep 2026 11:55:12 -0400 Subject: [PATCH 3/3] Remove vendored ownership catalogue Co-Authored-By: Warp --- .agents/ownership-areas/app.md | 215 --------------------------------- .github/STAKEHOLDERS | 3 +- 2 files changed, 1 insertion(+), 217 deletions(-) diff --git a/.agents/ownership-areas/app.md b/.agents/ownership-areas/app.md index 29df8813..e69de29b 100644 --- a/.agents/ownership-areas/app.md +++ b/.agents/ownership-areas/app.md @@ -1,215 +0,0 @@ -# App - -Ownership areas for the App team. - -### Conversation and Session Restoration -- **Owners**: @seemeroland -- **Matches**: Restoring previous agent conversations, session persistence across restarts, conversation history loading - -### Cloud-synced conversations -- **Owners**: @seemeroland -- **Matches**: Conversation transcript view, conversation details panel, conversation sharing - -### Planning -- **Owners**: @seemeroland -- **Matches**: Agent plan creation and editing, plan approval workflows, plan syncing and sharing - -### Autosuggestion -- **Owners**: @seemeroland -- **Matches**: Inline ghost text suggestions, autocomplete in the input editor (excluding command completions) - -### Command Completions -- **Owners**: @acarl005 -- **Matches**: Command completions and suggestions triggered by slash or command entry, autocomplete specific to commands - -### MCP (Model Context Protocol) -- **Owners**: @peicodes , @vkodithala -- **Matches**: MCP server connections, MCP tools and resources, third-party integrations via MCP - -### File-based MCPs -- **Owners**: @vkodithala -- **Matches**: MCP servers configured via files (e.g. ~/.warp/.mcp.json), file-based MCP configuration and management - -### Skills -- **Owners**: @peicodes , @vkodithala -- **Matches**: Using, creating, finding agent skills.md files - -### Conversation Management -- **Owners**: @harryalbert -- **Matches**: Managing multiple agent conversations, conversation list, switching between conversations, conversation search in the command palette, forking conversations - -### Conversation Rewind -- **Owners**: @alokedesai -- **Matches**: Rewind conversation to earlier state, including undoing code changes made by agent after rewind point - -### Credit Usage Footer -- **Owners**: @harryalbert -- **Matches**: Footer at end of AI blocks showing credits used - -### Input UI -- **Owners**: @harryalbert -- **Matches**: UI in the input area (not input text editor) including context window usage indicator, AI model selector, inline input menu infrastructure (not including behavior of specific inline input menus owned by someone else) - -### Custom Models -- **Owners**: @danielpeng2 , @dagmfactory -- **Matches**: Custom model configuration and behavior for BYOK/custom inference endpoints, including custom endpoint model selection, custom model persistence in profiles, and custom model preferences. Excludes generic model selector UI unless the issue is specific to custom models or custom endpoints - -### Natural Language Detection -- **Owners**: @evelyn-with-warp -- **Matches**: Classifying typed input as natural-language agent prompts vs. shell commands - -### Image Attachment and Voice Input -- **Owners**: @Advait-M -- **Matches**: Attaching images as context to agent prompts, voice-to-text input - -### Code Editor / LSP / Notebooks Editor -- **Owners**: @kevinyang372 , @bnavetta -- **Matches**: Code diff viewer, language server features, notebook markdown editing and rendering, code block display, apply file diff tool calls in AI blocks - -### @ Context and Slash Commands -- **Owners**: @moirahuang -- **Matches**: Attaching via @ context to agent prompt, slash command general UI and infra, and fallback when specific slash command is not owned by someone else - -### Global Search / File Tree -- **Owners**: @moirahuang -- **Matches**: Global string search across files, the file tree sidebar, file navigation, file search in the command palette - -### Onboarding -- **Owners**: @jefflloyd -- **Matches**: Onboarding flow, onboarding callouts, first-time user experience, onboarding tooltips and walkthroughs - -### Code Review -- **Owners**: @MaggieShan -- **Matches**: Code review panel UI, adding and submitting code review comments - -### Git Statistics -- **Owners**: @kevinyang372 , @MaggieShan -- **Matches**: Git status statistics surfaced in Warp features, including the git diff chip, branch status, upstream tracking counts, ahead/behind counts, and other git-derived repository statistics - -### Git Operations -- **Owners**: @MaggieShan -- **Matches**: Git operations performed from Warp, including the git dialog in the code review view and its actions (e.g. staging, committing, pushing, pulling, branch operations). Excludes git-derived statistics (see "Git Statistics") and code review comment UI (see "Code Review") - -### Modality and Cloud Mode UI -- **Owners**: @zachbai , @MaggieShan -- **Matches**: Switching between terminal, agent view, and cloud mode. Welcome and zero-state blocks in those views - -### Passive Suggestions -- **Owners**: @Advait-M -- **Matches**: Passive code diff suggestions, passive unit tests, prompt suggestion UX - -### Web Search -- **Owners**: @Advait-M -- **Matches**: Agent web search capability, web search and web fetch tool calls in AI blocks - -### Long running command subagent -- **Owners**: @MaggieShan , @vkodithala , @zachbai -- **Matches**: Agent interaction with long running commands and pagers, agent stuck in long running command/pagers, CLI subagent, cancellations of shell commands run by agent - -### Rules and WARP.md -- **Owners**: @MaggieShan -- **Matches**: User-defined rules, WARP.md project rules, persistent agent instructions - -### Warp Drive Objects and Infra -- **Owners**: @seemeroland -- **Matches**: Workflows, notebooks, prompts, environment variable collections, generic string objects, Warp Drive sync, cloud object management, ACLs, sharing dialog and permissions - -### Codebase Context -- **Owners**: @kevinyang372 -- **Matches**: Codebase indexing, semantic code search, repository context for agents, codebase search tool calls in AI blocks - -### Universal Agent Support -- **Owners**: @liliwilson , @bnavetta -- **Matches**: Features related to working with third-party CLI coding agents (Claude Code, Codex, OpenCode, Gemini), including harness availability detection, harness setup flows, auth secrets for harnesses, harness-specific UI (e.g. codex modal, harness selector), and local harness launch infrastructure - -### CLI Agent UI -- **Owners**: @alokedesai -- **Matches**: UI footer shown in other agent CLIs like claude code, codex, gemini CLI - -### /pr-comments -- **Owners**: @kevinyang372 -- **Matches**: /pr-comments slash command - -### Mac/Linux Platform Issues -- **Owners**: @alokedesai -- **Matches**: macOS/Linux-specific bugs or integration issues - -### Windows Platform Issues -- **Owners**: @acarl005 -- **Matches**: Windows-specific bugs or integration issues - -### Command Palette -- **Owners**: @acarl005 -- **Matches**: Command palette search and ordering, data mixer logic, command palette UI (unless for an area specifically owned by someone else) - -### Shell Compatibility -- **Owners**: @zachbai , @vorporeal , @acarl005 -- **Matches**: Bash/zsh/fish/PowerShell support, shell integration, POSIX compliance issues - -### Completions and Bootstrap -- **Owners**: @zachbai , @szgupta , @alokedesai -- **Matches**: Shell tab completions, first-run bootstrap, shell startup and prompt (PS1) rendering - -### Performance Issues -- **Owners**: @alokedesai -- **Matches**: Slow rendering, high CPU/memory usage, lag, responsiveness problems not relating to an existing area of ownership - -### UI Framework -- **Owners**: @vorporeal -- **Matches**: Core UI rendering framework, layout engine, text rendering, shader logic. Infrastructure-level only and not for feedback about any specific UI - -### Settings and Keybindings -- **Owners**: @acarl005 -- **Matches**: Preferences panel, keyboard shortcuts, keybinding customization, settings UI infra - -### Blocklist UX -- **Owners**: @zachbai , @MaggieShan -- **Matches**: Appearance of shell command and AI blocks, buttons/interactions relating to blocks, requested command tool calls in AI blocks - -### Find, Link Detection, Text Selection -- **Owners**: @seemeroland -- **Matches**: Find/search within terminal output or AI blocks, clickable links in output, text selection behavior - -### Asynchronous Find (experimental) -- **Owners**: @vkodithala -- **Matches**: Experimental background-thread implementation of find within terminal output or AI blocks. Will merge with "Find, Link Detection, Text Selection" once it becomes the default implementation. - -### Warpifying -- **Owners**: @zachbai , @MaggieShan , @kevinyang372 , @moirahuang -- **Matches**: Converting raw terminal output from SSH sessions into Warp's block-based UI - -### Warpify Footer -- **Owners**: @MaggieShan -- **Matches**: Warpify footer UI, controls, and interactions - -### Input Editor -- **Owners**: @vkodithala -- **Matches**: The terminal command input area, text input, cursor behavior - -### IME (Input Method Editor) -- **Owners**: @acarl005 , @vkodithala -- **Matches**: Input method editor composition, including inputting CJK characters and other characters that require composition. Covers the notion of "marked text" in the editor and grid implementations (input editor, find bar, notebooks rich text editor, alt-screen apps like vim, and inside a block during a long running command). - -### Vim Keybindings -- **Owners**: @acarl005 -- **Matches**: Warp's implementation of Vim keybindings or any settings pertaining to that. - -### Vertical Tabs -- **Owners**: @johnturcoo -- **Matches**: Vertical tab bar, vertical tabs UI, tab sidebar, vtab - -### Tab Groups -- **Owners**: @johnturcoo -- **Matches**: Grouping and organizing tabs, tab group creation and management, tab group UI - -### Window, Tab, and Pane Management -- **Owners**: @vkodithala -- **Matches**: Split panes, tab management, window resizing, multi-pane layouts - -### Grep tool call -- **Owners**: @vkodithala , @moirahuang , @szgupta -- **Matches**: UI for grep tool used by agent - -### Tab configs -- **Owners**: @moirahuang -- **Matches**: Create and edit existing tab configs to configure how you want a tab to be set up diff --git a/.github/STAKEHOLDERS b/.github/STAKEHOLDERS index ab813996..502c00c0 100644 --- a/.github/STAKEHOLDERS +++ b/.github/STAKEHOLDERS @@ -3,6 +3,5 @@ # It is read by the Warp for OSS factory to route issues and PRs to the # right maintainer for review. -# Command Signatures belongs to the App team's Command Completions ownership -# area in warpdotdev/warp-ownership/ownership-areas/app.md. +# Default path owner for command-signatures pull requests. * @acarl005