list_all_packages suggests blank entries when dpkg-query output has trailing newline

[vikvang]

Description

The list_all_packages generator callback in command-signatures/src/generators/apt.rs pushes a suggestion for every line of output without filtering empty lines. Unlike list_available_packages (which guards with is_empty()), a trailing newline or blank line in dpkg-query output produces an empty suggestion in the completion list.

Where

command-signatures/src/generators/apt.rs — compare list_all_packages (no empty check) with list_available_packages (has the check). list_all_deb_files_in_cwd has the same gap.

Expected

Blank lines filtered out before creating suggestions, consistently across the three apt callbacks.

Impact

Cosmetic but user-visible: an empty row can appear in apt-get completions.

[warp-factories]

Thanks for the report — the factory is taking a look and will follow up with a triage summary shortly.

Responding as Warp for OSS: Open session · View run

[warp-factories]

Triage summary

Bug: list_all_packages and list_all_deb_files_in_cwd in command-signatures/src/generators/apt.rs push a suggestion for every line of script output, while sibling list_available_packages already skips empty lines with is_empty().

Code check (confirmed):

• list_all_packages (lines 16–25): no empty-line guard
• list_available_packages (lines 27–38): guards with if !package_name.is_empty()
• list_all_deb_files_in_cwd (lines 40–50): no empty-line guard
• GeneratorResults collection does not filter empty suggestion names downstream

Nuance: Rust str::lines() does not emit an empty last line for a single trailing newline (so normal dpkg-query --show --showformat '${Package}\n' output alone is fine). Empty suggestions do appear when the callback sees a blank line (e.g. consecutive newlines mid-output, or output that is only a newline). Aligning the two callbacks with the existing is_empty() guard is still the right fix for consistency and defense-in-depth.

Reproducibility: High for the code path (feed the callbacks a string with a blank line and observe an empty-named suggestion). Cosmetic impact when it surfaces in apt-get/aptitude completions.

Likely fix: Add the same !line.is_empty() filter used in list_available_packages to list_all_packages and list_all_deb_files_in_cwd (small, localized change; good first issue).

Duplicates: None found among open issues.

Routing to @captainsafia to review and apply a gate label (ready-to-spec / ready-to-implement) if this should proceed.

Responding as Warp for OSS: Open session · View run

[vikvang]

@warp-factory go for it

[warp-agent-staging]

No Factory you can access is connected to warpdotdev/command-signatures. Go to platform.staging.warp.dev to connect this repository to a Factory or ask a Factory admin for access. See Factory GitHub integration docs. Then mention @warp-factory again.

[warp-factories]

Triage is already complete on this issue, so there's nothing further the factory can start here on its own.

Implementation is behind a maintainer gate: this issue needs the ready-to-implement label (or ready-to-spec if it should get a written spec first) before the factory can pick it up. That label has to come from a maintainer — the factory can't apply it or work around it, and a comment can't stand in for it.

I've assigned @captainsafia as the owner for this path. Once a gate label is on, mention the factory again and it will proceed.

Responding as Warp for OSS: Open session · View run

[vikvang]

@warp-factory please re-triage this with the latest workflow.

[warp-agent-staging]

No Factory you can access is connected to warpdotdev/command-signatures. Go to platform.staging.warp.dev to connect this repository to a Factory or ask a Factory admin for access. See Factory GitHub integration docs. Then mention @warp-factory again.