fix(cli): reject invalid/unknown-flag positionals in hand-rolled arg parsers (#222)

The CLI now rejects a mistyped/unknown flag instead of silently turning it into a project name, hostname, or scaffolded filename.

## The bug
Three hand-rolled arg parsers captured an invalid leading-dash token as a positional instead of erroring — unlike every `parseArgs({strict})` parser and the sibling branches that already guard:
- `parseProjectArgs` (`status`/`link`/`rollback`/`cancel`): `void project status --foo` returned `name: '--foo'`, a bogus slug then sent to the platform — even though the sibling `delete` branch already rejects unknown flags.
- `parseDomainArgs`: an unknown flag was captured as the hostname (or silently dropped).
- `parseMiddlewareArgs` (`void gen`): any name was accepted, so `void gen middleware --foo` scaffolded a file literally named `001.--foo.ts` — while the sibling gen parsers (model/migration/cron/queue) all validate the name.

## Expected-correct behavior
A leading-dash / invalid token is not a valid positional → reject it, matching the contract the rest of the CLI already enforces.

## Minimal repro
`parseProjectArgs(['status', '--foo'])` returned `{ subcommand: 'status', name: '--foo' }` (should throw `project: Unknown flag '--foo'.`).

## The fix
Add the leading-dash guard the `delete` branch already uses to the four project branches and the domain parser loop, and give `parseMiddlewareArgs` the same name regex (`/^[a-z_][a-z0-9_-]*$/`) its gen siblings already use. No legitimate positional (project slug, `dpl_` id, DNS hostname, middleware name) starts with `-`.

## Tests
Regression tests added (`project-args.test.ts`, new `domain-args.test.ts`, `gen-args.test.ts`): 6 unknown-flag rejections that fail on `origin/main` and pass after, plus happy-path/hyphenated-name guards. Local gate: the three arg test files 63/63; full `--project unit` zero-collateral vs a clean `origin/main` baseline (identical pre-existing adapter/init-migration failures, unrelated); `packages/void` typecheck + lint + fmt clean.

I enumerated every CLI parser to confirm these were the only three hand-rolled ones still swallowing invalid positionals (the rest use strict `parseArgs`, a subcommand allowlist, or a name regex), so the bug class is fully covered.

Prepared with AI assistance.

Author: hyfdev

packages/void/src/cli/domain-args.ts

@@ -32,6 +32,8 @@ export function parseDomainArgs(args: Array<string>): DomainArgs {
       projectSlug = rest[++i];
     } else if (rest[i] === '--verbose') {
       verbose = true;
+    } else if (rest[i].startsWith('-')) {
+      throw new Error(`domain: Unknown flag '${rest[i]}'.`);
     } else if (!hostname) {
       hostname = rest[i];
     }

packages/void/src/cli/gen-args.ts

@@ -57,12 +57,16 @@ const COLUMN_TYPES = new Set(['string', 'text', 'datetime', 'integer', 'boolean'
 
 const VALID_METHODS = new Set(['get', 'post', 'put', 'patch', 'delete']);
 
+// Generated-file name validators (hoisted once); *_HYPHENS variant also allows hyphens (cron/queue/middleware).
+const NAME_RE = /^[a-z_][a-z0-9_]*$/;
+const NAME_WITH_HYPHENS_RE = /^[a-z_][a-z0-9_-]*$/;
+
 function parseModelArgs(args: Array<string>): GenArgs {
   const [name, ...rest] = args;
   if (!name) {
     throw new Error('gen: Usage: void gen model <name> [columns...].');
   }
-  if (!/^[a-z_][a-z0-9_]*$/.test(name)) {
+  if (!NAME_RE.test(name)) {
     throw new Error(
       'gen: Model name must be lowercase alphanumeric with underscores and no leading digits.',
     );
@@ -94,7 +98,7 @@ function parseMigrationArgs(args: Array<string>): GenArgs {
   if (extra) {
     throw new Error(`gen: Unexpected argument '${extra}'.`);
   }
-  if (!/^[a-z_][a-z0-9_]*$/.test(name)) {
+  if (!NAME_RE.test(name)) {
     throw new Error(
       'gen: Migration name must be lowercase alphanumeric with underscores and no leading digits.',
     );
@@ -145,6 +149,11 @@ function parseMiddlewareArgs(args: Array<string>): GenArgs {
   if (extra) {
     throw new Error(`gen: Unexpected argument '${extra}'.`);
   }
+  if (!NAME_WITH_HYPHENS_RE.test(name)) {
+    throw new Error(
+      'gen: Middleware name must be lowercase alphanumeric with underscores or hyphens and no leading digits.',
+    );
+  }
   return { subcommand: 'middleware', name };
 }
 
@@ -181,7 +190,7 @@ function parseCronArgs(args: Array<string>): GenArgs {
   if (extra) {
     throw new Error(`gen: Unexpected argument '${extra}'.`);
   }
-  if (!/^[a-z_][a-z0-9_-]*$/.test(name)) {
+  if (!NAME_WITH_HYPHENS_RE.test(name)) {
     throw new Error(
       'gen: Cron name must be lowercase alphanumeric with underscores or hyphens and no leading digits.',
     );
@@ -197,7 +206,7 @@ function parseQueueArgs(args: Array<string>): GenArgs {
   if (extra) {
     throw new Error(`gen: Unexpected argument '${extra}'.`);
   }
-  if (!/^[a-z_][a-z0-9_-]*$/.test(name)) {
+  if (!NAME_WITH_HYPHENS_RE.test(name)) {
     throw new Error(
       'gen: Queue name must be lowercase alphanumeric with underscores or hyphens and no leading digits.',
     );

packages/void/src/cli/project-args.ts

@@ -38,6 +38,9 @@ export function parseProjectArgs(args: Array<string>): ProjectArgs {
 
   if (subcommand === 'status') {
     const [name, extra] = rest;
+    if (name?.startsWith('-')) {
+      throw new Error(`project: Unknown flag '${name}'.`);
+    }
     if (extra) {
       throw new Error(`project: Unexpected argument '${extra}'.`);
     }
@@ -46,6 +49,9 @@ export function parseProjectArgs(args: Array<string>): ProjectArgs {
 
   if (subcommand === 'link') {
     const [name, extra] = rest;
+    if (name?.startsWith('-')) {
+      throw new Error(`project: Unknown flag '${name}'.`);
+    }
     if (extra) {
       throw new Error(`project: Unexpected argument '${extra}'.`);
     }
@@ -88,6 +94,9 @@ export function parseProjectArgs(args: Array<string>): ProjectArgs {
 
   if (subcommand === 'rollback') {
     const [deployId, extra] = rest;
+    if (deployId?.startsWith('-')) {
+      throw new Error(`project: Unknown flag '${deployId}'.`);
+    }
     if (extra) {
       throw new Error(`project: Unexpected argument '${extra}'.`);
     }
@@ -96,6 +105,9 @@ export function parseProjectArgs(args: Array<string>): ProjectArgs {
 
   if (subcommand === 'cancel') {
     const [deployId, extra] = rest;
+    if (deployId?.startsWith('-')) {
+      throw new Error(`project: Unknown flag '${deployId}'.`);
+    }
     if (extra) {
       throw new Error(`project: Unexpected argument '${extra}'.`);
     }

packages/void/test/unit/domain-args.test.ts

@@ -0,0 +1,34 @@
+import { describe, expect, it } from 'vite-plus/test';
+import { parseDomainArgs } from '../../src/cli/domain-args.ts';
+
+describe('parseDomainArgs', () => {
+  it('parses a hostname positional', () => {
+    expect(parseDomainArgs(['add', 'example.com'])).toEqual({
+      subcommand: 'add',
+      hostname: 'example.com',
+      projectSlug: undefined,
+      verbose: false,
+    });
+  });
+
+  it('parses --project and --verbose', () => {
+    expect(parseDomainArgs(['status', 'example.com', '--project', 'my-app', '--verbose'])).toEqual({
+      subcommand: 'status',
+      hostname: 'example.com',
+      projectSlug: 'my-app',
+      verbose: true,
+    });
+  });
+
+  it('rejects an unknown flag instead of capturing it as the hostname', () => {
+    expect(() => parseDomainArgs(['add', '--foo', 'example.com'])).toThrow(
+      "domain: Unknown flag '--foo'.",
+    );
+  });
+
+  it('rejects an unknown flag even when a hostname is already present', () => {
+    expect(() => parseDomainArgs(['status', 'example.com', '--foo'])).toThrow(
+      "domain: Unknown flag '--foo'.",
+    );
+  });
+});

packages/void/test/unit/gen-args.test.ts

@@ -174,6 +174,19 @@ describe('parseGenArgs', () => {
         "gen: Unexpected argument 'extra'.",
       );
     });
+
+    it('rejects an invalid name (e.g. a flag) instead of scaffolding a bogus file', () => {
+      expect(() => parseGenArgs(['middleware', '--foo'])).toThrow(
+        'gen: Middleware name must be lowercase alphanumeric with underscores or hyphens and no leading digits.',
+      );
+    });
+
+    it('allows hyphenated middleware names', () => {
+      expect(parseGenArgs(['middleware', 'rate-limit'])).toEqual({
+        subcommand: 'middleware',
+        name: 'rate-limit',
+      });
+    });
   });
 
   describe('ssr', () => {

packages/void/test/unit/project-args.test.ts

@@ -101,4 +101,32 @@ describe('parseProjectArgs', () => {
       );
     });
   });
+
+  describe('unknown-flag rejection', () => {
+    // status/link/rollback/cancel previously captured a leading flag as the positional id.
+    it('rejects an unknown flag for status instead of capturing it as the name', () => {
+      expect(() => parseProjectArgs(['status', '--foo'])).toThrow("project: Unknown flag '--foo'.");
+    });
+
+    it('rejects an unknown flag for link', () => {
+      expect(() => parseProjectArgs(['link', '--foo'])).toThrow("project: Unknown flag '--foo'.");
+    });
+
+    it('rejects an unknown flag for rollback', () => {
+      expect(() => parseProjectArgs(['rollback', '--foo'])).toThrow(
+        "project: Unknown flag '--foo'.",
+      );
+    });
+
+    it('rejects an unknown flag for cancel', () => {
+      expect(() => parseProjectArgs(['cancel', '--foo'])).toThrow("project: Unknown flag '--foo'.");
+    });
+
+    it('still accepts a valid positional id', () => {
+      expect(parseProjectArgs(['status', 'my-app'])).toEqual({
+        subcommand: 'status',
+        name: 'my-app',
+      });
+    });
+  });
 });