Skip to content

Commit 67f5320

Browse files
committed
fix(ci): Build deployment packages before tests.
1 parent f3f838c commit 67f5320

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ jobs:
7979
- run: vp check
8080
if: ${{ matrix.shard == 'unit' }}
8181

82-
# Unit suites import the core package through its public `void/*` exports and exercise
83-
# generated CLI assets, so they need the core build even though they skip playground builds.
82+
# Unit suites import the deployment packages and the core package through public exports and
83+
# exercise generated CLI assets, so they need the core stack even though they skip playground builds.
8484
- run: vp run build:core
8585
if: ${{ matrix.shard == 'unit' }}
8686

@@ -132,7 +132,8 @@ jobs:
132132
run: |
133133
: "${VOID_E2E_CF_TOKEN:?empty — set it as a cloudflare-e2e environment secret}"
134134
: "${VOID_E2E_CF_ACCOUNT_ID:?empty — set it as a cloudflare-e2e environment secret}"
135-
# build:core produces dist/cli/cli.mjs + the built `void` plugin the deploy uses to build the app.
135+
# build:core produces the deployment packages, dist/cli/cli.mjs, and the built `void` plugin
136+
# the deploy uses to build the app.
136137
- run: vp run build:core
137138
- run: vp test run packages/void/test/e2e/cloudflare-deploy-live.test.ts
138139

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"type": "module",
44
"scripts": {
55
"build": "vp run --filter './packages/**' --parallel build",
6-
"build:core": "vp run --filter ./packages/void build",
6+
"build:core": "vp run --filter ./packages/deploy-core build && vp run --filter ./packages/deploy-cloudflare build && vp run --filter ./packages/void build",
77
"build:docs": "vp run --filter ./docs build",
88
"build:platform": "vp run --filter './platform/packages/**' build",
99
"check": "vp run -r --parallel typecheck",

0 commit comments

Comments
 (0)