Skip to content

Commit 49038ea

Browse files
committed
Fix CI.
1 parent 0578249 commit 49038ea

4 files changed

Lines changed: 18 additions & 8 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,11 @@ jobs:
7070
node-version-file: .node-version
7171
cache: true
7272

73-
- run: vp exec playwright install --with-deps chromium
74-
if: ${{ matrix.shard != 'unit' && !contains(matrix.os, 'windows') }}
75-
73+
# Both runner images already provide Chromium's shared-library dependencies. Avoid
74+
# `--with-deps` here: it runs apt on Linux and makes test startup depend on the external
75+
# Ubuntu mirrors even though no OS packages are needed by these runners.
7676
- run: vp exec playwright install chromium
77-
if: ${{ matrix.shard != 'unit' && contains(matrix.os, 'windows') }}
77+
if: ${{ matrix.shard != 'unit' }}
7878

7979
- run: vp check
8080
if: ${{ matrix.shard == 'unit' }}

‎packages/solid/test/integration/solid-pages-playground.test.ts‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -485,7 +485,13 @@ function registerIslandTests(getBase: () => string) {
485485
const page = await newPage();
486486
try {
487487
await page.goto(BASE + '/blog');
488-
await page.waitForSelector('[data-island][data-hydrated="true"]');
488+
await page.waitForFunction(() => {
489+
const islands = [...document.querySelectorAll('[data-island]')];
490+
return (
491+
islands.length >= 2 &&
492+
islands.every((island) => island.getAttribute('data-hydrated') === 'true')
493+
);
494+
});
489495

490496
const islands = await page.$$eval('[data-island]', (els) =>
491497
els.map((el) => ({

‎packages/void/test/unit/cloudflare-deploy.test.ts‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,14 @@ import { readConfig } from '../../src/config.ts';
4646

4747
const tmpDir = join(import.meta.dirname, '.tmp-cf-deploy-test');
4848

49+
function removeProjectFixture(): void {
50+
// Windows can briefly retain handles opened by the real env-schema probe subprocesses.
51+
rmSync(tmpDir, { recursive: true, force: true, maxRetries: 10, retryDelay: 100 });
52+
}
53+
4954
/** Write a project fixture: a map of relative path → file contents. */
5055
function makeProject(files: Record<string, string>): string {
51-
rmSync(tmpDir, { recursive: true, force: true });
56+
removeProjectFixture();
5257
mkdirSync(tmpDir, { recursive: true });
5358
for (const [rel, content] of Object.entries(files)) {
5459
const abs = join(tmpDir, rel);
@@ -59,7 +64,7 @@ function makeProject(files: Record<string, string>): string {
5964
}
6065

6166
afterEach(() => {
62-
rmSync(tmpDir, { recursive: true, force: true });
67+
removeProjectFixture();
6368
delete process.env.DATABASE_URL;
6469
});
6570

‎platform/package.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
"health": "node packages/api/scripts/health.ts",
2323
"health:staging": "node packages/api/scripts/health.ts --staging",
2424
"lint": "vp lint",
25-
"prepare": "vp config",
2625
"test": "vp test run"
2726
},
2827
"devDependencies": {

0 commit comments

Comments
 (0)