Repository navigation
Commit fefea2b
test(cache): emit the stalled milestone only when a test waits for it (#844)
## Motivation
`remote_cache::ctrl_c_during_upload` passed on #841 but timed out on
main in [`Test
(windows-ignored)`](https://github.com/voidzero-dev/vite-task/actions/runs/38217517719/job/114706317248),
waiting for the `uploads-pending` milestone.
On Windows a milestone is the console title, and ConPTY sends only the
latest title when it next renders. `vtt stalled-remote-cache` emits a
`stalled` milestone when the upload arrives, which can be just after `vt
run` emits `uploads-pending`. `stalled` then replaces it, and the
harness waits until the test times out. `fast_fail_during_upload` has
the same race, and it's why `pending_uploads` and `hide_pending_uploads`
timed out on Windows in #841's first CI run. Only `ctrl_c_during_fetch`
waits for `stalled`.
## Changes
- `vtt stalled-remote-cache` emits the `stalled` milestone only with the
new `--milestone` flag, which `ctrl_c_during_fetch` passes.
- `pending_uploads` and `hide_pending_uploads` run on Windows again.
#841 skipped `hide_pending_uploads` because nothing is printed after
`uploads-pending`, but ConPTY sends a title change without other output,
as `milestone_raw_mode_keystrokes` and `vtt exit-on-ctrlc` show.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>1 parent 4a0f130 commit fefea2b
3 files changed
Lines changed: 30 additions & 20 deletions
File tree
- crates/vt_bin
- src/vtt
- tests/e2e_snapshots/fixtures/remote_cache
- snapshots
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
28 | 38 | | |
29 | 39 | | |
30 | 40 | | |
31 | | - | |
| 41 | + | |
| 42 | + | |
32 | 43 | | |
33 | 44 | | |
34 | 45 | | |
| |||
41 | 52 | | |
42 | 53 | | |
43 | 54 | | |
| 55 | + | |
44 | 56 | | |
45 | 57 | | |
46 | 58 | | |
| |||
67 | 79 | | |
68 | 80 | | |
69 | 81 | | |
| 82 | + | |
| 83 | + | |
70 | 84 | | |
71 | 85 | | |
72 | 86 | | |
| |||
83 | 97 | | |
84 | 98 | | |
85 | 99 | | |
86 | | - | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
87 | 103 | | |
88 | 104 | | |
89 | 105 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
341 | 341 | | |
342 | 342 | | |
343 | 343 | | |
344 | | - | |
345 | | - | |
346 | | - | |
347 | | - | |
348 | 344 | | |
349 | 345 | | |
350 | 346 | | |
| |||
522 | 518 | | |
523 | 519 | | |
524 | 520 | | |
| 521 | + | |
525 | 522 | | |
526 | 523 | | |
527 | 524 | | |
| |||
615 | 612 | | |
616 | 613 | | |
617 | 614 | | |
618 | | - | |
619 | | - | |
620 | | - | |
621 | 615 | | |
622 | 616 | | |
623 | 617 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
0 commit comments