You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3e37fef
Browse filesBrowse the repository at this point in the historyBrowse files
fix(client): bypass interprocess linger pool on Drop (Windows)
The runner-aware addon's e2e fixtures (`ipc_client_test`,
`vite_build_cache`, `vite_dev_disable_cache`) all carry
`platform = "unix"` with the note that on Windows CI the Node child
aborts with `failed to start the persistent thread of the Interprocess
linger pool: Access is denied` when the napi addon tears down. The
panic comes from `interprocess::os::windows::named_pipe::stream::Drop`
handing dirty pipes to a lazily-spawned background thread that calls
`FlushFileBuffers` for graceful close. Windows CI containers refuse
the `CreateThread` from inside Node's worker-thread finalizer with
ACCESS_DENIED, the crate `expect`s on that path, and the panic kills
the child.
Add a `Drop` impl for `Client` that, on Windows, reaches into the
underlying `DuplexPipeStream` via `local_socket::Stream::NamedPipe(_)`
and calls `assume_flushed()` so the inner stream's `Drop` skips the
limbo detour. The IPC is strictly request/response, so once we have
read each response the server has already consumed every byte we sent
— there is nothing to flush at close time anyway.
The fix unblocks Windows CI for every test that goes through the
addon. Drop `platform = "unix"` from all nine `[[e2e]]` cases that
were gated on the bug; they remain `ignore = true` because they still
need a pnpm-populated `node_modules` to run.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: crates/vite_task_bin/tests/e2e_snapshots/fixtures/vite_build_cache/snapshots.toml
-12Lines changed: 0 additions & 12 deletions
Original file line number
Diff line number
Diff line change
@@ -3,10 +3,6 @@ name = "vite_build_caches_and_restores_outputs"
3
3
comment = """
4
4
`vt run --cache build` must produce a cache hit on the second run without any manual input/output configuration. Vite reports `ignoreInput(outDir)` + `ignoreInput/Output(cacheDir)` via `@voidzero-dev/vite-task-client`, so fspy-detected reads of `dist/` and writes to `node_modules/.vite/` don't poison the cache.
5
5
"""
6
-
# Unix-only for now: on Windows CI, interprocess 2.4 aborts the child
7
-
# with "failed to start the persistent thread of the Interprocess linger
8
-
# pool: Access is denied" when the Node addon tries to connect.
9
-
platform = "unix"
10
6
ignore = true
11
7
steps = [
12
8
{ argv = [
@@ -43,10 +39,6 @@ name = "vite_prefix_env_change_invalidates_cache"
43
39
comment = """
44
40
`VITE_MODE` is picked up by Vite's patched `loadEnv`, which asks the runner for every `VITE_*` env via `getEnvs(pattern, { tracked: true })`. Flipping its value between runs must invalidate the cache AND change the build output — Vite's `define` plugin substitutes `import.meta.env.VITE_MODE` at build time, so dead-code elimination leaves only the branch matching the value.
45
41
"""
46
-
# Unix-only for now: on Windows CI, interprocess 2.4 aborts the child
47
-
# with "failed to start the persistent thread of the Interprocess linger
48
-
# pool: Access is denied" when the Node addon tries to connect.
49
-
platform = "unix"
50
42
ignore = true
51
43
steps = [
52
44
{ argv = [
@@ -113,10 +105,6 @@ name = "vite_node_env_change_invalidates_cache"
113
105
comment = """
114
106
`NODE_ENV` enters the build's cache fingerprint via Vite's `getEnv('NODE_ENV')` call in `resolveConfig`. Same value → cache hit; different value → cache miss with `tracked env 'NODE_ENV' changed`.
115
107
"""
116
-
# Unix-only for now: on Windows CI, interprocess 2.4 aborts the child
117
-
# with "failed to start the persistent thread of the Interprocess linger
118
-
# pool: Access is denied" when the Node addon tries to connect.
Copy file name to clipboardExpand all lines: crates/vite_task_bin/tests/e2e_snapshots/fixtures/vite_dev_disable_cache/snapshots.toml
-4Lines changed: 0 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -3,10 +3,6 @@ name = "vite_dev_disables_cache"
3
3
comment = """
4
4
`vt run --cache dev` brings up a Vite dev server programmatically on an ephemeral port and closes it immediately. Vite's `_createServer` calls `disableCache()` via `@voidzero-dev/vite-task-client`, so this run is never stored — the next invocation re-executes (cache miss / NotFound).
5
5
"""
6
-
# Unix-only for now: on Windows CI, interprocess 2.4 aborts the child
7
-
# with "failed to start the persistent thread of the Interprocess linger
8
-
# pool: Access is denied" when the Node addon tries to connect.
0 commit comments