Skip to content

Commit 3c1cbe3

Browse files
voidstackloopclaude
andcommitted
fix(ci): build the native addon before running the e2e suite
3 of the e2e job's specs (audit-sqlite-backend-toggle, audit-sqlite- custom-directory, audit-backend-toggle-failure) were failing on 'expect(toggle).toBeEnabled() -- Received: disabled' -- exactly the documented behavior when app/native isn't present (see audit-sqlite-backend-toggle.spec.ts's own comment), because the e2e job never built it. The separate rust job does build this addon, but on its own runner with no shared filesystem with e2e -- nothing carries that build over. Reproduced locally by removing app/native and confirming the exact same failure, then fixed by adding a 'Build native addon (napi, debug)' step (npm ci + npm run build:debug in lib/) before installing e2e's own dependencies. All 25 e2e specs pass after rebuilding the addon. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent b2abf99 commit 3c1cbe3

1 file changed

Lines changed: 14 additions & 0 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,7 @@ jobs:
266266
packages/contracts/package-lock.json
267267
frontend/package-lock.json
268268
app/package-lock.json
269+
lib/package-lock.json
269270
e2e/package-lock.json
270271
271272
# frontend/'s own build has no prebuild hook that would do this for it
@@ -282,6 +283,19 @@ jobs:
282283
working-directory: app
283284
run: npm ci
284285

286+
# Several specs (audit-sqlite-*.spec.ts, audit-backend-toggle-
287+
# failure.spec.ts) exercise the Settings UI's SQLite audit-backend
288+
# toggle, which stays disabled — by design, see
289+
# audit-sqlite-backend-toggle.spec.ts's own comment — whenever
290+
# app/native isn't present. The separate `rust` job below builds this
291+
# addon too, but on its own runner with no shared filesystem, so this
292+
# job needs its own debug build (faster than --release; sufficient
293+
# for tests) or those specs fail with "toggle stayed disabled" every
294+
# time, not a rust/napi problem of their own.
295+
- name: Build native addon (napi, debug)
296+
working-directory: lib
297+
run: npm ci && npm run build:debug
298+
285299
- name: Install e2e dependencies
286300
working-directory: e2e
287301
run: npm ci

0 commit comments

Comments
 (0)