From 5cd9a3b0475c145fb32788a960917f43e8c47984 Mon Sep 17 00:00:00 2001 From: Ilia Alshanetsky Date: Wed, 24 Jun 2026 16:35:25 -0400 Subject: [PATCH] soap: do not overwrite the parsed host on a protocol-relative redirect (#22431) When a redirect Location is a protocol-relative reference (//host/path), the URI parser already fills new_uri->host, but the scheme-less redirect handling overwrote it with a copy of the request host without releasing the parsed one. That leaks a zend_string per such redirect and pins the redirect back to the original host instead of the one the server named. Inherit host and port from the request URI only when new_uri->host is NULL, mirroring the scheme guard directly above. --- ext/soap/php_http.c | 6 ++- .../bugs/protocol_relative_redirect.phpt | 49 +++++++++++++++++++ 2 files changed, 53 insertions(+), 2 deletions(-) create mode 100644 ext/soap/tests/bugs/protocol_relative_redirect.phpt diff --git a/ext/soap/php_http.c b/ext/soap/php_http.c index 02874c5c7584..1f0aa6723c76 100644 --- a/ext/soap/php_http.c +++ b/ext/soap/php_http.c @@ -1159,8 +1159,10 @@ int make_http_soap_request( zend_string_release_ex(http_body, 0); if (new_uri->scheme == NULL && new_uri->path != NULL) { new_uri->scheme = uri->scheme ? zend_string_copy(uri->scheme) : NULL; - new_uri->host = uri->host ? zend_string_copy(uri->host) : NULL; - new_uri->port = uri->port; + if (new_uri->host == NULL) { + new_uri->host = uri->host ? zend_string_copy(uri->host) : NULL; + new_uri->port = uri->port; + } if (new_uri->path && ZSTR_VAL(new_uri->path)[0] != '/') { if (uri->path) { char *t = ZSTR_VAL(uri->path); diff --git a/ext/soap/tests/bugs/protocol_relative_redirect.phpt b/ext/soap/tests/bugs/protocol_relative_redirect.phpt new file mode 100644 index 000000000000..e8f30ca66872 --- /dev/null +++ b/ext/soap/tests/bugs/protocol_relative_redirect.phpt @@ -0,0 +1,49 @@ +--TEST-- +SOAP client follows a protocol-relative (//host/path) redirect Location without leaking the host +--EXTENSIONS-- +soap +--SKIPIF-- + +--FILE-- +', + '', + 'ok', + ''; +} else { + http_response_code(302); + header("Location: //" . $_SERVER["HTTP_HOST"] . "/redirected"); +} +PHP; + +php_cli_server_start($code, null, $args); + +$client = new SoapClient(null, [ + 'location' => 'http://' . PHP_CLI_SERVER_ADDRESS . '/start', + 'uri' => 'test-uri', +]); + +try { + $client->__soapCall("foo", []); + echo "redirect followed\n"; +} catch (SoapFault $e) { + echo "SoapFault: " . $e->getMessage() . "\n"; +} +?> +--EXPECT-- +redirect followed