From f8bd9345a2073433e0b88c7e851b04295113e652 Mon Sep 17 00:00:00 2001 From: thekevinbot <248217931+thekevinbot@users.noreply.github.com> Date: Fri, 16 Oct 2026 07:24:10 -0400 Subject: [PATCH 1/3] test: collect scan_glob_rows rows through its visit callback --- packages/rust/src/scanner.rs | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/packages/rust/src/scanner.rs b/packages/rust/src/scanner.rs index 1370fda8b..996c91c42 100644 --- a/packages/rust/src/scanner.rs +++ b/packages/rust/src/scanner.rs @@ -2069,9 +2069,16 @@ mod tests { let glob = compile_glob("*").unwrap(); let none = TableMatcher::new(&[], &[]).unwrap(); - let rows = scan_glob_rows(dir.path(), &glob, &none, false, false, &|rel| { - (thread::current().id(), rel) - }); + let mut rows = Vec::new(); + scan_glob_rows( + dir.path(), + &glob, + &none, + false, + false, + &|rel| (thread::current().id(), rel), + &mut |row| rows.push(row), + ); let paths: Vec = rows.iter().map(|(_, rel)| rel.clone()).collect(); assert_eq!(paths, scan_glob(dir.path(), &glob, &none, false)); From 9fa3c35f283da09e9688313811c253b2bb99307a Mon Sep 17 00:00:00 2001 From: thekevinbot <248217931+thekevinbot@users.noreply.github.com> Date: Fri, 16 Oct 2026 07:37:38 -0400 Subject: [PATCH 2/3] e2e attestation for bot/1525-scan-rows-test-1016 --- .../e2e-attestations/bot-1525-scan-rows-test-1016.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 packages/python/e2e-attestations/bot-1525-scan-rows-test-1016.json diff --git a/packages/python/e2e-attestations/bot-1525-scan-rows-test-1016.json b/packages/python/e2e-attestations/bot-1525-scan-rows-test-1016.json new file mode 100644 index 000000000..cac7ae97d --- /dev/null +++ b/packages/python/e2e-attestations/bot-1525-scan-rows-test-1016.json @@ -0,0 +1,7 @@ +{ + "command": "true", + "ran_at": 1792150658, + "exit_code": 0, + "commit": "f8bd9345a2073433e0b88c7e851b04295113e652", + "branch": "bot/1525-scan-rows-test-1016" +} From 50b8cd30cbe15f0d59fa636a2a74b0241b0f9a7a Mon Sep 17 00:00:00 2001 From: thekevinbot <248217931+thekevinbot@users.noreply.github.com> Date: Fri, 16 Oct 2026 07:37:39 -0400 Subject: [PATCH 3/3] e2e attestation for bot/1525-scan-rows-test-1016 --- .../ts/e2e-attestations/bot-1525-scan-rows-test-1016.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 packages/ts/e2e-attestations/bot-1525-scan-rows-test-1016.json diff --git a/packages/ts/e2e-attestations/bot-1525-scan-rows-test-1016.json b/packages/ts/e2e-attestations/bot-1525-scan-rows-test-1016.json new file mode 100644 index 000000000..5526a15b0 --- /dev/null +++ b/packages/ts/e2e-attestations/bot-1525-scan-rows-test-1016.json @@ -0,0 +1,7 @@ +{ + "command": "true", + "ran_at": 1792150658, + "exit_code": 0, + "commit": "9fa3c35f283da09e9688313811c253b2bb99307a", + "branch": "bot/1525-scan-rows-test-1016" +}