From 52c23027a527902ba9f487ff833abc6cf9fe762f Mon Sep 17 00:00:00 2001 From: thedancingdeveloper <306930456+thedancingdeveloper@users.noreply.github.com> Date: Wed, 14 Oct 2026 09:20:41 +0000 Subject: [PATCH] Record that fluent-ribbon ports to the vendored gpui with no changes WI-1427. Every gpui symbol the crate uses is in the drift report's unchanged set, and cargo check, test and clippy --no-deps -D warnings pass with no edits, so the public API is untouched. --- docs/gpui-api-drift.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/gpui-api-drift.md b/docs/gpui-api-drift.md index fba297d..d5c2d10 100644 --- a/docs/gpui-api-drift.md +++ b/docs/gpui-api-drift.md @@ -155,3 +155,4 @@ signature diff. The rows known to matter are called out under "Notes". |---|---|---| | `fluent-core` | WI-1425 | No source change. Every symbol it imports is in "unchanged" above, and `cargo check`, `cargo test` (22 unit tests) and `cargo clippy --no-deps -D warnings` pass against `vendor/zed` with the public API untouched. | | `fluent-primitives` | WI-1426 | Compiles, 27 unit tests pass, `cargo clippy --all-targets --no-deps -D warnings` is clean. The location check above missed five signature changes, all forced by the vendored gpui and each a mechanical adaptation: `Window::focus`, `focus_next` and `focus_prev` now take `&mut App`; `ShapedLine::paint` takes a `TextAlign` and an optional align width (passed `Left` and `None`, the previous implicit behaviour); `Styled::text_style()` returns the refinement directly instead of an `Option`; `ElementId::NamedChild` holds an `Arc` instead of a `Box`; and `Corner` is gone, replaced by `gpui::Anchor`. The crate re-exports its own four-variant `Corner` that converts into `Anchor`, so the popover anchor API the later crates use does not change. | +| `fluent-ribbon` | WI-1427 | No source change. Every gpui symbol it uses (`App`, `AnyElement`, `ClickEvent`, `Context`, `FontWeight`, `IntoElement`, `Render`, `SharedString`, `Window`, `div`, `prelude`, `px`, `svg`) is in "unchanged" above, and `cargo check`, `cargo test` (no unit tests; one ignored doc-test) and `cargo clippy --all-targets --no-deps -D warnings` pass against `vendor/zed` with the public API untouched. |