Skip to content

Commit 7c43329

Browse files
Address code-reviewer findings on CHANGELOG shortening
- Entry 2: restore the "server does not echo WIF attributes on GET today" caveat. Without it a round-trip write-then-read silently returns None, with no error signal to tell the caller why. - Entry 1: distinguish "WIF feature not available on the site" (403 across the board) from "admin has not yet called enable()" (config/connector operations return 404; get() returns a shell). Prior wording collapsed both into "WIF is not enabled" which conflicts with the enable() method name. - Entry 1: restore the NO_ACCESS caveat for key-management methods (connected-app JWT sessions return 401; use a PAT or password session for key rotation). - Standardize "available / enabled" wording across both entries. Entries now land at 14 lines each — still within the house range (urllib3 / redirects / CSVImport neighbors run 6–9 lines). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 6941512 commit 7c43329

1 file changed

Lines changed: 13 additions & 7 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,13 @@
88
delete). Three new exports: `AuthFederationItem`,
99
`AuthFederationConnectorItem`, `AuthFederationKeyItem`. All id-taking
1010
methods reject non-UUID targets client-side (raising `ValueError`) to
11-
prevent path injection. Requires Tableau Server REST API 3.30+ (Tableau
12-
Server 2026.3) and Site Administrator on the current site; the server
13-
returns 403 if WIF is not enabled on the site or the caller is not an
14-
admin (including on `get()`).
11+
prevent path injection. Key management rejects connected-app JWT
12+
sessions with 401; use a PAT or password session. Requires Tableau
13+
Server REST API 3.30+ (Tableau Server 2026.3), the WIF feature available
14+
on the site, and the Site Administrator role; the server returns 403
15+
if WIF is not available or the caller is not an admin (including on
16+
`get()`), and config/connector operations return 404 until `enable()`
17+
has run.
1518
* Added Workload Identity Federation (WIF) support to the connection update
1619
endpoints. `ConnectionItem` has two new string properties,
1720
`workgroup_auth_mode` and `auth_federation_service_account`, emitted on
@@ -21,9 +24,12 @@
2124
e.g. Snowflake) or `WIF_IMPERSONATION` (e.g. BigQuery);
2225
`auth_federation_service_account` is only valid with the impersonation
2326
mode. Omitting `workgroup_auth_mode` on a subsequent update of a WIF
24-
connection returns HTTP 400. Requires Tableau Server REST API 3.30+
25-
(Tableau Server 2026.3) with WIF configured on the site; older servers
26-
silently ignore unknown connection attributes.
27+
connection returns HTTP 400. The server does not echo these attributes
28+
on GET today, so values parsed from a response are typically `None`
29+
even on a WIF-configured connection. Requires Tableau Server REST API
30+
3.30+ (Tableau Server 2026.3) with the WIF feature available and
31+
enabled on the site; older servers silently ignore unknown connection
32+
attributes.
2733
* Bumped the urllib3 floor to 2.6.3 to pick up the fix for CVE-2026-21441
2834
(GHSA-38jv-5279-wg99, 8.9 High): urllib3's streaming decompression
2935
safeguards were bypassed when HTTP redirects were followed. TSC's manual

0 commit comments

Comments
 (0)