From 2748a857ff8965d8fe4c7b2b8538955f99817b8c Mon Sep 17 00:00:00 2001 From: Evan Wilde Date: Thu, 12 Nov 2026 13:49:10 -0800 Subject: [PATCH] Windows CMake Testing: Use Ninja It looks like CMake changed defaults from MSVC to NMake, which is failing in the workflow testing. Switching it to using Ninja like the other platforms. Ninja is pre-installed on the Windows 11 images, NMake is not. --- .github/workflows/pull_request.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index e1d9fccf..314370cd 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -286,8 +286,7 @@ jobs: # Linux uses the default Ninja generator; install Ninja first. linux_pre_build_command: "apt-get install -y ninja-build" linux_configure_command: "$CMAKE -G Ninja -B build -S tests/CMakeProject" - # Windows uses CMake's default generator (MSVC), so Ninja is not required. - windows_configure_command: "Invoke-Program cmake -B build -S tests/CMakeProject" + windows_configure_command: "Invoke-Program cmake -G Ninja -B build -S tests/CMakeProject" soundness-docs: name: "Soundness - Docs (override_target_name: ${{ matrix.override_target_name }} ; post command: ${{ matrix.post_command }})"