From 135d6e39d871210137b70d9d9ba1b038693baca3 Mon Sep 17 00:00:00 2001 From: ntsirintanis Date: Wed, 9 Mar 2022 15:10:19 +0100 Subject: [PATCH 01/10] [10.0][ADD] backport of report_async from Odoo 12 --- report_async/__manifest__.py | 40 +++--- report_async/models/ir_report.py | 23 ++- report_async/models/report_async.py | 160 ++++++++++----------- report_async/tests/test_report_async.py | 37 ++--- report_async/views/report_async.xml | 1 - report_async/wizard/print_report_wizard.py | 37 ++--- 6 files changed, 146 insertions(+), 152 deletions(-) diff --git a/report_async/__manifest__.py b/report_async/__manifest__.py index 74a9be855a..508c59b677 100644 --- a/report_async/__manifest__.py +++ b/report_async/__manifest__.py @@ -1,27 +1,23 @@ # Copyright 2019 Ecosoft Co., Ltd (http://ecosoft.co.th/) # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html) { - 'name': 'Report Async', - 'summary': 'Central place to run reports live or async', - 'version': '12.0.1.0.1', - 'author': 'Ecosoft, Odoo Community Association (OCA)', - 'license': 'AGPL-3', - 'website': 'https://github.com/OCA/reporting-engine', - 'category': 'Generic Modules', - 'depends': [ - 'queue_job', + "name": "Report Async", + "summary": "Central place to run reports live or async", + "version": "10.0.1.0.0", + "author": "Ecosoft, Odoo Community Association (OCA)", + "license": "AGPL-3", + "website": "https://github.com/OCA/reporting-engine", + "category": "Generic Modules", + "depends": ["queue_job"], + "data": [ + "security/ir.model.access.csv", + "security/ir_rule.xml", + "data/mail_template.xml", + "views/report_async.xml", + "wizard/print_report_wizard.xml", ], - 'data': [ - 'security/ir.model.access.csv', - 'security/ir_rule.xml', - 'data/mail_template.xml', - 'views/report_async.xml', - 'wizard/print_report_wizard.xml', - ], - 'demo': [ - 'demo/report_async_demo.xml', - ], - 'installable': True, - 'maintainers': ['kittiu'], - 'development_status': 'Beta', + "demo": ["demo/report_async_demo.xml"], + "installable": True, + "maintainers": ["kittiu"], + "development_status": "Beta", } diff --git a/report_async/models/ir_report.py b/report_async/models/ir_report.py index e70988bdd8..5d0fb5f132 100644 --- a/report_async/models/ir_report.py +++ b/report_async/models/ir_report.py @@ -5,24 +5,21 @@ # Define all supported report_type -REPORT_TYPES = ['qweb-pdf', 'qweb-text', - 'qweb-xml', 'csv', - 'excel', 'xlsx'] +REPORT_TYPES = ["qweb-pdf", "qweb-html"] class Report(models.Model): - _inherit = 'ir.actions.report' + _inherit = "report" @api.noguess - def report_action(self, docids, data=None, config=True): - res = super(Report, self).report_action(docids, data=data, - config=config) - if res['context'].get('async_process', False): - rpt_async_id = res['context']['active_id'] - report_async = self.env['report.async'].browse(rpt_async_id) - if res['report_type'] in REPORT_TYPES: + def get_action(self, docids, report_name, data=None): + res = super(Report, self).get_action(docids, report_name, data=data) + if res["context"].get("async_process", False): + rpt_async_id = res["context"]["active_id"] + report_async = self.env["report.async"].browse(rpt_async_id) + if res["report_type"] in REPORT_TYPES: report_async.with_delay().run_report( - res['context'].get('active_ids', []), data, - self.id, self._uid) + res["context"].get("active_ids", []), data, self.id, self._uid + ) return {} return res diff --git a/report_async/models/report_async.py b/report_async/models/report_async.py index 376acc71c2..11aa5f59db 100644 --- a/report_async/models/report_async.py +++ b/report_async/models/report_async.py @@ -8,87 +8,80 @@ from odoo.addons.queue_job.job import job -# Define all supported report_type -REPORT_TYPES_FUNC = {'qweb-pdf': 'render_qweb_pdf', - 'qweb-text': 'render_qweb_text', - 'qweb-xml': 'render_qweb_xml', - 'csv': 'render_csv', - 'excel': 'render_excel', - 'xlsx': 'render_xlsx', } - - class ReportAsync(models.Model): - _name = 'report.async' - _description = 'Report Async' + _name = "report.async" + _description = "Report Async" action_id = fields.Many2one( - comodel_name='ir.actions.act_window', - string='Reports', - required=True, + comodel_name="ir.actions.act_window", string="Reports", required=True ) allow_async = fields.Boolean( - string='Allow Async', + string="Allow Async", default=False, help="This is not automatic field, please check if you want to allow " "this report in background process", ) - name = fields.Char( - string='Name', - related='action_id.display_name', - ) + name = fields.Char(string="Name", related="action_id.display_name") email_notify = fields.Boolean( - string='Email Notification', + string="Email Notification", help="Send email with link to report, when it is ready", ) group_ids = fields.Many2many( - string='Groups', - comodel_name='res.groups', + string="Groups", + comodel_name="res.groups", help="Only user in selected groups can use this report." "If left blank, everyone can use", ) job_ids = fields.Many2many( - comodel_name='queue.job', - compute='_compute_job', + comodel_name="queue.job", + compute="_compute_job", help="List all jobs related to this running report", ) job_status = fields.Selection( - selection=[('pending', 'Pending'), - ('enqueued', 'Enqueued'), - ('started', 'Started'), - ('done', 'Done'), - ('failed', 'Failed')], - compute='_compute_job', + selection=[ + ("pending", "Pending"), + ("enqueued", "Enqueued"), + ("started", "Started"), + ("done", "Done"), + ("failed", "Failed"), + ], + compute="_compute_job", help="Latest Job Status", ) - job_info = fields.Text( - compute='_compute_job', - help="Latest Job Error Message", - ) + job_info = fields.Text(compute="_compute_job", help="Latest Job Error Message") file_ids = fields.Many2many( - comodel_name='ir.attachment', - compute='_compute_file', + comodel_name="ir.attachment", + compute="_compute_file", help="List all files created by this report background process", ) @api.multi def _compute_job(self): for rec in self: - rec.job_ids = self.sudo().env['queue.job'].search( - [('func_string', 'like', 'report.async(%s,)' % rec.id), - ('user_id', '=', self._uid)], - order='id desc') - rec.job_status = (rec.job_ids[0].sudo().state - if rec.job_ids else False) - rec.job_info = (rec.job_ids[0].sudo().exc_info - if rec.job_ids else False) + rec.job_ids = ( + self.sudo() + .env["queue.job"] + .search( + [ + ("func_string", "like", "report.async(%s,)" % rec.id), + ("user_id", "=", self._uid), + ], + order="id desc", + ) + ) + rec.job_status = rec.job_ids[0].sudo().state if rec.job_ids else False + rec.job_info = rec.job_ids[0].sudo().exc_info if rec.job_ids else False @api.multi def _compute_file(self): - files = self.env['ir.attachment'].search( - [('res_model', '=', 'report.async'), - ('res_id', 'in', self.ids), - ('create_uid', '=', self._uid)], - order='id desc') + files = self.env["ir.attachment"].search( + [ + ("res_model", "=", "report.async"), + ("res_id", "in", self.ids), + ("create_uid", "=", self._uid), + ], + order="id desc", + ) for rec in self: rec.file_ids = files.filtered(lambda l: l.res_id == rec.id) @@ -96,67 +89,74 @@ def run_now(self): self.ensure_one() action = self.env.ref(self.action_id.xml_id) result = action.read()[0] - ctx = safe_eval(result.get('context', {})) - ctx.update({'async_process': False}) - result['context'] = ctx + ctx = safe_eval(result.get("context", {})) + ctx.update({"async_process": False}) + result["context"] = ctx return result @api.multi def run_async(self): self.ensure_one() if not self.allow_async: - raise UserError(_('Background process not allowed.')) + raise UserError(_("Background process not allowed.")) action = self.env.ref(self.action_id.xml_id) result = action.read()[0] - ctx = safe_eval(result.get('context', {})) - ctx.update({'async_process': True}) - result['context'] = ctx + ctx = safe_eval(result.get("context", {})) + ctx.update({"async_process": True}) + result["context"] = ctx return result @api.multi def view_files(self): self.ensure_one() - action = self.env.ref('report_async.action_view_files') + action = self.env.ref("report_async.action_view_files") result = action.read()[0] - result['domain'] = [('id', 'in', self.file_ids.ids)] + result["domain"] = [("id", "in", self.file_ids.ids)] return result @api.multi def view_jobs(self): self.ensure_one() - action = self.env.ref('queue_job.action_queue_job') + action = self.env.ref("queue_job.action_queue_job") result = action.read()[0] - result['domain'] = [('id', 'in', self.job_ids.ids)] - result['context'] = {} + result["domain"] = [("id", "in", self.job_ids.ids)] + result["context"] = {} return result @api.model @job def run_report(self, docids, data, report_id, user_id): - report = self.env['ir.actions.report'].browse(report_id) - func = REPORT_TYPES_FUNC[report.report_type] - # Run report - out_file, file_ext = getattr(report, func)(docids, data) + report = self.env["ir.actions.report.xml"].browse(report_id) + # Render report + out_file = self.env["report"].render(report.report_name) out_file = base64.b64encode(out_file) - out_name = '%s.%s' % (report.name, file_ext) + file_ext = report.report_type.replace("qweb-", "") + out_name = "%s.%s" % (report.name, file_ext) # Save report to attachment - attachment = self.env['ir.attachment'].sudo().create({ - 'name': out_name, - 'datas': out_file, - 'datas_fname': out_name, - 'type': 'binary', - 'res_model': 'report.async', - 'res_id': self.id, - }) - self._cr.execute(""" + attachment = ( + self.env["ir.attachment"] + .sudo() + .create( + { + "name": out_name, + "datas": out_file, + "datas_fname": out_name, + "type": "binary", + "res_model": "report.async", + "res_id": self.id, + } + ) + ) + self._cr.execute( + """ UPDATE ir_attachment SET create_uid = %s, write_uid = %s - WHERE id = %s""", (self._uid, self._uid, attachment.id)) + WHERE id = %s""", + (self._uid, self._uid, attachment.id), + ) # Send email if self.email_notify: self._send_email(attachment) def _send_email(self, attachment): - template = self.env.ref('report_async.async_report_delivery') - template.send_mail(attachment.id, - notif_layout='mail.mail_notification_light', - force_send=False) + template = self.env.ref("report_async.async_report_delivery") + template.send_mail(attachment.id, force_send=False) diff --git a/report_async/tests/test_report_async.py b/report_async/tests/test_report_async.py index b921534a27..9e0289abf9 100644 --- a/report_async/tests/test_report_async.py +++ b/report_async/tests/test_report_async.py @@ -1,47 +1,48 @@ # Copyright 2019 Ecosoft Co., Ltd (http://ecosoft.co.th/) # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html) from odoo.tests import common -from odoo.tests.common import Form from odoo.exceptions import UserError class TestJobChannel(common.TransactionCase): - def setUp(self): super(TestJobChannel, self).setUp() - self.print_doc = self.env.ref('report_async.' - 'report_async_print_document') - self.test_rec = self.env.ref('base.module_mail') - self.test_rpt = self.env.ref('base.ir_module_reference_print') + self.print_doc = self.env.ref("report_async." "report_async_print_document") + self.test_rec = self.env.ref("base.module_mail") + self.test_rpt = self.env.ref("base.ir_module_reference_print") def _print_wizard(self, res): - obj = self.env[res['res_model']] - ctx = {'active_model': self.print_doc._name, - 'active_id': self.print_doc.id, } - ctx.update(res['context']) - with Form(obj.with_context(ctx)) as form: - form.reference = '%s,%s' % (self.test_rec._name, self.test_rec.id) - form.action_report_id = self.test_rpt - print_wizard = form.save() + obj = self.env[res["res_model"]] + ctx = {"active_model": self.print_doc._name, "active_id": self.print_doc.id} + ctx.update(res["context"]) + print_wizard = ( + self.env["print.report.wizard"] + .with_context(ctx) + .create( + { + "reference": "%s,%s" % (self.test_rec._name, self.test_rec.id), + "action_report_id": self.test_rpt.id, + } + ) + ) return print_wizard def test_1_run_now(self): """Run now will return report action as normal""" res = self.print_doc.run_now() report_action = self._print_wizard(res).print_report() - self.assertEquals(report_action['type'], 'ir.actions.report') + self.assertEquals(report_action["type"], "ir.actions.report.xml") def test_2_run_async(self): """Run background will return nothing, job started""" with self.assertRaises(UserError): self.print_doc.run_async() - self.print_doc.write({'allow_async': True, - 'email_notify': True}) + self.print_doc.write({"allow_async": True, "email_notify": True}) res = self.print_doc.run_async() print_wizard = self._print_wizard(res) report_action = print_wizard.print_report() self.assertEquals(report_action, {}) # Do not run report yet - self.assertEquals(self.print_doc.job_status, 'pending') # Job started + self.assertEquals(self.print_doc.job_status, "pending") # Job started # Test produce file (as queue will not run in test mode) docids = [print_wizard.reference.id] data = None diff --git a/report_async/views/report_async.xml b/report_async/views/report_async.xml index f6d5f58f14..68d1f08d78 100644 --- a/report_async/views/report_async.xml +++ b/report_async/views/report_async.xml @@ -109,7 +109,6 @@ diff --git a/report_async/wizard/print_report_wizard.py b/report_async/wizard/print_report_wizard.py index 4b4265f220..10ebb4320d 100644 --- a/report_async/wizard/print_report_wizard.py +++ b/report_async/wizard/print_report_wizard.py @@ -5,39 +5,40 @@ class PrintReportWizard(models.TransientModel): - _name = 'print.report.wizard' - _description = 'Print Report Wizard' + _name = "print.report.wizard" + _description = "Print Report Wizard" reference = fields.Reference( - string='Document', - selection='_reference_models', - required=True, + string="Document", selection="_reference_models", required=True ) action_report_id = fields.Many2one( - comodel_name='ir.actions.report', - string='Report Template', - required=True, + comodel_name="ir.actions.report.xml", string="Report Template", required=True ) @api.model def _reference_models(self): - excludes = ['res.company'] - models = self.env['ir.model'].search([ - ('state', '!=', 'manual'), ('transient', '=', False), - ('model', 'not in', excludes)]) + excludes = ["res.company"] + models = self.env["ir.model"].search( + [ + ("state", "!=", "manual"), + ("transient", "=", False), + ("model", "not in", excludes), + ] + ) return [(model.model, model.name) for model in models] - @api.onchange('reference') + @api.onchange("reference") def _onchange_reference(self): self.ensure_one() - domain = [('id', 'in', [])] + domain = [("id", "in", [])] self.action_report_id = False if self.reference: - domain = [('model', '=', self.reference._name)] - return {'domain': {'action_report_id': domain}} + domain = [("model", "=", self.reference._name)] + return {"domain": {"action_report_id": domain}} @api.multi def print_report(self): self.ensure_one() - return self.action_report_id.report_action(self.reference, - config=False) + return self.env["report"].get_action( + self.reference, self.action_report_id.report_name + ) From 83f4b883f9cc69592cf54838d067e22fd4daeb6a Mon Sep 17 00:00:00 2001 From: Tom Blauwendraat Date: Thu, 10 Mar 2022 15:52:32 +0100 Subject: [PATCH 02/10] [UPD] Add a way to print reports async always --- report_async/__manifest__.py | 2 + report_async/models/__init__.py | 3 +- report_async/models/ir_actions_report_xml.py | 30 ++++++++++++ report_async/models/report_async.py | 10 ++++ .../static/src/js/qweb_action_manager.js | 48 +++++++++++++++++++ report_async/views/assets.xml | 9 ++++ report_async/views/ir_actions_report_xml.xml | 15 ++++++ 7 files changed, 116 insertions(+), 1 deletion(-) create mode 100644 report_async/models/ir_actions_report_xml.py create mode 100644 report_async/static/src/js/qweb_action_manager.js create mode 100644 report_async/views/assets.xml create mode 100644 report_async/views/ir_actions_report_xml.xml diff --git a/report_async/__manifest__.py b/report_async/__manifest__.py index 508c59b677..c27e3aeabb 100644 --- a/report_async/__manifest__.py +++ b/report_async/__manifest__.py @@ -13,6 +13,8 @@ "security/ir.model.access.csv", "security/ir_rule.xml", "data/mail_template.xml", + "views/assets.xml", + "views/ir_actions_report_xml.xml", "views/report_async.xml", "wizard/print_report_wizard.xml", ], diff --git a/report_async/models/__init__.py b/report_async/models/__init__.py index 2e6988867b..20b5e3a605 100644 --- a/report_async/models/__init__.py +++ b/report_async/models/__init__.py @@ -1,5 +1,6 @@ # Copyright 2019 Ecosoft Co., Ltd (http://ecosoft.co.th/) # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html) -from . import report_async +from . import ir_actions_report_xml from . import ir_report +from . import report_async diff --git a/report_async/models/ir_actions_report_xml.py b/report_async/models/ir_actions_report_xml.py new file mode 100644 index 0000000000..00de2a41b1 --- /dev/null +++ b/report_async/models/ir_actions_report_xml.py @@ -0,0 +1,30 @@ +# -*- coding: utf-8 -*- +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +from odoo import models, fields, api + + +class IrActionsReportXml(models.Model): + """ + Reports + """ + + _inherit = 'ir.actions.report.xml' + + async_report = fields.Boolean(default=False) + + @api.model + def is_report_async(self, report_name): + """ Returns True if the report is an async report + + Called from js + """ + report_obj = self.env['report'] + report = report_obj._get_report_from_name(report_name) + result = {'is_report_async': False} + if not report: + return result + return { + 'is_report_async': report.async_report, + 'mail_recipient': self.env.user.email + } diff --git a/report_async/models/report_async.py b/report_async/models/report_async.py index 11aa5f59db..ca246ad687 100644 --- a/report_async/models/report_async.py +++ b/report_async/models/report_async.py @@ -123,6 +123,16 @@ def view_jobs(self): result["context"] = {} return result + @api.model + def print_document_async(self, record_ids, report_name, html=None, data=None): + """ Generate a document async, do not return the document file """ + report = self.env['report']._get_report_from_name(report_name) + report_async = self.new() + report_async.email_notify = True + report_async.with_delay().run_report( + record_ids, None, report.id, self._uid + ) + @api.model @job def run_report(self, docids, data, report_id, user_id): diff --git a/report_async/static/src/js/qweb_action_manager.js b/report_async/static/src/js/qweb_action_manager.js new file mode 100644 index 0000000000..67dc542862 --- /dev/null +++ b/report_async/static/src/js/qweb_action_manager.js @@ -0,0 +1,48 @@ +odoo.define('report_async.print', function(require) { + 'use strict'; + + var ActionManager = require('web.ActionManager'); + var core = require('web.core'); + var framework = require('web.framework'); + var Model = require('web.Model'); + + ActionManager.include({ + ir_actions_report_xml: function(action, options) { + var _action = _.clone(action); + var _t = core._t; + var self = this; + var _super = this._super; + + if ('report_type' in _action && _action.report_type === 'qweb-pdf') { + framework.blockUI(); + new Model('ir.actions.report.xml') + .call('is_report_async', [_action.report_name]) + .then(function(result){ + if (result.is_report_async) { + framework.unblockUI(); + new Model('report.async') + .call('print_document_async', + [_action.context.active_ids, + _action.report_name, + ], + {data: _action.data || {}, + context: _action.context || {}, + }) + .then(function(){ + self.do_notify(_t('Report'), + _t('Job started to generate report. Upon completion, mail sent to:') + result.mail_recipient); + }).fail(function() { + self.do_notify(_t('Report'), + _t('Failed, error on job creation.')); + + }); + } else { + return _super.apply(self, [_action, options]); + } + }); + } else { + return _super.apply(self, [_action, options]); + } + } + }); +}); diff --git a/report_async/views/assets.xml b/report_async/views/assets.xml new file mode 100644 index 0000000000..aa0da7aa2a --- /dev/null +++ b/report_async/views/assets.xml @@ -0,0 +1,9 @@ + + +