From 9db6add93614334e56b6f6274c2759827625d72b Mon Sep 17 00:00:00 2001 From: AKULA MANOJ Date: Sat, 31 Oct 2026 08:10:27 +0000 Subject: [PATCH] chore: fix JavaScript lint errors (issue #16391) --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: missing_dependencies - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../workflows/scripts/common/lint_javascript_files_error_log | 4 ++-- tools/make/lib/lint/javascript/eslint.mk | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/scripts/common/lint_javascript_files_error_log b/.github/workflows/scripts/common/lint_javascript_files_error_log index c7ce4c94a7e6..200b26720be0 100755 --- a/.github/workflows/scripts/common/lint_javascript_files_error_log +++ b/.github/workflows/scripts/common/lint_javascript_files_error_log @@ -83,7 +83,7 @@ run_make_lint() { local eslint_flags="" if [ "${quiet}" -eq 1 ]; then - eslint_flags="ESLINT_FLAGS='--quiet'" + eslint_flags="STDLIB_ESLINT_FLAGS='--quiet'" fi local make_cmd="make lint-javascript-files FIX=${fix} FAST_FAIL=0 FILES=\"${files_to_lint}\" ${make_args} ${eslint_conf_arg} ${eslint_flags}" @@ -92,7 +92,7 @@ run_make_lint() { if ! eval "${make_cmd}"; then if [ "${quiet}" -eq 0 ]; then echo "Initial linting failed. Retrying with --quiet and logging errors..." - eval "make lint-javascript-files FIX=${fix} FAST_FAIL=0 FILES=\"${files_to_lint}\" ${make_args} ${eslint_conf_arg} ESLINT_FLAGS='--quiet'" >> "${err_file}" 2>&1 + eval "make lint-javascript-files FIX=${fix} FAST_FAIL=0 FILES=\"${files_to_lint}\" ${make_args} ${eslint_conf_arg} STDLIB_ESLINT_FLAGS='--quiet'" >> "${err_file}" 2>&1 else # Already running with --quiet, just log the error echo "Linting failed for files." >> "${err_file}" diff --git a/tools/make/lib/lint/javascript/eslint.mk b/tools/make/lib/lint/javascript/eslint.mk index 49624a7a4ee4..947fafd82d48 100644 --- a/tools/make/lib/lint/javascript/eslint.mk +++ b/tools/make/lib/lint/javascript/eslint.mk @@ -34,7 +34,7 @@ eslint_flags := \ --report-unused-disable-directives # Define user-supplied command-line options: -ESLINT_FLAGS ?= +STDLIB_ESLINT_FLAGS ?= ifeq ($(AUTOFIX),true) eslint_flags += --fix @@ -50,7 +50,7 @@ endif endif # Append user-supplied command-line options: -eslint_flags += $(ESLINT_FLAGS) +eslint_flags += $(STDLIB_ESLINT_FLAGS) # RULES #