Skip to content

Commit e2ca9c9

Browse files
committed
Keep a TODO for the task handler log level
The comment now separates the two things: the airflow.task logger level can already be overridden through the CRD, and the task handler level still cannot. The TODO points at issue 650 and notes it needs a new field in AutomaticContainerLogConfig in operator-rs.
1 parent 7436811 commit e2ca9c9

2 files changed

Lines changed: 14 additions & 7 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,10 @@
99
- The RBAC ServiceAccount and RoleBinding are now built with the operator-rs `v2::rbac`
1010
functions and carry the full set of recommended labels ([#821]).
1111
- Bump stackable-operator to 0.114.0 ([#827]).
12-
- Removed a stale comment suggesting the airflow.task logger level could not be
13-
overridden through the CRD. It already can, by adding a loggers entry for
14-
airflow.task. Added regression tests for this ([#829]).
12+
- Documented that the airflow.task logger level can already be overridden through the
13+
CRD by adding a `loggers` entry for `airflow.task`, and added regression tests that
14+
pin the ordering this relies on. The task *handler* level is still not configurable
15+
([#829]).
1516

1617
[#814]: https://github.com/stackabletech/airflow-operator/pull/814
1718
[#821]: https://github.com/stackabletech/airflow-operator/pull/821

‎rust/operator-binary/src/controller/build/properties/product_logging/mod.rs‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,10 +97,16 @@ for logger_name, logger_config in LOGGING_CONFIG['loggers'].items():
9797
if logger_name != 'airflow.task':
9898
logger_config['propagate'] = True
9999
# The default behavior of airflow is to enforce log level 'INFO' on tasks. (https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#logging-level)
100-
# This can be overridden through the CRD by adding an entry for the logger
101-
# name 'airflow.task' under loggers, since the code appended further below
102-
# (loggers_config) runs after this block and reassigns the level for any
103-
# logger explicitly listed in the CRD.
100+
# The level of the airflow.task LOGGER can be overridden through the CRD by
101+
# adding an entry for the logger name 'airflow.task' under loggers, since the
102+
# code appended further below (loggers_config) runs after this block and
103+
# reassigns the level for any logger explicitly listed in the CRD.
104+
# TODO: Make the task HANDLER log level configurable through the CRD with
105+
# default 'INFO', so that a different level can be sent to the UI than to the
106+
# file and Vector appenders. This needs a new field in
107+
# AutomaticContainerLogConfig in operator-rs, see
108+
# https://github.com/stackabletech/airflow-operator/issues/650
109+
# e.g. LOGGING_CONFIG['handlers']['task']['level'] = {{task_log_level}}
104110
if 'handlers' in logger_config and 'task' in logger_config['handlers']:
105111
logger_config['level'] = logging.INFO
106112

0 commit comments

Comments
 (0)