Skip to content

Commit 8a8a6b0

Browse files
authored
Merge pull request #31 from ryansolid/tembo/rc21-followups
rc.21 regrade: DV-19 (latest of a shown guess, per solidjs/solid#4695), count read under its region, guide and harness follow-ups
2 parents fdbcad9 + 0bfc6ec commit 8a8a6b0

47 files changed

Lines changed: 790 additions & 61 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎eval/README.md‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,10 @@ mutants/ naive React drafts the hidden tests must catch
9898
results/ scored runs
9999
```
100100

101-
Setup: `npm install` here (Solid 2.0.0-rc.21 from npm); `cargo build --release --bin rxc` in `../compiler` (its Solid pin is d2323b0, rc.19).
101+
Setup: `npm install` here (Solid 2.0.0-rc.21 and Playwright from npm; set `CHROMIUM=/path/to/chromium` to drive a
102+
system browser instead of Playwright's download); `cargo build --release --bin rxc` in `../compiler` (its Solid pin
103+
is `ref/SOLID_NEXT`). A round is regradable only if its runs' sources are committed under `results/<round>/runs/`
104+
(rounds 5, 7, 10 and 11 kept theirs in the session that ran them and cannot be regraded).
102105
`RXC` and `RT_WEB` override the paths to the binary and `ref/compile/rt-web.ts`. (The pilot itself ran on PR #6's
103106
crate before it merged, built with the same pin.)
104107

‎eval/harness/driver.mjs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ export async function serve(dist) {
2222
return { url: `http://127.0.0.1:${http.address().port}/`, close: () => http.close() };
2323
}
2424

25-
export async function launch() { return chromium.launch(); }
25+
/** CHROMIUM=/path/to/chromium drives a system browser (NixOS and the like, where Playwright's download does not run). */
26+
export async function launch() { return chromium.launch(process.env.CHROMIUM ? { executablePath: process.env.CHROMIUM } : {}); }
2627

2728
/** One test: a fresh page on the app, `run(app)` with the helpers below. Returns { ok, error }. */
2829
export async function runTest(browser, url, test) {

‎eval/package-lock.json‎

Lines changed: 28 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎eval/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"eslint-plugin-react-hooks": "7.0.0",
1818
"eslint-plugin-solid": "^0.18.1",
1919
"foldkit": "^0.170.0",
20+
"playwright": "1.64.1",
2021
"react": "19.2.0",
2122
"react-dom": "19.2.0",
2223
"solid-js": "2.0.0-rc.21",

‎eval/reference/chain2/rx/issues.rx‎

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,14 @@ export error NotFound(id: number) => `issue #${id} not found`
99

1010
fn found(it, id: number) => it == null ? throw NotFound(id) : it
1111

12+
// the open list as shown (closes in flight already out of it) is the tab's count: it is read where the list is read,
13+
// under the list's boundary, so it holds and reveals with the rows; other lists, loads and failures leave it as it was
14+
component OpenCount(props: { n: number; onCount: (n: number) => void }) {
15+
effect (props.n) {
16+
props.onCount($0)
17+
}
18+
}
19+
1220
export component IssuesPage(props: { onOpenCount: (n: number) => void }) {
1321
source user: string := "guest"
1422
source filter: string := "open"
@@ -20,13 +28,6 @@ export component IssuesPage(props: { onOpenCount: (n: number) => void }) {
2028
source renameError: string = ""
2129
source closeError: string = ""
2230

23-
// the open list as shown (closes in flight already out of it) is the tab's count; other lists, loads and failures
24-
// leave the count as it was
25-
effect ((filter == "open" ? issues.length : -1) catch (e) => -1) {
26-
if ($0 >= 0) {
27-
props.onOpenCount($0)
28-
}
29-
}
3031

3132
action assignTo(id: number, who: string) {
3233
optimistic assignError := ""
@@ -83,6 +84,9 @@ export component IssuesPage(props: { onOpenCount: (n: number) => void }) {
8384
<div data-testid="list">
8485
{loading on(filter) fallback { <p>loading {latest filter} issues</p> } {
8586
{errored fallback(e) { <p>list error: {e.message}</p> } {
87+
{if filter == "open" {
88+
<OpenCount n={issues.length} onCount={n => { props.onOpenCount(n) }} />
89+
}}
8690
<ul>
8791
{for it in issues {
8892
<li data-testid="issue" onClick={() => {

‎eval/reference/chain3/rx/issues.rx‎

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,14 @@ export error NotFound(id: number) => `issue #${id} not found`
1010

1111
fn found(it, id: number) => it == null ? throw NotFound(id) : it
1212

13+
// the open list as shown (closes in flight already out of it) is the tab's count: it is read where the list is read,
14+
// under the list's boundary, so it holds and reveals with the rows; other lists, loads and failures leave it as it was
15+
component OpenCount(props: { n: number; onCount: (n: number) => void }) {
16+
effect (props.n) {
17+
props.onCount($0)
18+
}
19+
}
20+
1321
export component IssuesPage(props: { onOpenCount: (n: number) => void; onOpenHelp: (query: string, id: number) => void }) {
1422
source user: string := "guest"
1523
source filter: string := "open"
@@ -21,13 +29,6 @@ export component IssuesPage(props: { onOpenCount: (n: number) => void; onOpenHel
2129
source renameError: string = ""
2230
source closeError: string = ""
2331

24-
// the open list as shown (closes in flight already out of it) is the tab's count; other lists, loads and failures
25-
// leave the count as it was
26-
effect ((filter == "open" ? issues.length : -1) catch (e) => -1) {
27-
if ($0 >= 0) {
28-
props.onOpenCount($0)
29-
}
30-
}
3132

3233
action assignTo(id: number, who: string) {
3334
optimistic assignError := ""
@@ -84,6 +85,9 @@ export component IssuesPage(props: { onOpenCount: (n: number) => void; onOpenHel
8485
<div data-testid="list">
8586
{loading on(filter) fallback { <p>loading {latest filter} issues</p> } {
8687
{errored fallback(e) { <p>list error: {e.message}</p> } {
88+
{if filter == "open" {
89+
<OpenCount n={issues.length} onCount={n => { props.onOpenCount(n) }} />
90+
}}
8791
<ul>
8892
{for it in issues {
8993
<li data-testid="issue" onClick={() => {

‎eval/reference/chain4/rx/issues.rx‎

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,14 @@ export error NotFound(id: number) => `issue #${id} not found`
1010

1111
fn found(it, id: number) => it == null ? throw NotFound(id) : it
1212

13+
// the open list as shown (closes in flight already out of it) is the tab's count: it is read where the list is read,
14+
// under the list's boundary, so it holds and reveals with the rows; other lists, loads and failures leave it as it was
15+
component OpenCount(props: { n: number; onCount: (n: number) => void }) {
16+
effect (props.n) {
17+
props.onCount($0)
18+
}
19+
}
20+
1321
export component IssuesPage(props: { onOpenCount: (n: number) => void; onOpenHelp: (query: string, id: number) => void }) {
1422
source user: string := "guest"
1523
source filter: string := "open"
@@ -23,13 +31,6 @@ export component IssuesPage(props: { onOpenCount: (n: number) => void; onOpenHel
2331
// the newest row action's failure; row actions and the detail's leave each other's errors alone
2432
source rowError: string = ""
2533

26-
// the open list as shown (closes in flight already out of it) is the tab's count; other lists, loads and failures
27-
// leave the count as it was
28-
effect ((filter == "open" ? issues.length : -1) catch (e) => -1) {
29-
if ($0 >= 0) {
30-
props.onOpenCount($0)
31-
}
32-
}
3334

3435
action assignTo(id: number, who: string, fromRow: boolean) {
3536
if (fromRow) {
@@ -105,6 +106,9 @@ export component IssuesPage(props: { onOpenCount: (n: number) => void; onOpenHel
105106
<div data-testid="list">
106107
{loading on(filter) fallback { <p>loading {latest filter} issues</p> } {
107108
{errored fallback(e) { <p>list error: {e.message}</p> } {
109+
{if filter == "open" {
110+
<OpenCount n={issues.length} onCount={n => { props.onOpenCount(n) }} />
111+
}}
108112
<ul>
109113
{for it in issues {
110114
<li>

‎eval/reference/count/rx/issues.rx‎

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,14 @@ export error NotFound(id: number) => `issue #${id} not found`
88

99
fn found(it, id: number) => it == null ? throw NotFound(id) : it
1010

11+
// the open list as shown (closes in flight already out of it) is the tab's count: it is read where the list is read,
12+
// under the list's boundary, so it holds and reveals with the rows; other lists, loads and failures leave it as it was
13+
component OpenCount(props: { n: number; onCount: (n: number) => void }) {
14+
effect (props.n) {
15+
props.onCount($0)
16+
}
17+
}
18+
1119
export component IssuesPage(props: { onOpenCount: (n: number) => void }) {
1220
source user: string := "guest"
1321
source filter: string := "open"
@@ -19,13 +27,6 @@ export component IssuesPage(props: { onOpenCount: (n: number) => void }) {
1927
source renameError: string = ""
2028
source closeError: string = ""
2129

22-
// the open list as shown (closes in flight already out of it) is the tab's count; other lists, loads and failures
23-
// leave the count as it was
24-
effect ((filter == "open" ? issues.length : -1) catch (e) => -1) {
25-
if ($0 >= 0) {
26-
props.onOpenCount($0)
27-
}
28-
}
2930

3031
action assignTo(id: number, who: string) {
3132
optimistic assignError := ""
@@ -82,6 +83,9 @@ export component IssuesPage(props: { onOpenCount: (n: number) => void }) {
8283
<div data-testid="list">
8384
{loading on(filter) fallback { <p>loading {latest filter} issues</p> } {
8485
{errored fallback(e) { <p>list error: {e.message}</p> } {
86+
{if filter == "open" {
87+
<OpenCount n={issues.length} onCount={n => { props.onOpenCount(n) }} />
88+
}}
8589
<ul>
8690
{for it in issues {
8791
<li data-testid="issue" onClick={() => {
Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
# Regrade on Solid 2.0.0-rc.21 (2026-11-05, not a round)
2+
3+
The rc.21 repin (41a6b1f) carried the fixes for every Solid issue the eval had filed but did not rerun anything. This
4+
regrades what the repository holds, with rc.21 from npm and `rxc` from this commit. Round 10's and round 11's desks are
5+
not in the repository (their run directories stayed in the session that ran them), so they are not here.
6+
7+
## References on the desk9 brief (`harness/grade.sh`: hidden, overlap, 20 fuzz seeds)
8+
9+
| app | hidden | overlap | fuzz seeds with a hole |
10+
| --- | --- | --- | --- |
11+
| chain4 .rx (count read with `latest issues`) | 77/77 | 38/38 | 3 |
12+
| chain4 .rx (count read under the list's region) | 77/77 | 38/38 | 2 |
13+
| chain4 React | 77/77 | 38/38 | 0 |
14+
| recipe React (TanStack's optimistic-updates guide) | 77/77 | 22/38 | 7 |
15+
16+
The recipe React desk scores what round 9 recorded for it (22/38), so this setup grades as the rounds did. The chain4
17+
.rx reference passes every hidden and overlap test, including "retry after not found" (#4425, #4627), which failed in
18+
every .rx run from round 5 on.
19+
20+
The `latest issues` reference's three fuzz holes, replayed:
21+
22+
| seed | hole | cause | owner |
23+
| --- | --- | --- | --- |
24+
| 1 | the tab count shows 3 beside 2 rows, a close in flight | `latest issues` answers the re-asked truth, not the guess, once a list refresh lands under a pending close | Solid: `latest` should keep a shown guess until its hold commits (solidjs/solid#4689, ruled in #4695 decision 3, not built; DV-19) |
25+
| 11 | an accepted rename's row shows the old title until the refresh lands | the row was not in the list when the rename was sent (`findIndex` -1): nothing was guessed on it | the app; `guide/async.md` §4 now says so |
26+
| 15 | an accepted rename's detail heading shows the old title until the refresh lands | the detail was still loading when the rename was sent: nothing was guessed on it (the row guess held) | the app; the same |
27+
28+
Seed 1 was the reference as the checker suggested it: CN-3e refuses the count effect's read of `issues` outside the
29+
`loading on(filter)` region and suggests `latest issues`. Four references (chain2, chain3, chain4, count) had the
30+
outside read, predating the rule. By the spec (and Solid's own ruling, #4695 decision 3) `latest issues` answers the
31+
guess the list shows, so that program is right and the hole is Solid's (DV-19, #4689, not built). The references
32+
read the count where the list is read instead, in a small component under the list's region: it holds and reveals
33+
with the rows, it is equally right by the spec, it does not depend on #4689, and it is what 10 of 12 agent desks in
34+
rounds 10 and 11 wrote. With it, chain4 has two fuzz holes, both the app's (seeds 11 and 15), and chain2, chain3 and
35+
count pass their own tasks' hidden and overlap tests (`graded/`).
36+
37+
Reducing seed 15 turned up a second Solid bug, solidjs/solid#4690: with nothing rendering a store, an effect reading it
38+
sees a guess revert at the action's end, before the action's refresh lands, once an outside re-ask has landed under it.
39+
A rendered reader keeps the guess, and so does an effect beside one; an effect over a source nothing renders reaches
40+
it (DV-20, S-guess-reask-refresh's effect-only variant; `ref/oracle/repros/4690-guess-reask-refresh.mjs`). Fixed on
41+
`next` (Ryan, 2026-11-05); recorded until the repin.
42+
43+
## Round 4's .rx apps (18, `results/change-2026-10-28/runs`) on rc.21 and this `rxc`
44+
45+
| | runs |
46+
| --- | --- |
47+
| pass every hidden and overlap test | 14 |
48+
| refused by `STALE_WRITE_BACK` (AC-1e, added after round 4) | 3: small close-rx-1, small comments-rx-2, frontier rename-rx-3 |
49+
| one overlap test failed | 1: small rename-rx-1, a guess on `detail` with `refresh issues` only |
50+
51+
The three refusals are the three the round 4 write-up predicted. The one failure is the shape `guide/async.md` §4 now
52+
names ("refresh every question you guessed on"). Nothing in round 4's residue is Solid's.
53+
54+
## Reference suites on rc.21
55+
56+
Interpreter 114 pass; oracle and compiled 114 pass, 6 recorded divergences (DV-19 at four instants, DV-20 at two);
57+
server render 107 pass, 7 skip (not rerun after the review fixes); types 156 pass; the crate agrees with ref/ on 321/321 programs.
58+
59+
S-store-8 (two actions' guesses on one row; a declined one reverts alone) had failed on the interpreter since the
60+
commit that added it (edb76be): the interpreter kept one guess per node with one owner, so the newer action's guess took
61+
the row and the older action's decline found nothing of its own to revert. Guesses are now entries per key and hold
62+
(`ref/src/runtime.ts`), as H-11 says; the same-key variant added to S-store-8 passes on all three runners. A new answer that corrects a guess (D-34) marks
63+
the action's entry spent instead of dropping it, so the action's re-ask still holds the corrected guess (D-35): with
64+
the entry dropped, a closed row came back between the write landing and the re-ask (S-latest-reask's variant, `4 / 4`
65+
for `2 / 4`; Solid shows `2 / 4`). The interpreter now follows #4695's D-34: a landing answer is compared with the guess (before,
66+
only one that changed the truth corrected), the correction re-derives the graph, and the screen, the guess's effects
67+
and `latest` of a shown guess keep it until the hold commits.
68+
69+
## Setup
70+
71+
`eval/package.json` now lists Playwright; `CHROMIUM=/path/to/chromium` drives a system browser in `harness/driver.mjs`
72+
and `ref/ssr/run.ts`. `graded/`: the grade output per app above, and `round4-<tier>-<run>.txt` per round 4 app.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
== hidden
2+
64/64 passed
3+
== overlap
4+
29/29 passed

0 commit comments

Comments
 (0)