From 295a318b294ca9c94a59d8e2f62dcfa194e64543 Mon Sep 17 00:00:00 2001 From: Anubhav Date: Sat, 21 Nov 2026 23:31:10 +0530 Subject: [PATCH] fix(reactivity): ignore helper parameters in staleCapture --- .../eslint-plugin-solid/docs/reactivity.md | 40 +++++++++++++++++++ .../src/rules/reactivity.ts | 4 +- .../test/rules/reactivity.test.ts | 37 +++++++++++++++++ 3 files changed, 80 insertions(+), 1 deletion(-) diff --git a/packages/eslint-plugin-solid/docs/reactivity.md b/packages/eslint-plugin-solid/docs/reactivity.md index 16f1e7f..6b162bd 100644 --- a/packages/eslint-plugin-solid/docs/reactivity.md +++ b/packages/eslint-plugin-solid/docs/reactivity.md @@ -1603,6 +1603,46 @@ const scaled = createMemo(() => { return items.map(scale); }); +import { createSignal } from "solid-js"; +function Comp() { + const [items] = createSignal(new Map()); + function handleSave() { + const snapshot = items(); + function look(id) { + return snapshot.get(id) || id; + } + console.log(look("a")); + } + return ; +} + +import { createSignal } from "solid-js"; +function Comp() { + const [items] = createSignal(new Map()); + function handleSave() { + const snapshot = items(); + function look(id) { + return snapshot.get(id) || id; + } + console.log(["a"].map(look)); + } + return ; +} + +import { createSignal } from "solid-js"; +function Comp() { + const [items] = createSignal([]); + function handleSave() { + const snapshot = items(); + function look(id) { + console.log(snapshot); + return id; + } + look("a"); + } + return ; +} + ``` diff --git a/packages/eslint-plugin-solid/src/rules/reactivity.ts b/packages/eslint-plugin-solid/src/rules/reactivity.ts index 2f96a1c..76bc882 100644 --- a/packages/eslint-plugin-solid/src/rules/reactivity.ts +++ b/packages/eslint-plugin-solid/src/rules/reactivity.ts @@ -612,7 +612,9 @@ export default createRule({ ? closure.parent : null; if (!declaration) return false; - const variables = sourceCode.scopeManager?.getDeclaredVariables(declaration) ?? []; + const variables = (sourceCode.scopeManager?.getDeclaredVariables(declaration) ?? []).filter( + (variable) => variable.defs.some((def) => def.type !== "Parameter") + ); return variables.some((variable) => variable.references.some( (reference) => !reference.init && isReferenceReturned(reference.identifier, boundary) diff --git a/packages/eslint-plugin-solid/test/rules/reactivity.test.ts b/packages/eslint-plugin-solid/test/rules/reactivity.test.ts index f0dcafa..a569f30 100644 --- a/packages/eslint-plugin-solid/test/rules/reactivity.test.ts +++ b/packages/eslint-plugin-solid/test/rules/reactivity.test.ts @@ -794,6 +794,43 @@ export const cases = run("reactivity", rule, { const scale = (v) => v * total; return items.map(scale); });`, + `import { createSignal } from "solid-js"; + function Comp() { + const [items] = createSignal(new Map()); + function handleSave() { + const snapshot = items(); + function look(id) { + return snapshot.get(id) || id; + } + console.log(look("a")); + } + return ; + }`, + `import { createSignal } from "solid-js"; + function Comp() { + const [items] = createSignal(new Map()); + function handleSave() { + const snapshot = items(); + function look(id) { + return snapshot.get(id) || id; + } + console.log(["a"].map(look)); + } + return ; + }`, + `import { createSignal } from "solid-js"; + function Comp() { + const [items] = createSignal([]); + function handleSave() { + const snapshot = items(); + function look(id) { + console.log(snapshot); + return id; + } + look("a"); + } + return ; + }`, ], invalid: [ // Untracked signals