Skip to content

Commit f9d6310

Browse files
committed
fix(org): stop painting the phone title's surface, and leave the shared empty state as designed
1 parent 9321804 commit f9d6310

4 files changed

Lines changed: 3 additions & 8 deletions

File tree

‎apps/sim/app/o/[organizationId]/settings/settings-frame.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ function PhoneTitle({ title }: { title: string }) {
2222
const slot = useContext(MobileTitleSlot)
2323
if (!slot) return null
2424
return createPortal(
25-
<Surface canvas>
25+
<Surface>
2626
<SettingsMobileTitle title={title} />
2727
</Surface>,
2828
slot

‎apps/sim/platform/design-system/components/empty-state/empty-state.module.css‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
.empty {
1010
justify-content: center;
1111
min-height: calc(var(--spacing-56) * 2);
12-
padding-block: var(--spacing-16);
12+
padding: var(--spacing-16) var(--spacing-8);
1313
color: var(--ui-ink);
1414
}
1515

‎apps/sim/platform/design-system/styles/embedded.css‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,6 @@
5151
background: var(--ui-canvas);
5252
}
5353

54-
/* A part carried into the host's own bar: the bar paints, so the surface around it must not. */
55-
[data-platform-ui][data-canvas]:has(> [data-host-chrome]) {
56-
background: transparent;
57-
}
58-
5954
[data-platform-ui][data-theme="dark"] {
6055
color-scheme: dark;
6156
}

‎apps/sim/platform/embedded/app/(shell)/settings/_components/settings-screen/settings-screen.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export function SettingsBreadcrumb({ title }: SettingsBreadcrumbProps) {
2424
/** The section's name, for the phone top bar that replaces the breadcrumb. */
2525
export function SettingsMobileTitle({ title }: SettingsBreadcrumbProps) {
2626
return (
27-
<span className={styles.mobileTitle} data-host-chrome data-type='T057'>
27+
<span className={styles.mobileTitle} data-type='T057'>
2828
{title}
2929
</span>
3030
)

0 commit comments

Comments
 (0)