Repository navigation
Commit f843739
committed
fix(credentials): close wave 2b review findings on DocuSign JWT Grant
- The DocuSign knowledge connector now honours a JWT Grant credential's
bound account. The resolved token's instanceUrl reaches the connector as
credentialInstanceUrl in the sync context (seeded on every path through
syncContextForToken). The connector re-validates it with the same parser
as DocuSignClient, lists and fetches from that account in the
credential's environment, links envelopes to that environment's web app,
and validates without asking the deployment host. A seeded value of the
wrong shape fails closed. OAuth syncs are unchanged.
- RSA keys under 2048 bits are refused as invalid_credentials with copy
that names the size, instead of jose's raw TypeError.
- A short expires_in no longer makes every call re-mint: the cached
lifetime floors at six minutes while staying a minute under the real
expiry.
- The connect modal shows the consent URL as a link with a copy button,
and account_not_found says "pinned account" only when one was entered.1 parent a7276db commit f843739
10 files changed
Lines changed: 327 additions & 37 deletions
File tree
- apps
- docs/content/docs/integrations
- sim
- app/workspace/[workspaceId]/integrations/components/connect-service-account-modal
- connectors/docusign
- lib
- credentials/client-credential-accounts/minters
- internal/docusign
- knowledge/connectors
- oauth
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
40 | 47 | | |
41 | 48 | | |
42 | 49 | | |
| |||
50 | 57 | | |
51 | 58 | | |
52 | 59 | | |
53 | | - | |
| 60 | + | |
54 | 61 | | |
55 | 62 | | |
56 | 63 | | |
57 | 64 | | |
58 | 65 | | |
59 | 66 | | |
60 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
61 | 70 | | |
62 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
63 | 75 | | |
64 | 76 | | |
65 | 77 | | |
66 | 78 | | |
67 | 79 | | |
68 | | - | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
69 | 83 | | |
70 | 84 | | |
71 | | - | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
72 | 88 | | |
73 | 89 | | |
74 | 90 | | |
75 | 91 | | |
76 | | - | |
77 | | - | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
78 | 99 | | |
79 | 100 | | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
80 | 106 | | |
81 | 107 | | |
82 | | - | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
83 | 111 | | |
84 | 112 | | |
85 | | - | |
| 113 | + | |
86 | 114 | | |
87 | | - | |
| 115 | + | |
88 | 116 | | |
89 | 117 | | |
90 | | - | |
| 118 | + | |
91 | 119 | | |
92 | 120 | | |
93 | 121 | | |
| |||
155 | 183 | | |
156 | 184 | | |
157 | 185 | | |
158 | | - | |
| 186 | + | |
159 | 187 | | |
160 | 188 | | |
161 | 189 | | |
| |||
397 | 425 | | |
398 | 426 | | |
399 | 427 | | |
400 | | - | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
401 | 448 | | |
402 | 449 | | |
403 | 450 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
6 | 10 | | |
7 | 11 | | |
8 | 12 | | |
| |||
34 | 38 | | |
35 | 39 | | |
36 | 40 | | |
| 41 | + | |
| 42 | + | |
37 | 43 | | |
38 | 44 | | |
39 | 45 | | |
| |||
138 | 144 | | |
139 | 145 | | |
140 | 146 | | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
141 | 163 | | |
142 | 164 | | |
143 | 165 | | |
| |||
151 | 173 | | |
152 | 174 | | |
153 | 175 | | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
154 | 181 | | |
155 | 182 | | |
156 | 183 | | |
| |||
211 | 238 | | |
212 | 239 | | |
213 | 240 | | |
214 | | - | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
215 | 245 | | |
216 | | - | |
| 246 | + | |
217 | 247 | | |
218 | 248 | | |
219 | 249 | | |
| |||
286 | 316 | | |
287 | 317 | | |
288 | 318 | | |
289 | | - | |
| 319 | + | |
290 | 320 | | |
291 | 321 | | |
292 | 322 | | |
293 | 323 | | |
294 | 324 | | |
295 | 325 | | |
296 | | - | |
| 326 | + | |
297 | 327 | | |
298 | 328 | | |
299 | 329 | | |
| |||
505 | 535 | | |
506 | 536 | | |
507 | 537 | | |
508 | | - | |
| 538 | + | |
509 | 539 | | |
510 | 540 | | |
511 | 541 | | |
| |||
597 | 627 | | |
598 | 628 | | |
599 | 629 | | |
600 | | - | |
| 630 | + | |
601 | 631 | | |
602 | 632 | | |
603 | 633 | | |
| |||
618 | 648 | | |
619 | 649 | | |
620 | 650 | | |
621 | | - | |
| 651 | + | |
| 652 | + | |
622 | 653 | | |
623 | 654 | | |
624 | 655 | | |
625 | 656 | | |
626 | 657 | | |
627 | 658 | | |
628 | 659 | | |
629 | | - | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
630 | 663 | | |
631 | 664 | | |
632 | 665 | | |
| |||
0 commit comments