Skip to content

Commit f4e0d14

Browse files
committed
fix(emcn): let text in any cell open an openable DataTable row
1 parent f0f5ad3 commit f4e0d14

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

‎packages/emcn/src/components/data-display/data-display.module.css‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,9 +189,11 @@
189189
text-align: inherit;
190190
cursor: pointer;
191191
}
192+
/* The stretched target sits above cell content, so text in any cell opens the row; the selection and action cells stay above it. */
192193
.rowTarget::after {
193194
position: absolute;
194195
inset: 0;
196+
z-index: 1;
195197
content: "";
196198
}
197199
.table [data-kind="action"] {
@@ -204,8 +206,9 @@
204206
position: relative;
205207
inline-size: var(--spacing-32);
206208
}
207-
.table td[data-kind="selection"] {
208-
z-index: 1;
209+
.table td[data-kind="selection"],
210+
.table td[data-kind="action"] {
211+
z-index: 2;
209212
}
210213
.table [data-kind="action"][data-passive] {
211214
padding-inline-end: var(--spacing-8);

‎scripts/emcn-surface.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8637,13 +8637,13 @@
86378637
"metricFrame": "65ee4ddd1b75",
86388638
"metricLabel": "ada480de6437",
86398639
"metrics": "459a8e040155",
8640-
"rowTarget": "d7fca878fbd4",
8640+
"rowTarget": "4e79f2dc5d69",
86418641
"section": "f8bc57351657",
86428642
"selectionActions": "b0177d01ec8f",
86438643
"selectionCount": "634dad7036b0",
86448644
"sort": "c95c4bf4b093",
86458645
"spacer": "6c698186efce",
8646-
"table": "3bb8b5451330",
8646+
"table": "e4f99c9200cc",
86478647
"tableViewport": "c5628c722298",
86488648
"toolbar": "8a86069f17e4",
86498649
"toolbarControls": "459760e88324",
@@ -8887,7 +8887,7 @@
88878887
"src/components/checkbox/checkbox.tsx": "4f5d97e5524d",
88888888
"src/components/command-palette/command-palette.module.css": "f4190fd2c12b",
88898889
"src/components/command-palette/command-palette.tsx": "cbf3a96b0296",
8890-
"src/components/data-display/data-display.module.css": "6ca091c2b210",
8890+
"src/components/data-display/data-display.module.css": "2bb447672741",
88918891
"src/components/data-display/data-display.tsx": "47890cc866fc",
88928892
"src/components/disclosure/disclosure.module.css": "7ab5e71843da",
88938893
"src/components/disclosure/disclosure.tsx": "65cd8c7eb460",

0 commit comments

Comments
 (0)