test(org): assert the visible description and wait for the People prefetch

Author: waleedlatif1

apps/sim/scripts/org-redesign-e2e/checks/people.ts

@@ -32,14 +32,15 @@ export async function peoplePhaseChecks() {
         if (route.request().headers()['next-router-prefetch'] === undefined) await hold.promise
         await route.continue()
       })
-      const prefetched = page.waitForResponse(
-        async (response) =>
-          isPeoplePayload(new URL(response.url())) &&
-          (await response.text().catch(() => '')).includes('Loading people')
+      // The router can only show a loading boundary a prefetch has already delivered.
+      const prefetched = page.waitForResponse((response) =>
+        isPeoplePayload(new URL(response.url()))
       )
       await page.goto(orgUrl('/home'))
+      const link = mainNav(page).getByRole('link', { name: 'People', exact: true })
+      await link.hover()
       await prefetched
-      await mainNav(page).getByRole('link', { name: 'People', exact: true }).click()
+      await link.click()
       const rows = page.getByRole('status', { name: 'Loading people…' })
       await expect(rows).toBeVisible()
       const heading = await page.getByRole('heading', { name: 'People', exact: true }).boundingBox()

apps/sim/scripts/org-redesign-e2e/checks/settings.ts

@@ -553,7 +553,7 @@ export async function settingsChecks() {
       )
       await page.goto(orgUrl('/settings/usage/events'))
       await expect(page.getByRole('columnheader', { name: 'Description' })).toBeVisible()
-      await expect(page.getByText('A described charge')).toBeVisible()
+      await expect(page.getByText('A described charge').filter({ visible: true })).toHaveCount(1)
     })
   })
   await check('Credential groups: a bad address leaves the valid one sent', async () => {