fix(search): retarget unrelated-tool fixtures, type the web citation test, mark chat open-world

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/home/components/message-content/resolve-citations.test.ts

@@ -4,7 +4,7 @@ import { normalizeMessage } from '@/lib/mothership/chat/persisted-message'
 import { compactRetrievalCitations } from '@/lib/mothership/chat/retrieval-citations'
 import { collectCitedMessageSources } from '@/app/workspace/[workspaceId]/home/components/message-content/message-sources'
 import { resolveMessageCitations } from '@/app/workspace/[workspaceId]/home/components/message-content/resolve-citations'
-import type { ContentBlock } from '@/app/workspace/[workspaceId]/home/types'
+import type { ContentBlock, ToolCallStatus } from '@/app/workspace/[workspaceId]/home/types'
 
 const output = {
   success: true,
@@ -138,7 +138,11 @@ describe('evidence-linked citations', () => {
         },
       ],
     }
-    const webBlocks = (status: string, success: boolean, result: unknown): ContentBlock[] => [
+    const webBlocks = (
+      status: ToolCallStatus,
+      success: boolean,
+      result: unknown
+    ): ContentBlock[] => [
       {
         type: 'tool_call',
         toolCall: { id: 'web', name: 'web_search', status, result: { success, output: result } },

apps/sim/lib/knowledge/application/chat.test.ts

@@ -276,7 +276,7 @@ describe('Search Assistant citations', () => {
   it.each([
     tool({ data: citation }, { status: 'error' }),
     tool({ success: false, data: citation }),
-    tool({ data: citation }, { name: 'web_search' }),
+    tool({ data: citation }, { name: 'call_integration_tool' }),
     tool({ data: { ...citation, citationUrl: 'javascript:alert(1)' } }),
     tool({ data: { ...citation, citationUrl: 'https://user:password@docs.example' } }),
   ])('does not cite failed, unrelated, or unsafe evidence', (result) => {

apps/sim/lib/knowledge/mcp/server.ts

@@ -246,7 +246,7 @@ export function createKnowledgeMcpServer(context: KnowledgeMcpContext): McpServe
         readOnlyHint: false,
         destructiveHint: false,
         idempotentHint: false,
-        openWorldHint: false,
+        openWorldHint: true,
       },
     },
     async ({ query, ...filters }, extra) =>

apps/sim/lib/mothership/chat/citation-evidence.ts

@@ -18,6 +18,7 @@ type RetrievalCitationSource = {
 const WEB_TOOLS = new Set(['web_search', 'web_fetch'])
 const CITATION_TOOLS = new Set(['search_workspace', 'read_document', ...WEB_TOOLS])
 
+/** Whether a successful result of this tool may supply source destinations. */
 export function isCitationTool(toolName: string): boolean {
   return CITATION_TOOLS.has(toolName)
 }