fix(search): use the shared deferred test helper

Author: waleedlatif1

apps/sim/lib/knowledge/search/diagnostics.test.ts

@@ -1,3 +1,4 @@
+import { createDeferred } from '@sim/testing/helpers'
 import { getMockLogger } from '@sim/testing/mocks/logger.mock'
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 import {
@@ -144,7 +145,7 @@ describe('search pipeline diagnostics', () => {
   })
 
   it('records preview failures that settle after the search has returned', async () => {
-    const pending = Promise.withResolvers<void>()
+    const pending = createDeferred<void>()
     let request: Promise<unknown> | undefined
     await withSearchDiagnostics({}, () =>
       withSearchProviderDiagnostics({ provider: 'gmail', accountIndex: 0 }, async () => {

scripts/check-test-types.baseline.json

@@ -1719,9 +1719,6 @@
   "apps/sim/lib/knowledge/reranker.test.ts": {
     "TS2540": 2
   },
-  "apps/sim/lib/knowledge/search/diagnostics.test.ts": {
-    "TS2345": 2
-  },
   "apps/sim/lib/knowledge/search/prewarm.test.ts": {
     "TS2345": 4
   },