refactor(platform): ask whether a held workspace tab is shown in its own page

The workspace layout reads workspace-tab-flags for the tab bar, so a runtime
import there grew every workspace page's server graph past its baseline.
The five held pages now ask isWorkspaceTabShown themselves.

Author: emir-karabeg

apps/sim/app/(product)/workspace/[workspaceId]/changelog/[entryId]/page.tsx

@@ -4,6 +4,7 @@ import { workspacePath } from '@/lib/navigation/paths'
 import { ChangelogDetails } from '@/app/(product)/workspace/[workspaceId]/changelog/_components/changelog-details/changelog-details'
 import { platformHref, readScenario } from '@/platform/lib/navigation'
 import type { ProductPageProps } from '@/platform/lib/route-props'
+import { isWorkspaceTabShown } from '@/platform/lib/workspace-navigation'
 import { withChangelogView } from '@/platform/lib/workspace-views'
 
 export const metadata: Metadata = { title: 'Changelog' }
@@ -29,12 +30,13 @@ export default async function Page({
     if (!entry) notFound()
     return <ChangelogDetails entry={entry} back={back} />
   }
-  const [{ readWorkspaceTabShown }, { LiveRelease }] = await Promise.all([
+  const [{ readWorkspaceTabFlags }, { LiveRelease }] = await Promise.all([
     import('@/platform/lib/data/workspace-tab-flags'),
     import(
       '@/app/(product)/workspace/[workspaceId]/changelog/_components/live-release/live-release'
     ),
   ])
-  if (!(await readWorkspaceTabShown('changelog'))) notFound()
+  // A tab live data does not list has no page.
+  if (!isWorkspaceTabShown('changelog', await readWorkspaceTabFlags())) notFound()
   return <LiveRelease workspaceId={workspaceId} releaseId={id} back={back} />
 }

apps/sim/app/(product)/workspace/[workspaceId]/changelog/page.tsx

@@ -2,6 +2,7 @@ import type { Metadata } from 'next'
 import { notFound } from 'next/navigation'
 import { readScenario } from '@/platform/lib/navigation'
 import type { ProductPageProps } from '@/platform/lib/route-props'
+import { isWorkspaceTabShown } from '@/platform/lib/workspace-navigation'
 
 export const metadata: Metadata = { title: 'Changelog' }
 
@@ -25,12 +26,13 @@ export default async function Page({
     if (!data) notFound()
     return <ChangelogRoute data={data} />
   }
-  const [{ readWorkspaceTabShown }, { LiveChangelog }] = await Promise.all([
+  const [{ readWorkspaceTabFlags }, { LiveChangelog }] = await Promise.all([
     import('@/platform/lib/data/workspace-tab-flags'),
     import(
       '@/app/(product)/workspace/[workspaceId]/changelog/_components/live-changelog/live-changelog'
     ),
   ])
-  if (!(await readWorkspaceTabShown('changelog'))) notFound()
+  // A tab live data does not list has no page.
+  if (!isWorkspaceTabShown('changelog', await readWorkspaceTabFlags())) notFound()
   return <LiveChangelog workspaceId={workspaceId} />
 }

apps/sim/app/(product)/workspace/[workspaceId]/dashboards/page.tsx

@@ -2,6 +2,7 @@ import type { Metadata } from 'next'
 import { notFound } from 'next/navigation'
 import { readScenario } from '@/platform/lib/navigation'
 import type { ProductPageProps } from '@/platform/lib/route-props'
+import { isWorkspaceTabShown } from '@/platform/lib/workspace-navigation'
 
 export const metadata: Metadata = { title: 'Dashboard' }
 
@@ -25,10 +26,11 @@ export default async function Page({
     if (!data) notFound()
     return <DashboardRoute data={data} />
   }
-  const [{ readWorkspaceTabShown }, { LiveDashboard }] = await Promise.all([
+  const [{ readWorkspaceTabFlags }, { LiveDashboard }] = await Promise.all([
     import('@/platform/lib/data/workspace-tab-flags'),
     import('@/app/(product)/_components/workspace/dashboards/live-dashboard/live-dashboard'),
   ])
-  if (!(await readWorkspaceTabShown('dashboards'))) notFound()
+  // A tab live data does not list has no page.
+  if (!isWorkspaceTabShown('dashboards', await readWorkspaceTabFlags())) notFound()
   return <LiveDashboard workspaceId={workspaceId} />
 }

apps/sim/app/(product)/workspace/[workspaceId]/tests/[name]/page.tsx

@@ -1,6 +1,7 @@
 import type { Metadata } from 'next'
 import { notFound } from 'next/navigation'
 import { resolvePlatformMode } from '@/platform/lib/data/mode'
+import { isWorkspaceTabShown } from '@/platform/lib/workspace-navigation'
 
 export const metadata: Metadata = { title: 'Test' }
 
@@ -13,11 +14,12 @@ export default async function Page({
   params: Promise<{ workspaceId: string; name: string }>
 }) {
   if (resolvePlatformMode() !== 'live') notFound()
-  const [{ workspaceId, name }, { readWorkspaceTabShown }, { TestDetails }] = await Promise.all([
+  const [{ workspaceId, name }, { readWorkspaceTabFlags }, { TestDetails }] = await Promise.all([
     params,
     import('@/platform/lib/data/workspace-tab-flags'),
     import('@/app/(product)/workspace/[workspaceId]/tests/_components/test-details/test-details'),
   ])
-  if (!(await readWorkspaceTabShown('tests'))) notFound()
+  // A tab live data does not list has no page.
+  if (!isWorkspaceTabShown('tests', await readWorkspaceTabFlags())) notFound()
   return <TestDetails key={name} workspaceId={workspaceId} name={decodeURIComponent(name)} />
 }

apps/sim/app/(product)/workspace/[workspaceId]/tests/page.tsx

@@ -1,6 +1,7 @@
 import type { Metadata } from 'next'
 import { notFound } from 'next/navigation'
 import { resolvePlatformMode } from '@/platform/lib/data/mode'
+import { isWorkspaceTabShown } from '@/platform/lib/workspace-navigation'
 
 export const metadata: Metadata = { title: 'Tests' }
 
@@ -9,11 +10,12 @@ export const dynamic = 'force-dynamic'
 
 export default async function Page({ params }: { params: Promise<{ workspaceId: string }> }) {
   if (resolvePlatformMode() !== 'live') notFound()
-  const [{ workspaceId }, { readWorkspaceTabShown }, { TestList }] = await Promise.all([
+  const [{ workspaceId }, { readWorkspaceTabFlags }, { TestList }] = await Promise.all([
     params,
     import('@/platform/lib/data/workspace-tab-flags'),
     import('@/app/(product)/workspace/[workspaceId]/tests/_components/test-list/test-list'),
   ])
-  if (!(await readWorkspaceTabShown('tests'))) notFound()
+  // A tab live data does not list has no page.
+  if (!isWorkspaceTabShown('tests', await readWorkspaceTabFlags())) notFound()
   return <TestList workspaceId={workspaceId} />
 }

apps/sim/platform/lib/data/workspace-tab-flags.ts

@@ -1,10 +1,6 @@
 import 'server-only'
 import { readOrganizationSurface } from '@/platform/lib/data/surface'
-import {
-  isWorkspaceTabShown,
-  type WorkspaceTab,
-  type WorkspaceTabFlags,
-} from '@/platform/lib/workspace-navigation'
+import type { WorkspaceTabFlags } from '@/platform/lib/workspace-navigation'
 
 /**
  * The flags the workspace tabs depend on, from the surface the shell already read in this request.
@@ -21,8 +17,3 @@ export async function readWorkspaceTabFlags(): Promise<WorkspaceTabFlags> {
     'platform-preview': featureFlags['platform-preview'],
   }
 }
-
-/** Whether live data lists `section` for the viewer, so a page whose tab is not shown answers 404. */
-export async function readWorkspaceTabShown(section: WorkspaceTab): Promise<boolean> {
-  return isWorkspaceTabShown(section, await readWorkspaceTabFlags())
-}