test(platform): drop redundant env resets and type the zone boot environment

Author: waleedlatif1

apps/sim/platform/checks/live/zone-boot/refuses-to-start.spec.ts

@@ -1,6 +1,5 @@
 import { type ChildProcess, spawn } from 'node:child_process'
 import { expect, test } from '@playwright/test'
-import { omit } from '@sim/utils/object'
 
 /**
  * Starts the zone's real production build as its own process, the way a container does, under the
@@ -27,7 +26,10 @@ function startZone(env: Record<string, string>) {
     ],
     {
       env: {
-        ...omit(process.env, ['SIM_PLATFORM_API_ORIGIN', 'SIM_PLATFORM_FIXTURES', 'NODE_ENV']),
+        ...process.env,
+        NODE_ENV: 'production',
+        SIM_PLATFORM_API_ORIGIN: undefined,
+        SIM_PLATFORM_FIXTURES: undefined,
         SIM_PLATFORM_BASE_PATH: '/org',
         ...env,
       },

apps/sim/platform/lib/data/landing.test.ts

@@ -1,4 +1,4 @@
-import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
 import { resolveLiveLanding } from '@/platform/lib/data/landing'
 import type { PlatformOrganization } from '@/platform/lib/data/organization-model'
 import { readOrganizationSurface } from '@/platform/lib/data/surface'
@@ -33,10 +33,6 @@ describe('resolveLiveLanding', () => {
     vi.stubEnv('NEXT_PUBLIC_APP_URL', ORIGIN)
   })
 
-  afterEach(() => {
-    vi.unstubAllEnvs()
-  })
-
   it('sends an organization outside the rollout back to the main app, out of the zone', async () => {
     vi.mocked(readOrganizationSurface).mockResolvedValue({
       status: 'ok',

apps/sim/proxy.test.ts

@@ -352,7 +352,6 @@ describe('Platform zone outage', () => {
   })
 
   afterEach(async () => {
-    vi.unstubAllEnvs()
     setEnv({ SIM_PLATFORM_ORIGIN: undefined })
     answer = 404
     await Promise.all(