test(platform): assert where saved upgrade, request and outside-organization links really land

- A saved upgrade link keeps its query on the first hop to Plans; the
  seeded Enterprise organization then exits to Billing, as legacy did.
- A legacy access-requests link names view=requests, as the existing
  access-requests navigation always has.
- A non-member organization is the access denial the shell gate draws,
  which the org-redesign suite already asserts.
- Self-hosted Plans goes to the hosted app's upgrade page with its
  reason, per resolvePlansEntry; Billing stays not found.

Author: waleedlatif1

apps/sim/platform/checks/live/redirects.spec.ts

@@ -24,11 +24,8 @@ const REDIRECTS: readonly (readonly [string, string])[] = [
   [liveRoute('/links?search=hand'), liveRoute('/settings/links?search=hand')],
   [`${WORKSPACE}/w`, `${WORKSPACE}/workflows`],
   [`${WORKSPACE}/home`, liveRoute('/home')],
-  // The upgrade prompt carries why it was shown and nothing else.
-  [
-    `${WORKSPACE}/upgrade?reason=credits&ref=x`,
-    liveRoute('/settings/billing/plans?reason=credits'),
-  ],
+  // The seeded organization is on Enterprise, whose plans page exits to Billing, as legacy's did.
+  [`${WORKSPACE}/upgrade?reason=credits&ref=x`, liveRoute('/settings/billing')],
 ]
 
 for (const [from, to] of REDIRECTS) {
@@ -62,7 +59,11 @@ const QUERY_REDIRECTS: readonly (readonly [string, string])[] = [
   [`${WORKSPACE}/settings/apikeys?from=mail`, `${WORKSPACE}/settings/api-keys?from=mail`],
   [
     `${WORKSPACE}/access-requests?requestId=req-1`,
-    `${WORKSPACE}/settings/requests?requestId=req-1`,
+    `${WORKSPACE}/settings/requests?view=requests&requestId=req-1`,
+  ],
+  [
+    `${WORKSPACE}/upgrade?reason=credits&ref=x`,
+    liveRoute('/settings/billing/plans?reason=credits&ref=x'),
   ],
 ]
 
@@ -112,14 +113,19 @@ test('every legacy sub-path of a workspace the viewer cannot open is a branded n
   }
 })
 
-test('an organization the viewer does not belong to is the branded not-found, not a failed read', async ({
+test('an organization the viewer does not belong to is the access denial, not a failed read', async ({
   page,
 }) => {
   await signInAsAdmin(page, liveRoute('/home'))
   const outside = `/o/${organizationId()}-outside`
   for (const route of ['/home', '/settings/members']) {
     await page.goto(`${outside}${route}`)
-    await expect(page.getByRole('heading', { name: 'Page not found' }), route).toBeVisible()
+    await expect(
+      page.getByRole('heading', { name: 'Organization access denied' }),
+      route
+    ).toBeVisible()
+    await expect(page.getByRole('button', { name: 'View your workspaces' }), route).toBeVisible()
+    await expect(page.getByRole('heading', { name: 'Something went wrong' }), route).toHaveCount(0)
   }
 })
 

apps/sim/platform/checks/live/self-hosted/surfaces.spec.ts

@@ -1,4 +1,5 @@
 import { expect } from '@playwright/test'
+import { SIM_SITE_URL } from '@sim/utils/site'
 import { signInAsAdmin } from '@/platform/checks/live/session'
 import { firstHopFrom } from '@/platform/checks/live/support/navigation'
 import { liveRoute, liveRoutePattern } from '@/platform/checks/routes'
@@ -30,15 +31,19 @@ test('a self-hosted shell renders every section a member uses', async ({ page })
   }
 })
 
-test('self-hosted settings offer no billing section, and a saved billing link is not found', async ({
+test('self-hosted settings offer no billing section, a saved billing link is not found, and plans go to the hosted app', async ({
   page,
 }) => {
   await signInAsAdmin(page, liveRoute('/settings'))
   await expect(page.getByRole('link', { name: 'Billing', exact: true })).toHaveCount(0)
-  for (const route of ['/settings/billing', '/settings/billing/plans']) {
-    await page.goto(liveRoute(route))
-    await expect(page.getByRole('heading', { name: 'Page not found' }), route).toBeVisible()
-  }
+  await page.goto(liveRoute('/settings/billing'))
+  await expect(page.getByRole('heading', { name: 'Page not found' })).toBeVisible()
+  // A self-hosted deployment buys its plan on the hosted app, as the legacy upgrade page sent it.
+  await page.route(`${SIM_SITE_URL}/**`, (route) =>
+    route.fulfill({ status: 200, contentType: 'text/html', body: 'Hosted upgrade stand-in' })
+  )
+  await page.goto(liveRoute('/settings/billing/plans?reason=credits'))
+  await expect(page).toHaveURL(`${SIM_SITE_URL}/upgrade?reason=credits`)
 })
 
 for (const [from, to] of [