Skip to content

Commit a4df4a8

Browse files
committed
fix(org): stop clipping integration descriptions and long picker values
A touch screen has no tooltip to finish a clipped sentence, so these descriptions wrap, and a picker's value ends in an ellipsis instead of a cut character.
1 parent fa850f4 commit a4df4a8

4 files changed

Lines changed: 18 additions & 8 deletions

File tree

‎apps/sim/platform/design-system/components/activity-row/activity-row.tsx‎

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ interface ActivityRowProps {
1515
count?: number
1616
detail?: string
1717
detailLead?: string
18+
/** Lets the detail take more lines, for a sentence a touch screen has no tooltip to finish. */
19+
wrapDetail?: boolean
1820
metadata?: string
1921
/** A glyph held beside `metadata`, such as a running spinner. */
2022
metadataLeading?: ReactNode
@@ -50,6 +52,7 @@ export function ActivityRow({
5052
count,
5153
detail,
5254
detailLead,
55+
wrapDetail,
5356
metadata,
5457
metadataLeading,
5558
showChevron = true,
@@ -67,14 +70,18 @@ export function ActivityRow({
6770
</span>
6871
{detail && (
6972
<span className={styles.detail} data-type='T050'>
70-
<OverflowText text={detailLead ? `${detailLead} ${detail}` : detail}>
71-
{detailLead && (
72-
<>
73-
<strong data-type='T051'>{detailLead}</strong>{' '}
74-
</>
75-
)}
76-
{detail}
77-
</OverflowText>
73+
{wrapDetail ? (
74+
detail
75+
) : (
76+
<OverflowText text={detailLead ? `${detailLead} ${detail}` : detail}>
77+
{detailLead && (
78+
<>
79+
<strong data-type='T051'>{detailLead}</strong>{' '}
80+
</>
81+
)}
82+
{detail}
83+
</OverflowText>
84+
)}
7885
</span>
7986
)}
8087
</ActivityBody>

‎apps/sim/platform/design-system/components/picker/picker.module.css‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
flex: 1;
3232
min-inline-size: 0;
3333
overflow: hidden;
34+
text-overflow: ellipsis;
3435
white-space: nowrap;
3536
}
3637

‎apps/sim/platform/embedded/app/(shell)/_components/get-started/get-started.tsx‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ export function GetStarted({ steps }: GetStartedProps) {
2424
leading={<Icon name={step.complete ? 'I072' : STEP_ICONS[step.id]} />}
2525
title={step.title}
2626
detail={step.detail}
27+
wrapDetail
2728
metadata={step.complete ? 'Done' : undefined}
2829
href={step.href}
2930
/>

‎apps/sim/platform/embedded/app/(shell)/integrations/_components/integration-list/integration-list.tsx‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ export function IntegrationList({
100100
leading={item.leading}
101101
title={item.name}
102102
detail={item.detail}
103+
wrapDetail
103104
metadata={item.status}
104105
/>
105106
))}

0 commit comments

Comments
 (0)