test: drop or tighten assertions that could not fail

- delegation: the read-only replacement case decided its filter by
  scanning bound params in a fake DB; no real-boundary check exists, so
  it is dropped with the fake's filter
- Twilio: assert how many recordings requests were sent, so an empty
  loop cannot pass
- Pi: the removed-model case restated the absent-from-catalog case

Author: waleedlatif1

apps/sim/lib/mothership/chat/delegation.test.ts

@@ -65,18 +65,13 @@ function database() {
           if (!locked) throw new Error('Read before acquiring the user lock')
           return {
             from: () => ({
-              where: (condition: SQL) => {
-                const query = dialect.sqlToQuery(condition)
-                // Only the access filter binds 'write'; the other predicates bind ids, names and dates.
-                const writeOnly = query.params.includes('write')
-                return {
-                  limit: async () => {
-                    const row = rows.get(name)
-                    if (!row || row.expiresAt.getTime() <= Date.now() + 30 * 60_000) return []
-                    return writeOnly && row.access === 'read' ? [] : [row]
-                  },
-                }
-              },
+              where: () => ({
+                limit: async () => {
+                  const row = rows.get(name)
+                  if (!row || row.expiresAt.getTime() <= Date.now() + 30 * 60_000) return []
+                  return [row]
+                },
+              }),
             }),
           }
         },
@@ -161,22 +156,6 @@ describe('delegation key concurrency', () => {
     expect(db.rows.get('mothership-delegation:alice')).toBe(old)
   })
 
-  it('replaces a read-only key instead of handing it to the CLI', async () => {
-    const db = database()
-    db.rows.set('mothership-delegation:actor', {
-      id: 'read-key',
-      name: 'mothership-delegation:actor',
-      key: 'encrypted-read-only',
-      expiresAt: new Date(Date.now() + 6 * 60 * 60_000),
-      access: 'read',
-    })
-    expect(await mintDelegationToken({ workspaceId: 'shared', userId: 'actor' })).toBe('plain-1')
-    expect(db.rows.get('mothership-delegation:actor')).toMatchObject({
-      key: 'encrypted-1',
-      access: 'write',
-    })
-  })
-
   it('does not log bound credential values from database errors', async () => {
     mocks.transaction.mockRejectedValue(
       new Error('Failed query params: plaintext-key, encrypted-key')

apps/sim/providers/pi-providers.test.ts

@@ -32,17 +32,6 @@ describe('Pi provider catalog', () => {
     )
   })
 
-  it('rejects saved model IDs removed by Pi without substituting another model', () => {
-    expect(resolvePiModelId('anthropic', 'claude-opus-4-1')).toBeUndefined()
-    expect(resolvePiModelId('cerebras', 'cerebras/zai-glm-4.7')).toBeUndefined()
-    expect(resolvePiModelId('zai', 'glm-5.1')).toBeUndefined()
-    expect(resolvePiModelId('zai', 'glm-4.5-air')).toBeUndefined()
-    expect(resolvePiModelId('mistral', 'mistral-large-2411')).toBeUndefined()
-    expect(resolvePiModelId('mistral', 'devstral-small-2507')).toBeUndefined()
-    expect(resolvePiModelId('mistral', 'devstral-medium-2507')).toBeUndefined()
-    expect(resolvePiModelId('nvidia', 'nvidia/nemotron-3-super-120b-a12b')).toBeUndefined()
-  })
-
   it('rejects provider/model pairs absent from the installed Pi catalog', () => {
     expect(resolvePiModelId('anthropic', 'claude-sonnet-999')).toBeUndefined()
     expect(resolvePiModelId('zai', 'glm-4.5-air-unknown')).toBeUndefined()

apps/sim/tools/twilio_voice/list_calls.test.ts

@@ -41,15 +41,17 @@ describe('Twilio list calls recordings lookup', () => {
     fetchMock.mockImplementation(async () => jsonResponse({ recordings: [{ sid: 'RE1' }] }))
   })
 
-  it.each(['@evil.test/x', '//evil.test/x', 'https://evil.test/x'])(
-    'never sends the saved credentials off the Twilio API origin for %s',
-    async (path) => {
-      await listCalls([path])
-      for (const [url] of fetchMock.mock.calls) {
-        expect(new URL(String(url)).origin).toBe('https://api.twilio.com')
-      }
+  it.each([
+    ['@evil.test/x', 1],
+    ['//evil.test/x', 0],
+    ['https://evil.test/x', 0],
+  ])('never sends the saved credentials off the Twilio API origin for %s', async (path, calls) => {
+    await listCalls([path])
+    expect(fetchMock).toHaveBeenCalledTimes(calls)
+    for (const [url] of fetchMock.mock.calls) {
+      expect(new URL(String(url)).origin).toBe('https://api.twilio.com')
     }
-  )
+  })
 
   it('fetches recordings for Twilio-relative paths', async () => {
     const result = await listCalls(['/2010-04-01/Accounts/AC123/Calls/CA0/Recordings.json'])