fix(manageengine): address review findings

- display_id on problems, changes and solutions reused the timestamp property
  map, so generated metadata described a record number like "140" as epoch
  milliseconds. Give it its own map.
- parseSdpResponse turned a non-empty, non-JSON 2xx body into {} and reported
  success — a proxy or login page answering 200 with HTML would make a read look
  empty and a delete look like it worked. Throw instead; an empty body is still
  tolerated.
- Scope the docs setup step: connect a Zoho account, with client registration
  called out as self-hosted only.
- The block described notes on "any ITSM record"; only requests, problems and
  changes have note endpoints here.
- Assert all ten data-center hosts, not four, and guard the count so a new code
  fails the test until asserted.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HbUGaP3XyrSm3Lk3k959j2

Author: waleedlatif1

apps/docs/content/docs/integrations/manageengine_sdp.mdx

@@ -33,7 +33,7 @@ This integration covers 31 operations across five modules — full create, read,
 
 **Before you start**
 
-Register a client in the [Zoho API console](https://api-console.zoho.com/) and configure it as Sim's Zoho OAuth client. The same client serves Zoho Desk and ServiceDesk Plus — Zoho scopes are chosen per authorization request, not per registered client, so no second app is needed.
+Connect your Zoho account from the block's credential field. Self-hosted deployments additionally need Sim's Zoho OAuth client configured in the [Zoho API console](https://api-console.zoho.com/). The same client serves Zoho Desk and ServiceDesk Plus — Zoho scopes are chosen per authorization request, not per registered client, so no second app is needed.
 
 Three things shape what will work:
 
@@ -54,7 +54,7 @@ Three things shape what will work:
 
 ## Usage Instructions
 
-Full read and write access to ManageEngine ServiceDesk Plus Cloud: create, search, update and delete requests, problems, changes, assets and knowledge base solutions, and add notes to any ITSM record. Supports multi-portal accounts. Connecting requires a Zoho account in the US data center.
+Full read and write access to ManageEngine ServiceDesk Plus Cloud: create, search, update and delete requests, problems, changes, assets and knowledge base solutions, and add notes to requests, problems and changes. Supports multi-portal accounts. Connecting requires a Zoho account in the US data center.
 
 
 

apps/sim/blocks/blocks/manageengine-sdp.ts

@@ -106,7 +106,7 @@ export const ManageEngineSdpBlock: BlockConfig<SdpResponse> = {
     'Manage ServiceDesk Plus Cloud requests, problems, changes, assets, and knowledge base solutions',
   authMode: AuthMode.OAuth,
   longDescription:
-    'Full read and write access to ManageEngine ServiceDesk Plus Cloud: create, search, update and delete requests, problems, changes, assets and knowledge base solutions, and add notes to any ITSM record. Supports multi-portal accounts. Connecting requires a Zoho account in the US data center.',
+    'Full read and write access to ManageEngine ServiceDesk Plus Cloud: create, search, update and delete requests, problems, changes, assets and knowledge base solutions, and add notes to requests, problems and changes. Supports multi-portal accounts. Connecting requires a Zoho account in the US data center.',
   docsLink: 'https://docs.sim.ai/integrations/manageengine_sdp',
   category: 'tools',
   integrationType: IntegrationType.Support,

apps/sim/tools/generated/tool-outputs.ts

@@ -255,6 +255,25 @@ const TIME_PROPERTIES: Record<string, ToolOutputProperty> = {
   value: { type: 'string', description: 'Epoch milliseconds as a string', optional: true },
 }
 
+/**
+ * Problems, changes and solutions carry `display_id` as a `{ display_value,
+ * value }` pair — the same *shape* as a timestamp but not the same meaning:
+ * `display_value` is the prefixed record number shown in the UI ("PB-140",
+ * "CH 44", "SOL-1") and `value` is its bare sequence number ("140"). Declared
+ * separately from {@link TIME_PROPERTIES} so the generated tool metadata never
+ * tells a consumer that `140` is epoch milliseconds.
+ *
+ * Requests differ again: their `display_id` is a plain string.
+ */
+const DISPLAY_ID_PROPERTIES: Record<string, ToolOutputProperty> = {
+  display_value: {
+    type: 'string',
+    description: 'Record number as shown in the UI, e.g. PB-140',
+    optional: true,
+  },
+  value: { type: 'string', description: 'Bare sequence number, e.g. 140', optional: true },
+}
+
 const USER_PROPERTIES: Record<string, ToolOutputProperty> = {
   id: { type: 'string', description: 'User ID', optional: true },
   name: { type: 'string', description: 'User name', optional: true },
@@ -494,7 +513,7 @@ export const SDP_PROBLEM_PROPERTIES: Record<string, ToolOutputProperty> = {
     description: 'Problem number shown in the SDP UI',
     optional: true,
     nullable: true,
-    properties: TIME_PROPERTIES,
+    properties: DISPLAY_ID_PROPERTIES,
   },
   title: { type: 'string', description: 'Problem title', optional: true },
   description: {
@@ -632,7 +651,7 @@ export const SDP_CHANGE_PROPERTIES: Record<string, ToolOutputProperty> = {
     description: 'Change number shown in the SDP UI',
     optional: true,
     nullable: true,
-    properties: TIME_PROPERTIES,
+    properties: DISPLAY_ID_PROPERTIES,
   },
   title: { type: 'string', description: 'Change title', optional: true },
   description: {
@@ -901,7 +920,7 @@ export const SDP_SOLUTION_PROPERTIES: Record<string, ToolOutputProperty> = {
     description: 'Solution number shown in the SDP UI',
     optional: true,
     nullable: true,
-    properties: TIME_PROPERTIES,
+    properties: DISPLAY_ID_PROPERTIES,
   },
   title: { type: 'string', description: 'Solution title', optional: true },
   description: {

apps/sim/tools/manageengine_sdp/types.ts

@@ -21,11 +21,27 @@ function jsonResponse(body: unknown, status = 200): Response {
 }
 
 describe('resolveSdpBase', () => {
+  /**
+   * All ten hosts are asserted literally, not derived from the map under test —
+   * these are transcribed from the docs' "API endpoints by data center" table,
+   * and the apex changes with the region (US/EU/IN sit under
+   * `sdpondemand.manageengine.*`, the rest under their own `servicedeskplus.*`),
+   * so a typo in any one of them would otherwise ship silently.
+   */
   it('maps every data center code to its documented host', () => {
     expect(resolveSdpBase('US')).toBe('https://sdpondemand.manageengine.com')
     expect(resolveSdpBase('EU')).toBe('https://sdpondemand.manageengine.eu')
+    expect(resolveSdpBase('IN')).toBe('https://sdpondemand.manageengine.in')
     expect(resolveSdpBase('AU')).toBe('https://servicedeskplus.net.au')
     expect(resolveSdpBase('JP')).toBe('https://servicedeskplus.jp')
+    expect(resolveSdpBase('CA')).toBe('https://servicedeskplus.ca')
+    expect(resolveSdpBase('SA')).toBe('https://servicedeskplus.sa')
+    expect(resolveSdpBase('UK')).toBe('https://servicedeskplus.uk')
+    expect(resolveSdpBase('CN')).toBe('https://servicedeskplus.cn')
+    expect(resolveSdpBase('AE')).toBe('https://servicedeskplus.ae')
+    // Guards the test itself: if a code is added to the map, this fails until
+    // an assertion for it is added above.
+    expect(Object.keys(SDP_DATA_CENTER_BASES)).toHaveLength(10)
   })
 
   it('accepts a lower-case code, since the value round-trips through workflow JSON', () => {
@@ -225,6 +241,32 @@ describe('parseSdpResponse', () => {
     )
   })
 
+  it('throws on a 2xx whose body is not JSON, rather than reporting success', async () => {
+    // A proxy or captive login page answering 200 with HTML. Swallowing this
+    // would report a read as empty and a delete as having succeeded.
+    const html = new Response('<html><body>Sign in</body></html>', {
+      status: 200,
+      headers: { 'Content-Type': 'text/html' },
+    })
+    await expect(parseSdpResponse(html, 'Failed to delete request')).rejects.toThrow(/non-JSON/)
+  })
+
+  it('throws on a 2xx whose body is valid JSON but not an object', async () => {
+    const scalar = new Response('"ok"', {
+      status: 200,
+      headers: { 'Content-Type': 'application/json' },
+    })
+    await expect(parseSdpResponse(scalar, 'Failed to get request')).rejects.toThrow(/non-JSON/)
+  })
+
+  it('tolerates an empty 2xx body, which carries nothing this layer needs', async () => {
+    // `null` rather than `''`: the Response constructor rejects a 204 with a body.
+    const noContent = new Response(null, { status: 204 })
+    await expect(parseSdpResponse(noContent, 'Failed to delete request')).resolves.toEqual({})
+    const blank = new Response('   ', { status: 200 })
+    await expect(parseSdpResponse(blank, 'Failed to delete request')).resolves.toEqual({})
+  })
+
   it('throws on a 200 whose response_status reports a failure', async () => {
     await expect(
       parseSdpResponse(

apps/sim/tools/manageengine_sdp/utils.test.ts

@@ -205,10 +205,33 @@ export async function parseSdpResponse(
   response: Response,
   fallbackMessage: string
 ): Promise<Record<string, unknown>> {
-  const data = (await response.json().catch(() => ({}))) as Record<string, unknown>
+  const text = await response.text().catch(() => '')
+  let data: Record<string, unknown> = {}
+  let malformed = false
+  if (text.trim()) {
+    try {
+      const parsed = JSON.parse(text)
+      data = parsed && typeof parsed === 'object' ? (parsed as Record<string, unknown>) : {}
+      malformed = data !== parsed
+    } catch {
+      malformed = true
+    }
+  }
+
   if (!response.ok) {
     throw new Error(getSdpErrorMessage(data, `${fallbackMessage} (HTTP ${response.status})`))
   }
+
+  // A 2xx whose body is present but is not a JSON object did not come from the
+  // v3 API — a proxy or a captive login page answering 200 with HTML is the
+  // realistic case. Swallowing it would report a read as empty, and worse,
+  // report a delete as having succeeded. An empty body is tolerated, since a
+  // success carries no field this layer requires.
+  if (malformed) {
+    throw new Error(
+      `${fallbackMessage}: ServiceDesk Plus returned a non-JSON response (HTTP ${response.status}). Check the data center and portal settings.`
+    )
+  }
   const failed = toResponseStatusEntries(data).some((entry) => entry.status === 'failed')
   if (failed) {
     throw new Error(getSdpErrorMessage(data, fallbackMessage))

apps/sim/tools/manageengine_sdp/utils.ts

@@ -14585,7 +14585,7 @@
       "slug": "manageengine-servicedesk-plus",
       "name": "ManageEngine ServiceDesk Plus",
       "description": "Manage ServiceDesk Plus Cloud requests, problems, changes, assets, and knowledge base solutions",
-      "longDescription": "Full read and write access to ManageEngine ServiceDesk Plus Cloud: create, search, update and delete requests, problems, changes, assets and knowledge base solutions, and add notes to any ITSM record. Supports multi-portal accounts. Connecting requires a Zoho account in the US data center.",
+      "longDescription": "Full read and write access to ManageEngine ServiceDesk Plus Cloud: create, search, update and delete requests, problems, changes, assets and knowledge base solutions, and add notes to requests, problems and changes. Supports multi-portal accounts. Connecting requires a Zoho account in the US data center.",
       "bgColor": "#FFFFFF",
       "iconName": "ManageEngineIcon",
       "docsUrl": "https://docs.sim.ai/integrations/manageengine_sdp",