fix(logs): read a snapshot view's execution data with the timing and cost it pairs with

Author: waleedlatif1

apps/sim/lib/logs/application/read-execution-snapshot.test.ts

@@ -66,6 +66,13 @@ const workspaceContext = {
   billedAccountUserId: 'billing-owner-1',
 }
 
+const completedRun = {
+  executionData: null,
+  endedAt: new Date('2026-08-05T12:00:01.000Z'),
+  totalDurationMs: 1000,
+  costTotal: '0.75',
+}
+
 const workflowRecord = {
   id: 'log-1',
   workflowId: 'workflow-1',
@@ -140,7 +147,7 @@ describe('readExecutionSnapshot spend projection', () => {
     queueSelects(
       [workflowRecord],
       [{ id: 'snapshot-1', stateData: { blocks: {} } }],
-      [{ executionData: null }]
+      [completedRun]
     )
 
     const result = await read(principal, 'run-1')
@@ -162,12 +169,28 @@ describe('readExecutionSnapshot spend projection', () => {
     queueSelects(
       [workflowRecord],
       [{ id: 'snapshot-1', stateData: { blocks: {} } }],
-      [{ executionData: null }]
+      [completedRun]
     )
 
     const result = await read(executorPrincipal, 'run-1')
 
     expect(result.executionMetadata.cost).toEqual({ total: 0.75 })
     expect(permissionGroupScopeMockFns.mockResolvePermissionGroupConfig).not.toHaveBeenCalled()
   })
+
+  it('reports the timing and cost read with the execution data, not the earlier context', async () => {
+    queueSelects(
+      [{ ...workflowRecord, endedAt: null, totalDurationMs: null, costTotal: null }],
+      [{ id: 'snapshot-1', stateData: { blocks: {} } }],
+      [completedRun]
+    )
+
+    const result = await read(executorPrincipal, 'run-1')
+
+    expect(result.executionMetadata).toMatchObject({
+      endedAt: '2026-08-05T12:00:01.000Z',
+      totalDurationMs: 1000,
+      cost: { total: 0.75 },
+    })
+  })
 })

apps/sim/lib/logs/application/read-execution-snapshot.ts

@@ -138,16 +138,23 @@ async function readSnapshotStates(
 }
 
 /**
- * Read here, after authorization, rather than with the context: a caller the
- * use case refuses never fetches the run's execution data.
+ * The run's execution data with the fields a completion write changes alongside it,
+ * read in one statement after authorization: a caller the use case refuses never
+ * fetches the payload, and a run finishing mid-request cannot pair new data with
+ * stale timing or cost.
  */
-async function readExecutionData(executionId: string): Promise<unknown> {
+async function readRunCompletion(executionId: string) {
   const [row] = await db
-    .select({ executionData: workflowExecutionLogs.executionData })
+    .select({
+      executionData: workflowExecutionLogs.executionData,
+      endedAt: workflowExecutionLogs.endedAt,
+      totalDurationMs: workflowExecutionLogs.totalDurationMs,
+      costTotal: workflowExecutionLogs.costTotal,
+    })
     .from(workflowExecutionLogs)
     .where(eq(workflowExecutionLogs.executionId, executionId))
     .limit(1)
-  return row?.executionData ?? null
+  return row
 }
 
 function collectChildSnapshotIds(traceSpans: TraceSpan[]): string[] {
@@ -215,8 +222,10 @@ const authorizedReadExecutionSnapshotUseCase = defineAuthorizedWorkspaceUseCase(
     }
 
     input.signal?.throwIfAborted()
+    const completion = await readRunCompletion(record.executionId)
+    if (!completion) throw new OrchestrationError('not_found', 'Workflow execution not found')
     const executionData = (await materializeExecutionData(
-      (await readExecutionData(record.executionId)) as Record<string, unknown> | null,
+      completion.executionData as Record<string, unknown> | null,
       {
         workspaceId: context.workspaceId,
         workflowId: record.workflowId,
@@ -246,9 +255,9 @@ const authorizedReadExecutionSnapshotUseCase = defineAuthorizedWorkspaceUseCase(
       executionMetadata: {
         trigger: record.trigger,
         startedAt: record.startedAt.toISOString(),
-        endedAt: record.endedAt?.toISOString(),
-        totalDurationMs: record.totalDurationMs,
-        cost: projectCostTotal(record.costTotal, projection),
+        endedAt: completion.endedAt?.toISOString(),
+        totalDurationMs: completion.totalDurationMs,
+        cost: projectCostTotal(completion.costTotal, projection),
       },
     }
   },