test(org): press a shortcut only once hydration can answer it

The listeners attach on hydration while the field and the collapsed attribute are server-rendered, so a key straight after load reached nothing. The sidebar's Mod+B check made the same assumption and had yet to lose the race.

Author: waleedlatif1

apps/sim/scripts/org-redesign-e2e/checks/settings.ts

@@ -337,8 +337,11 @@ export async function settingsChecks() {
         await page.goto(orgUrl('/settings/members'))
         const rail = sidebar(page)
         const field = rail.getByRole('searchbox', { name: 'Search settings' })
-        await page.keyboard.press('/')
-        await expect(field).toBeFocused()
+        // Answered from hydration on, which the server-rendered field does not wait for.
+        await expect(async () => {
+          await page.keyboard.press('/')
+          await expect(field).toBeFocused({ timeout: 1_000 })
+        }).toPass({ timeout: 20_000 })
         await field.fill('password')
         await rail.getByRole('link', { name: 'Reset password', exact: true }).click()
         await expect(page).toHaveURL(orgUrl('/settings/general'))

apps/sim/scripts/org-redesign-e2e/checks/sidebar.ts

@@ -124,6 +124,8 @@ export async function sidebarChecks() {
         )
         await page.reload()
         await expect(rail).toHaveAttribute('data-collapsed', 'true')
+        // The server renders the attribute, so only this says the shortcut is listening.
+        await expect(composer(page)).toBeFocused()
         await page.locator('body').click({ position: { x: 700, y: 20 } })
         await page.keyboard.press('Control+b')
         await expect(rail).not.toHaveAttribute('data-collapsed', 'true')